upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-02-15 08:37:49 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

CLEANUP: tools: Clean up non-QUIC error message handling in str2sa_range()

Browse source 
If QUIC support is enabled both branches of the ternary conditional are
identical, upsetting Coverity. Move the full conditional into the non-QUIC
preprocessor branch to make the code more clear.

This resolves GitHub issue #1710.
This commit is contained in:
Tim Duesterhus 2022-05-22 12:40:58 +02:00 committed by Willy Tarreau
parent 137c8fde78
commit 147eeb2ef3
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/tools.c
View file

@ -1305,13 +1305,14 @@ struct sockaddr_storage *str2sa_range(const char *str, int *port, int *low, int
(proto_type == PROTO_TYPE_DGRAM) ? "datagram" : "stream",
ss.ss_family,
str,
(ctrl_type == SOCK_STREAM && proto_type == PROTO_TYPE_DGRAM) ?
#ifndef USE_QUIC
"; QUIC is not compiled in if this is what you were looking for."
(ctrl_type == SOCK_STREAM && proto_type == PROTO_TYPE_DGRAM)
? "; QUIC is not compiled in if this is what you were looking for."
: ""
#else
""
#endif
:"");
);
goto out;
}