upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-03-23 02:43:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

BUG/MEDIUM: h2: Remove the tasklet from the task list if unsubscribing.

Browse source 
In h2_unsubscribe(), if we unsubscribe on SUB_CALL_UNSUBSCRIBE, then remove
ourself from the sending_list, and remove the tasklet from the task list.
We're probably about to destroy the stream anyway, so we don't want the
tasklet to run, or to stay in the sending_list, or it could lead to a crash.

This should be backpored to 1.9.
This commit is contained in:
Olivier Houchard 2019-03-25 14:10:42 +01:00 committed by Olivier Houchard
parent afc7cb85c4
commit 3ea3513689
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/mux_h2.c
View file

@ -5182,9 +5182,11 @@ static int h2_unsubscribe(struct conn_stream *cs, int event_type, void *param)
sw = param;
if (h2s->send_wait == sw) {
sw->events &= ~SUB_CALL_UNSUBSCRIBE;
task_remove_from_task_list((struct task *)h2s->send_wait->task);
h2s->send_wait = NULL;
LIST_DEL(&h2s->list);
LIST_INIT(&h2s->list);
LIST_DEL_INIT(&h2s->sending_list);
}
}
return 0;