upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-05-27 03:33:36 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 16

BUG/MINOR: http-fetch: make http_first_req() check for HTTP first

Browse source 
smp_fetch_http_first_req() reads ->txn.http->flags without first
checking if txn.http is properly allocated. In theory if called from
the wrong context it could crash, even though tests where it's called
from "tcp-request content" don't seem to have any effect. Let's fix
it regardless, at least to dissipate the doubt. It can be backported
everywhere.
This commit is contained in:
Willy Tarreau 2026-05-11 14:58:45 +02:00
parent 15c5226bd3
commit 8941cc5f6d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/http_fetch.c
View file

@ -1355,7 +1355,7 @@ static int smp_fetch_proto_http(const struct arg *args, struct sample *smp, cons
/* return a valid test if the current request is the first one on the connection */
static int smp_fetch_http_first_req(const struct arg *args, struct sample *smp, const char *kw, void *private)
{
if (!smp->strm)
if (!smp->strm || !smp->strm->txn.http)
return 0;
smp->data.type = SMP_T_BOOL;