upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-02-22 01:10:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BUG/MINOR: stats: fix compare of no-maint url suffix

Browse source 
Only the first 3 characters are compared for ';no-maint' suffix in
http_handle_stats. Fix it by doing a full match over the entire suffix.

As a side effect, the ';norefresh' suffix matched the inaccurate
comparison, so the maintenance servers were always hidden on the stats
page in this case.

no-maint suffix is present since commit
  3e32036701
  MINOR: stats: also support a "no-maint" show stat modifier

It should be backported up to 2.3.

This fixes github issue #1147.
This commit is contained in:
Amaury Denoyelle 2021-02-25 14:46:08 +01:00
parent 6c93c4ef08
commit 91e55ea3f3
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/http_ana.c
View file

@ -3950,7 +3950,10 @@ static int http_handle_stats(struct stream *s, struct channel *req)
appctx->ctx.stats.flags |= STAT_HIDE_DOWN;
break;
}
if (memcmp(h, ";no-maint", 3) == 0) {
}
for (h = lookup; h <= end - 9; h++) {
if (memcmp(h, ";no-maint", 9) == 0) {
appctx->ctx.stats.flags |= STAT_HIDE_MAINT;
break;
}