upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-02-03 20:39:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

BUG/MEDIUM: applet: Fix test on shut flags for legacy applets
Some checks failed
Contrib / build (push) Has been cancelled
Details
alpine/musl / gcc (push) Has been cancelled
Details
VTest / Generate Build Matrix (push) Has been cancelled
Details
Windows / Windows, gcc, all features (push) Has been cancelled
Details
VTest / (push) Has been cancelled
Details

Browse source 
A regression was introduced in the commit 0ea601127 ("BUG/MAJOR: applet: Don't
call I/O handler if the applet was shut"). The test on shut flags for legacy
applets is inverted.

It should be harmeless on 3.4 and 3.3 because all applets were converted. But
this fix is mandatory for 3.2 and older.

The patch must be backported as far as 3.0 with the commit above.
This commit is contained in:
Christopher Faulet 2026-01-30 09:51:00 +01:00
parent 02e6375017
commit abc1947e19
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applet.c
View file

@ -852,7 +852,7 @@ struct task *task_run_applet(struct task *t, void *context, unsigned int state)
/* Don't call I/O handler if the applet was shut (release callback was /* Don't call I/O handler if the applet was shut (release callback was
* already called) * already called)
*/ */
if (se_fl_test(app->sedesc, SE_FL_SHR | SE_FL_SHW)) if (!se_fl_test(app->sedesc, SE_FL_SHR | SE_FL_SHW))
app->applet->fct(app); app->applet->fct(app);
TRACE_POINT(APPLET_EV_PROCESS, app); TRACE_POINT(APPLET_EV_PROCESS, app);