upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-22 06:37:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

CLEANUP: backend: remove useless test for inexistent connection

Browse source 
Coverity rightfully reported that it's pointless to test for "conn"
to be null while all code paths leading to it have already
dereferenced it. This addresses issue #461.
This commit is contained in:
Willy Tarreau 2020-01-23 11:36:33 +01:00
parent 75b15f790f
commit b1a40c72e7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backend.c
View file

@ -1956,7 +1956,7 @@ void back_handle_st_con(struct stream *s)
done:
/* retryable error ? */
if (si->flags & (SI_FL_EXP|SI_FL_ERR)) {
if (!(s->flags & SF_SRV_REUSED) && conn) {
if (!(s->flags & SF_SRV_REUSED)) {
conn_stop_tracking(conn);
conn_full_close(conn);
}