upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-03-06 07:10:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

BUG/MEDIUM: sessions: Don't keep an extra idle connection in sessions.

Browse source 
When deciding if we keep an idle connection in the session, check if
the number of connections currently in the session is >= the max allowed,
not >, or we'll keep an extra connection.

This should be backported to 1.9 and 2.0.
This commit is contained in:
Olivier Houchard 2019-07-04 14:26:41 +02:00 committed by Olivier Houchard
parent 8d82db70a5
commit cee0389088
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/proto/session.h
View file

@ -120,7 +120,7 @@ static inline int session_add_conn(struct session *sess, struct connection *conn
/* Returns 0 if the session can keep the idle conn, -1 if it was destroyed, or 1 if it was added to the server list */
static inline int session_check_idle_conn(struct session *sess, struct connection *conn)
{
if (sess->idle_conns > sess->fe->max_out_conns) {
if (sess->idle_conns >= sess->fe->max_out_conns) {
/* We can't keep the connection, let's try to add it to the server idle list */
session_unown_conn(sess, conn);
conn->owner = NULL;