HTTP/3 parser cannot deal with unaligned frames, except for DATA. As it was expected that such case would not occur, a simple BUG_ON() was written to protect HEADERS parsing. First, this BUG_ON() was incorrectly written due an incorrect operator '>=' vs '>' when checking if data wraps. Thus this patch correct it. However this correction is not sufficient as it still possible to handle a large unaligned HEADERS frame, which would trigger this BUG_ON(). This is very unlikely as HEADERS is the first received frame on a request stream, but not completely impossible. As HTTP/3 frame header (type + length) is parsed first and removed, this leaves a small gap at the buffer beginning. If this small gap is then filled with the remaining frame payload, it would result in unaligned data. Also, trailers are also sensitive here as in this case a HEADERS frame is handled after other frames. The objective of this patch is to ensure that an unaligned frame is now handled in a safe way. This is extend to all HTTP/3 frames (except DATA) and not only to HEADERS type. Parsing is interrupted if frame payload is wrapping in the buffer. This should never happen except maybe with some weird clients, so the connection is closed with H3_EXCESSIVE_LOAD error. This approach is considered the safest one, in particular for backport purpose. In the future, realign operation via copy may be implemented instead if considered as useful. This must be backported up to 2.6. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| BSDmakefile | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README.md | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
HAProxy
HAProxy is a free, very fast and reliable reverse-proxy offering high availability, load balancing, and proxying for TCP and HTTP-based applications.
Installation
The INSTALL file describes how to build HAProxy. A list of packages is also available on the wiki.
Getting help
The discourse and the mailing-list are available for questions or configuration assistance. You can also use the slack or IRC channel. Please don't use the issue tracker for these.
The issue tracker is only for bug reports or feature requests.
Documentation
The HAProxy documentation has been split into a number of different files for ease of use. It is available in text format as well as HTML. The wiki is also meant to replace the old architecture guide.
Please refer to the following files depending on what you're looking for:
- INSTALL for instructions on how to build and install HAProxy
- BRANCHES to understand the project's life cycle and what version to use
- LICENSE for the project's license
- CONTRIBUTING for the process to follow to submit contributions
The more detailed documentation is located into the doc/ directory:
- doc/intro.txt for a quick introduction on HAProxy
- doc/configuration.txt for the configuration's reference manual
- doc/lua.txt for the Lua's reference manual
- doc/SPOE.txt for how to use the SPOE engine
- doc/network-namespaces.txt for how to use network namespaces under Linux
- doc/management.txt for the management guide
- doc/regression-testing.txt for how to use the regression testing suite
- doc/peers.txt for the peers protocol reference
- doc/coding-style.txt for how to adopt HAProxy's coding style
- doc/internals for developer-specific documentation (not all up to date)
License
HAProxy is licensed under GPL 2 or any later version, the headers under LGPL 2.1. See the LICENSE file for a more detailed explanation.
