mirror of
https://github.com/haproxy/haproxy.git
synced 2026-04-25 16:17:21 -04:00
HAProxy - Load balancer
8d5def0bab
The quic_stream frame stores the qcs instance. On ACK parsing, qcs is accessed to clear the stream buffer. This can cause a segfault if the MUX or the qcs is already released. Consider the following scenario : 1. a STREAM frame is generated by the MUX transport layer emits the frame with PKN=1 upper layer has finished the transfer so related qcs is detached 2. transport layer reemits the frame with PKN=2 because ACK was not received 3. ACK for PKN=1 is received, stream buffer is cleared at this stage, qcs may be freed by the MUX as it is detached 4. ACK for PKN=2 is received qcs for STREAM frame is dereferenced which will lead to a crash To prevent this, qcs is never accessed from the quic_stream during ACK parsing. Instead, a lookup is done on the MUX streams tree. If the MUX is already released, no lookup is done. These checks prevents a possible segfault. This change may have an impact on the perf as now we are forced to use a tree lookup operation. If this is the case, an alternative solution may be to implement a refcount on qcs instances. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README | ||
| ROADMAP | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)