haproxy/include/haproxy/chunk.h
Willy Tarreau b794190262 BUG/MEDIUM: chunk: do not rely on small trash by default for expressions
There's a corner case with get_trash_chunk_sz() combined with the use
of small bufs: if some incoming data is going to be inflated by a
converter in a non-predictable way (say url_enc etc) then there are
two possibilities:
  - either we try to allocate a size that corresponds to the data, but
    we risk to allocate a small buf to convert a 900B chunk, that will
    now fail if it contains too many non-printable chars;
  - or we try to allocate 3x the size to be conservative, but without
    large bufs we'd fail to transcode any chunk larger than 5.3kB, even
    if it contains only printable chars.

The approach should definitely be refined and it is not 100% reliable
for now. Better temporarily ignore the small buffers for these particular
cases where the savings are not relevant, and see how to pass the knowledge
of the expected size ranges deeper down the API in 3.5. We may possibly rely
on the current trash size (instead of contents) or other mechanisms that
are yet to be specified. alloc_small_trash_chunk() gets the same change
BTW for the same reasons.

The comment for get_trash_chunk_sz() was updated to restate the importance
of being conservative when requesting a size.

No backport is needed.
2026-06-03 14:45:54 +02:00

375 lines
9.6 KiB
C

/*
* include/haproxy/chunk.h
* Chunk management definitions, macros and inline functions.
*
* Copyright (C) 2000-2012 Willy Tarreau - w@1wt.eu
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation, version 2.1
* exclusively.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
#ifndef _HAPROXY_CHUNK_H
#define _HAPROXY_CHUNK_H
#include <stdlib.h>
#include <string.h>
#include <import/ist.h>
#include <haproxy/api.h>
#include <haproxy/buf-t.h>
#include <haproxy/pool.h>
extern struct pool_head *pool_head_trash;
extern struct pool_head *pool_head_large_trash;
extern struct pool_head *pool_head_small_trash;
/* function prototypes */
int chunk_printf(struct buffer *chk, const char *fmt, ...)
__attribute__ ((format(printf, 2, 3)));
int chunk_appendf(struct buffer *chk, const char *fmt, ...)
__attribute__ ((format(printf, 2, 3)));
int chunk_htmlencode(struct buffer *dst, struct buffer *src);
int chunk_asciiencode(struct buffer *dst, struct buffer *src, char qc);
int chunk_strcmp(const struct buffer *chk, const char *str);
int chunk_strcasecmp(const struct buffer *chk, const char *str);
struct buffer *get_trash_chunk(void);
struct buffer *get_large_trash_chunk(void);
struct buffer *get_small_trash_chunk(void);
struct buffer *get_trash_chunk_sz(size_t size);
struct buffer *get_larger_trash_chunk(struct buffer *chunk);
int init_trash_buffers(int first);
static inline void chunk_reset(struct buffer *chk)
{
chk->data = 0;
}
static inline void chunk_init(struct buffer *chk, char *str, size_t size)
{
chk->area = str;
chk->head = 0;
chk->data = 0;
chk->size = size;
}
/* report 0 in case of error, 1 if OK. */
static inline int chunk_initlen(struct buffer *chk, char *str, size_t size,
int len)
{
if (len < 0 || (size && len > size))
return 0;
chk->area = str;
chk->head = 0;
chk->data = len;
chk->size = size;
return 1;
}
/* this is only for temporary manipulation, the chunk is read-only */
static inline void chunk_initstr(struct buffer *chk, const char *str)
{
chk->area = (char *)str;
chk->head = 0;
chk->data = strlen(str);
chk->size = 0; /* mark it read-only */
}
/*
* Allocate a trash chunk from the reentrant pool. The buffer starts at the
* end of the chunk. This chunk must be freed using free_trash_chunk(). This
* call may fail and the caller is responsible for checking that the returned
* pointer is not NULL.
*/
static forceinline struct buffer *alloc_trash_chunk(void)
{
struct buffer *chunk;
chunk = pool_alloc(pool_head_trash);
if (chunk) {
char *buf = (char *)chunk + sizeof(struct buffer);
*buf = 0;
chunk_init(chunk, buf,
pool_head_trash->size - sizeof(struct buffer));
}
return chunk;
}
/*
* Allocate a large trash chunk from the reentrant pool. The buffer starts at
* the end of the chunk. This chunk must be freed using free_trash_chunk(). This
* call may fail and the caller is responsible for checking that the returned
* pointer is not NULL.
*/
static forceinline struct buffer *alloc_large_trash_chunk(void)
{
struct buffer *chunk;
if (!pool_head_large_trash)
return NULL;
chunk = pool_alloc(pool_head_large_trash);
if (chunk) {
char *buf = (char *)chunk + sizeof(struct buffer);
*buf = 0;
chunk_init(chunk, buf,
pool_head_large_trash->size - sizeof(struct buffer));
}
return chunk;
}
/*
* Allocate a small trash chunk from the reentrant pool. The buffer starts at
* the end of the chunk. This chunk must be freed using free_trash_chunk(). This
* call may fail and the caller is responsible for checking that the returned
* pointer is not NULL.
*/
static forceinline struct buffer *alloc_small_trash_chunk(void)
{
struct buffer *chunk;
if (!pool_head_small_trash)
return NULL;
chunk = pool_alloc(pool_head_small_trash);
if (chunk) {
char *buf = (char *)chunk + sizeof(struct buffer);
*buf = 0;
chunk_init(chunk, buf,
pool_head_small_trash->size - sizeof(struct buffer));
}
return chunk;
}
/*
* Allocate a trash chunk accordingly to the requested size. This chunk must be
* freed using free_trash_chunk(). This call may fail and the caller is
* responsible for checking that the returned pointer is not NULL.
*/
static forceinline struct buffer *alloc_trash_chunk_sz(size_t size)
{
if (size <= pool_head_trash->size)
return alloc_trash_chunk();
else if (pool_head_large_trash && size <= pool_head_large_trash->size)
return alloc_large_trash_chunk();
else
return NULL;
}
/*
* free a trash chunk allocated by alloc_trash_chunk(). NOP on NULL.
*/
static forceinline void free_trash_chunk(struct buffer *chunk)
{
if (pool_head_small_trash && chunk && chunk->size == pool_head_small_trash->size - sizeof(struct buffer))
pool_free(pool_head_small_trash, chunk);
else if (pool_head_large_trash && chunk && chunk->size == pool_head_large_trash->size - sizeof(struct buffer))
pool_free(pool_head_large_trash, chunk);
else
pool_free(pool_head_trash, chunk);
}
/* copies chunk <src> into <chk>. Returns 0 in case of failure. */
static inline int chunk_cpy(struct buffer *chk, const struct buffer *src)
{
if (unlikely(src->data > chk->size))
return 0;
chk->data = src->data;
memcpy(chk->area, src->area, src->data);
return 1;
}
/* copies memory area <src> into <chk> for <len> bytes. Returns 0 in
* case of failure. No trailing zero is added.
*/
static inline int chunk_memcpy(struct buffer *chk, const char *src,
size_t len)
{
if (unlikely(len > chk->size))
return 0;
chk->data = len;
memcpy(chk->area, src, len);
return 1;
}
/* appends memory area <src> after <chk> for <len> bytes. Returns 0 in
* case of failure. No trailing zero is added.
*/
static inline int chunk_memcat(struct buffer *chk, const char *src,
size_t len)
{
if (unlikely(chk->data + len > chk->size))
return 0;
memcpy(chk->area + chk->data, src, len);
chk->data += len;
return 1;
}
/* appends ist <src> after <chk>. Returns 0 in case of failure. */
static inline int chunk_istcat(struct buffer *chk, const struct ist src)
{
return chunk_memcat(chk, istptr(src), istlen(src));
}
/* appends chunk <src> after <chk>. Returns 0 in case of failure. */
static inline int chunk_cat(struct buffer *chk, const struct buffer *src)
{
return chunk_memcat(chk, src->area, src->data);
}
/* copies str into <chk> followed by a trailing zero. Returns 0 in
* case of failure.
*/
static inline int chunk_strcpy(struct buffer *chk, const char *str)
{
size_t len;
len = strlen(str);
if (unlikely(len >= chk->size))
return 0;
chk->data = len;
memcpy(chk->area, str, len + 1);
return 1;
}
/* copies at most <max> chars from str into <chk> followed by a trailing zero.
* Returns 0 in case of failure.
*/
static inline int chunk_strncpy(struct buffer *chk, const char *str, size_t max)
{
size_t len;
len = strlen(str);
if (len > max)
len = max;
if (unlikely(len >= chk->size))
return 0;
memcpy(chk->area, str, len);
chk->area[len] = 0;
chk->data = len;
return 1;
}
/* appends str after <chk> followed by a trailing zero. Returns 0 in
* case of failure.
*/
static inline int chunk_strcat(struct buffer *chk, const char *str)
{
size_t len;
len = strlen(str);
if (unlikely(chk->data + len >= chk->size))
return 0;
memcpy(chk->area + chk->data, str, len + 1);
chk->data += len;
return 1;
}
/* Adds a trailing zero to the current chunk and returns the pointer to the
* following part. The purpose is to be able to use a chunk as a series of
* short independent strings with chunk_* functions, which do not need to be
* released. Returns NULL if no space is available to ensure that the new
* string will have its own trailing zero. For example :
* chunk_init(&trash);
* pid = chunk_newstr(&trash);
* chunk_appendf(&trash, "%d", getpid()));
* name = chunk_newstr(&trash);
* chunk_appendf(&trash, "%s", gethosname());
* printf("hostname=<%s>, pid=<%d>\n", name, pid);
*/
static inline char *chunk_newstr(struct buffer *chk)
{
if (chk->data + 1 >= chk->size)
return NULL;
chk->area[chk->data++] = 0;
return chk->area + chk->data;
}
static inline void chunk_drop(struct buffer *chk)
{
chk->area = NULL;
chk->data = -1;
chk->size = 0;
}
static inline void chunk_destroy(struct buffer *chk)
{
if (!chk->size)
return;
free(chk->area);
chunk_drop(chk);
}
/*
* frees the destination chunk if already allocated, allocates a new string,
* and copies the source into it. The new chunk will have extra room for a
* trailing zero unless the source chunk was actually full. The pointer to
* the destination string is returned, or NULL if the allocation fails or if
* any pointer is NULL.
*/
static inline char *chunk_dup(struct buffer *dst, const struct buffer *src)
{
if (!dst || !src || !src->area)
return NULL;
if (dst->size)
free(dst->area);
dst->head = src->head;
dst->data = src->data;
dst->size = src->data;
if (dst->size < src->size || !src->size)
dst->size++;
dst->area = malloc(dst->size);
if (!dst->area) {
dst->head = 0;
dst->data = 0;
dst->size = 0;
return NULL;
}
memcpy(dst->area, src->area, dst->data);
if (dst->data < dst->size)
dst->area[dst->data] = 0;
return dst->area;
}
#endif /* _HAPROXY_CHUNK_H */
/*
* Local variables:
* c-indent-level: 8
* c-basic-offset: 8
* End:
*/