mirror of
https://github.com/haproxy/haproxy.git
synced 2026-02-14 00:04:00 -05:00
320ec2a745
The recent addition of "show env" on the CLI has revealed an interesting design bug. Chunks are supposed to support a negative length to indicate that they carry no data. chunk_printf() sets this size to -1 if the string is too large for the buffer. At a few places in the http engine we may end up with trash.len = -1. But bi_putchk(), chunk_appendf() and a few other chunks consumers don't consider this case as possible and will use such a chunk, possibly restoring an invalid string or trying to copy -1 bytes. This fix takes care of clarifying the situation in a backportable way where such sizes are used, so that a negative length indicating an error remains present until the chunk is reinitialized or overwritten. But a cleaner design adjustment needs to be done so that there's a clear contract on how to use these chunks. At first glance it doesn't seem *that* useful to support negative sizes, so probably this is what should change. This fix must be backported to 1.6 and 1.5. |
||
|---|---|---|
| .. | ||
| accept4.h | ||
| base64.h | ||
| buffer.h | ||
| cfgparse.h | ||
| chunk.h | ||
| compat.h | ||
| compiler.h | ||
| config.h | ||
| debug.h | ||
| defaults.h | ||
| epoll.h | ||
| errors.h | ||
| hash.h | ||
| memory.h | ||
| mini-clist.h | ||
| namespace.h | ||
| rbtree.h | ||
| regex.h | ||
| splice.h | ||
| standard.h | ||
| syscall.h | ||
| template.h | ||
| ticks.h | ||
| time.h | ||
| tools.h | ||
| uri_auth.h | ||
| version.h | ||