Willy Tarreau a68f7629dd BUG/MEDIUM: stick-tables: fix double-decrement of tracked entries ... Mailing list participant "mlist" reported negative conn_cur values in stick tables as the result of "tcp-request connection track-sc". The reason is that after the stick entry it copied from the session to the stream, both the session and the stream grab a reference to the entry and when the stream ends, it decrements one reference and one connection, then the same is done for the session. In fact this problem was already encountered slightly differently in the past and addressed by Thierry using the patch below as it was believed by then to be only a refcount issue since it was the observable symptom : 827752e "BUG/MEDIUM: stick-tables: refcount error after copying SC..." In reality the problem is that the stream must touch neither the refcount nor the connection count for entries it inherits from the session. While we have no way to tell whether a track entry was inherited from the session (since they're simply memcpy'd), it is possible to prevent the stream from touching an entry that already exists in the session because that's a guarantee that it was inherited from it. Note that it may be a temporary fix. Maybe in the future when a session gives birth to multiple streams we'll face a situation where a session may be updated to add more tracked entries after instanciating some streams. The correct long-term fix is to mark some tracked entries as shared or private (or RO/RW). That will allow the session to track more entries even after the same trackers are being used by early streams. No backport is needed, this is only caused by the session/stream split in 1.6.		2015-09-21 17:48:24 +02:00
..
common	MEDIUM: tools: make str2sa_range() optionally return the FQDN	2015-09-08 15:50:19 +02:00
import	MAJOR: tproxy: remove support for cttproxy	2015-08-20 19:35:14 +02:00
proto	BUG/MEDIUM: stick-tables: fix double-decrement of tracked entries	2015-09-21 17:48:24 +02:00
types	MINOR: global: Added new fields for 51Degrees device detection	2015-09-21 12:10:41 +02:00