ea17de01ac
This poor/inefficient code has been revealed by coverity GH issue in #2788 where some quic_cc_rs struct member initializations were mentionned as overwritten (after initialization) before being used as follows: CID 1565821: Code maintainability issues (UNUSED_VALUE) /src/quic_cc_bbr.c: 1373 in bbr_handle_lost_packet() 1367 } 1368 1369 static void bbr_handle_lost_packet(struct bbr *bbr, struct quic_cc_path *p, 1370 struct quic_tx_packet *pkt, 1371 uint32_t lost) 1372 { >>> CID 1565821: Code maintainability issues (UNUSED_VALUE) >>> Assigning value "0UL" to "rs.tx_in_flight" here, but that stored value is overwritten before it can be used. 1373 struct quic_cc_rs rs = {0}; 1374 1375 /* C.delivered = bbr->drs.delivered */ 1376 bbr_note_loss(bbr, bbr->drs.delivered); 1377 if (!bbr->bw_probe_samples) 1378 return; /* not a packet sent while probing bandwidth */ Remove the {0} initializer for <rs> variable. This is safe because the members initializations of <rs> local variable passed to functions from bbr_handle_lost_packet() are done. Add a comment to mention this. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| BSDmakefile | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README.md | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
HAProxy
HAProxy is a free, very fast and reliable reverse-proxy offering high availability, load balancing, and proxying for TCP and HTTP-based applications.
Installation
The INSTALL file describes how to build HAProxy. A list of packages is also available on the wiki.
Getting help
The discourse and the mailing-list are available for questions or configuration assistance. You can also use the slack or IRC channel. Please don't use the issue tracker for these.
The issue tracker is only for bug reports or feature requests.
Documentation
The HAProxy documentation has been split into a number of different files for ease of use. It is available in text format as well as HTML. The wiki is also meant to replace the old architecture guide.
Please refer to the following files depending on what you're looking for:
- INSTALL for instructions on how to build and install HAProxy
- BRANCHES to understand the project's life cycle and what version to use
- LICENSE for the project's license
- CONTRIBUTING for the process to follow to submit contributions
The more detailed documentation is located into the doc/ directory:
- doc/intro.txt for a quick introduction on HAProxy
- doc/configuration.txt for the configuration's reference manual
- doc/lua.txt for the Lua's reference manual
- doc/SPOE.txt for how to use the SPOE engine
- doc/network-namespaces.txt for how to use network namespaces under Linux
- doc/management.txt for the management guide
- doc/regression-testing.txt for how to use the regression testing suite
- doc/peers.txt for the peers protocol reference
- doc/coding-style.txt for how to adopt HAProxy's coding style
- doc/internals for developer-specific documentation (not all up to date)
License
HAProxy is licensed under GPL 2 or any later version, the headers under LGPL 2.1. See the LICENSE file for a more detailed explanation.