Commit graph

3737 commits

Author SHA1 Message Date
Matthieu MOREL
5b6c6bbfc7 fix: enable nolinlint linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-25 07:50:29 +01:00
Terry Howe
d275b925c4
Merge pull request #31852 from rohansood10/fix/31846-import-comment
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: correct import comment in statuswait.go from v3 to v4
2026-02-24 17:58:00 -07:00
George Jenkins
be7cdb69e5
Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a
fix(pkg): errorlint linter
2026-02-24 16:00:34 -08:00
George Jenkins
3dfc4f3cf6
Merge pull request #31858 from helm/gjenkins/go_fix
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
chore: `go fix` fixes
2026-02-24 15:35:00 -08:00
George Jenkins
3ad9ccdb19
Merge pull request #31563 from Mujib-Ahasan/dry-run-fix
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: --dry-run=server now respect generateName
2026-02-23 20:28:50 -08:00
George Jenkins
b667317422
fixup strings.Cut variables
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-02-23 19:17:02 -08:00
George Jenkins
92b64e87ad
chore: fixes
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-02-23 16:46:35 -08:00
rohansood10
c59c140ce0 fix: correct import comment in statuswait.go from v3 to v4
The import comment in pkg/kube/statuswait.go still referenced
helm.sh/helm/v3/pkg/kube while all other files in the package
correctly reference helm.sh/helm/v4/pkg/kube. This mismatch
causes downstream processing errors (e.g. kythe) when vendoring
Helm.

Fixes #31846

Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
2026-02-21 09:32:44 -08:00
Evans Mungai
ee018608f6
fix: handle OCI digest algorithm prefix in chart downloader (#31601)
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
* fix: strip digest algorithm prefix before hex decoding

OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString().

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Add cmd test for OCI references with tag+digest

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Move oci registry push result to a struct

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Review comments from PR review

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Fix failing test

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

---------

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-02-20 16:58:32 +00:00
Terry Howe
b26ec6b09e
Merge pull request #31566 from TerryHowe/fix-test-concurrency-download-index
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: test concurrency download index
2026-02-19 11:06:41 -07:00
Matt Farina
794372e317
Merge pull request #31816 from mmorel-35/errorlint-pkg-7-6d6a660
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
govulncheck / govulncheck (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(pkg): errorlint linter
2026-02-18 21:46:10 +01:00
Evans Mungai
4a91f3ad5c
feat(release): add internal/release/v2 package for chart v3 support (#31709)
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Introduce release/v2 that mirrors pkg/release/v1 but uses *v3.Chart
from internal/chart/v3. The code is structurally identical to v1 with
only import paths changed to reference internal/chart/v3 instead of
pkg/chart/v2.

- Add internal/release/v2 with Release, Info, Hook types
- Add internal/release/v2/util with filter, sorter, manifest utilities
- Update pkg/release/common.go with v2Accessor and v2HookAccessor
- Copy all test files from pkg/release/v1 and add a v2 test in common_test.go

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-02-13 19:10:56 +00:00
Terry Howe
b6fbb68c2b
Merge pull request #31776 from t0rr3sp3dr0/pedrotorres/fix-oci-index-pull
fix regression when pulling charts from OCI indices
2026-02-13 11:15:44 -07:00
Joe Julian
947b429cdd
Merge pull request #31801 from mmorel-35/modernize-pkg-4-062b248
chore(pkg): fix modernize linter
2026-02-10 21:42:25 -08:00
Joe Julian
78f5af72be
Merge pull request #31802 from mmorel-35/modernize-pkg-5-a3c8fdb
chore(pkg): fix modernize linter
2026-02-10 21:41:08 -08:00
Joe Julian
70899a6b3f
Merge pull request #31578 from manute/main
fix(action): crd resources can be empty
2026-02-10 21:39:38 -08:00
Joe Julian
14e0b8f970
Merge pull request #31128 from orgads/win-parallel
fix(downloader): prevent concurrent file access errors on Windows
2026-02-10 21:38:34 -08:00
Joe Julian
56d0d9374a
Merge pull request #31810 from mmorel-35/errorlint-pkg-5-dda0145
fix(pkg): errorlint linter
2026-02-10 06:26:03 -08:00
Joe Julian
7f9703fe22
Merge pull request #31811 from mmorel-35/errorlint-pkg-3-39f7a9f
fix(pkg): errorlint linter
2026-02-10 06:24:45 -08:00
Matthieu MOREL
259f76a849 fix(pkg): errorlint linter
errorlint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:54:59 +01:00
Matthieu MOREL
6d1490ed1e fix(pkg): errorlint linter
#### Description

errorlint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:41 +01:00
Matthieu MOREL
4d0ae7f33a fix(pkg): errorlint linter
#### Description

errorlint linter in pkg

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:34 +01:00
Matthieu MOREL
4330bdea04 fix(pkg): errorlint linter
#### Description

errorlint linter in pkg

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:25 +01:00
Matthieu MOREL
c8989d984f fix(pkg): errorlint linter
#### Description

errorlint linter in pkg

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:21 +01:00
Orgad Shaneh
76eb37c01a fix(downloader): safely handle concurrent file writes on Windows
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.

This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.

Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.

Fixes #31633

Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
2026-02-07 19:26:59 +02:00
Terry Howe
1468449ff5
Merge pull request #31794 from mmorel-35/modernize-pkg-1-f9be97c
chore(pkg): fix modernize linter
2026-02-07 06:45:00 -07:00
Manuel Alonso
9817a68618
fix(install): check nil for restClientGetter and fix tests
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
2026-02-07 11:29:08 +01:00
Evans Mungai
5aac32077f
feat(create): add --chart-api-version flag (when HELM_EXPERIMENTAL_CHART_V3 env var is set) (#31592)
* feat(create): add hidden --chart-api-version flag

Add --chart-api-version flag to helm create command to allow selecting
chart API version (v2 or v3) when creating a new chart.

- Default is v2 (existing behavior unchanged)
- v3 uses internal/chart/v3 scaffold generator
- Invalid versions return clear error message
- Works with --starter flag

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Add HELM_EXPERIMENTAL_CHART_V3 feature gate to create command

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* make chartv3 private and use loader to load the chart

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Hide chart-api-version flag until chart v3 is officially released

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Conditionally hide the --chart-api-version flag if chart v3 is not enabled

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Add internal gates package for internal feature gates

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Add doc for internal/gates package

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

---------

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-02-06 18:29:59 +00:00
Matthieu MOREL
5cc2e55714 chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/chart/v2/lint/rules

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:11:01 +01:00
Matthieu MOREL
ba38159313 chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/strvals

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:10:54 +01:00
Matthieu MOREL
111d4e6e0e chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/chart/common/util

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:10:41 +01:00
Evans Mungai
5b78ee8dff
Merge pull request #31644 from banjoh/em/fix-nil-values
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(values): preserve nil values when chart default is empty map
2026-01-31 13:03:55 +00:00
Pedro Tôrres
e8f386b5aa
add image index test
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
2026-01-29 19:47:37 -08:00
Pedro Tôrres
d983696e35
fix pulling charts from OCI indices
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
2026-01-29 17:30:14 -08:00
Matheus Pimenta
787b61cedb
Revert "Consider GroupVersionKind when matching resources"
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-29 06:04:56 +00:00
Scott Rigby
f928025cdb
Merge pull request #31717 from AustinAbro321/use-logger-with-waiter
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix: use kube logger with status waiter
2026-01-22 19:18:14 -05:00
Evans Mungai
9211dfef6a
Merge pull request #31743 from banjoh/em/document-uninstall-using-cascade
docs: document uninstall using cascade foreground flag
2026-01-22 21:37:51 +00:00
Austin Abro
ec0726523e
whitespace
Signed-off-by: Austin Abro <austinabro321@gmail.com>
2026-01-22 15:45:29 -05:00
Austin Abro
63b40a7a5e
use logger with waiter
Signed-off-by: Austin Abro <austinabro321@gmail.com>
2026-01-22 09:12:53 -05:00
Matheus Pimenta
b0b35f1231
feat(kstatus): fine-grained context options for waiting
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-21 19:03:20 +00:00
Evans Mungai
e70d59de7c
docs: document uninstall using cascade foreground flag
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-19 16:42:04 +00:00
Matheus Pimenta
bbec77c1f7
bugfix(kstatus): do not wait forever on failed resources
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-17 12:18:16 +00:00
George Jenkins
50546ef665
Merge pull request #31723 from matheuscscp/fix-storage-logger
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
bugfix(logging): fix storage not getting logger from driver
2026-01-16 19:12:22 -08:00
Matheus Pimenta
c1cc625323
chore(defaults): server-side apply SDK defaults should always match the CLI defaults
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-15 10:04:07 +00:00
Evans Mungai
828038a8fe
chore: clarify --wait flag help text
Improve the description to explain the three usage scenarios:
- --wait alone defaults to 'watcher' strategy
- --wait=<value> uses the specified strategy
- flag omitted defaults to 'hookOnly'

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-14 12:15:00 +00:00
Manuel Alonso
7c089bed26
Merge branch 'main' into main
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
2026-01-14 08:13:40 +01:00
Manuel Alonso
6501ef490a
chore(refactor): better testing and functionality for installing crd
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
2026-01-13 19:21:16 +01:00
Matheus Pimenta
a8eb527847
bugfix(storage): fix storage not getting logger from driver
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-13 15:46:01 +00:00
Evans Mungai
40a9de1086
Merge pull request #31412 from fmuyassarov/devel/rollback
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Fix rollback for missing resources
2026-01-13 11:07:24 +00:00
Evans Mungai
f46f1ce55d
Update pkg/kube/statuswait.go
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-12 18:32:31 +00:00