Commit graph

38 commits

Author SHA1 Message Date
wawa0210
637a5c6494 Environment variable for setting the max history for an environment
Signed-off-by: wawa0210 <xiaozhang0210@hotmail.com>
2020-07-08 23:02:40 +08:00
Matt Farina
f90b842d3e
Merge branch 'master' into xdg 2020-05-05 10:07:10 -04:00
Matt Farina
2334195a01
Adding Helm env vars where XDG exposed
Helm had been exposing XDG based variables to end users. This lead
to confusion. For example, if a user wanted to change the cache
location Helm used should they change the XDG variable? Since this
would be like changing the HOME environment variable the answer
is no.

This change adds HELM_*_HOME environment variables to be used
in addition to XDG ones of the same name. Helm will now look
for the Helm specific variable. If not set, Helm will fall
back to XDG locations. If those are not set a default location
will be used. This keeps XDG in use as a default when present,
provides users with the ability to set the location, and removes
XDG from being exposed to end users to avoid confusion.

Closes #7919

Signed-off-by: Matt Farina <matt@mattfarina.com>
2020-04-28 11:28:56 -04:00
Adam Reese
4a0dfbe53b
fix(pkg/cli): ensure correct configuration from kubeconfig file
Bind Helm flags to Kubernetes configuration loader to get a merged
config with kubeconfig.

Fixes: #7539

Signed-off-by: Adam Reese <adam@reese.io>
2020-04-23 12:20:14 -07:00
Matthew Fisher
14f6d1ea97
ref(environment): use string checking instead
It is more idiomatic to compare the string against the empty string than to check the string's length.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2020-03-02 12:09:41 -08:00
Vibhav Bobade
4bd3b8fc06 Pass the apiserver address/port via cli, introduce HELM_KUBEAPISERVER envvar
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
2020-02-20 04:18:10 +05:30
Vibhav Bobade
afdfb75234 Pass kube user token via cli, introduce HELM_KUBETOKEN envvar
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
2020-02-13 03:44:49 +05:30
Josh Soref
02ad2b1187 Spelling (#7258)
* spelling: constraint

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cryptographic

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dependency

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: doesnot

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: don't

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unexpected

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dreadnought

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: default

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: envvars

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: evaluates

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: execute

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extractor

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: frobnitz

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: generated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: implementation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: jabba

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: keywords

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: kubernetes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: override

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: package

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parsable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: progress

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: recursively

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: release

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cache

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: representing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: serializer

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: subchart

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: utilities

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2019-12-18 12:04:08 +00:00
Aaron Mell
6a98d1f1d2 Code Review Changes
Signed-off-by: Aaron Mell <amell@lumindigital.com>
2019-10-14 13:14:14 -05:00
Aaron Mell
4eca26e4e1 Modified the scope of Kubeconfig so it could be set outside an env variable.
Signed-off-by: Aaron Mell <amell@lumindigital.com>
2019-10-14 13:14:14 -05:00
Jonas Rutishauser
0650d6953d
Remove all known arguments in plugin invocations
Consistenly remove all arguments which are passed as environment
variables.

Get all arguments from environment variables passed to plugins.

Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
2019-10-12 21:50:42 +02:00
Taylor Thomas
1123e5ca1f fix(cli): Fixes incorrect variable reference
Because these were additions, git didn't pick up that the recent refactor of
env settings had changed some of the variables. This fixes those small changes

Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
2019-10-11 10:21:49 -06:00
Matthew Fisher
ed90425ebb
Merge pull request #6632 from mumoshu/add-plugin-envvars
v3: Propagate --kube-context, --kubeconfig and --namespace values to plugins
2019-10-11 09:05:43 -07:00
Taylor Thomas
38d4f33a0f
Merge pull request #6641 from VilledeMontreal/feat/refactorOutput
ref(cmd): Use method to list formats
2019-10-11 09:59:07 -06:00
Yusuke Kuoka
69adc5a218 v3: Propagate --kube-context, --kubeconfig and --namespace values to plugins
Closes #6631

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
2019-10-11 21:06:17 +09:00
Marc Khouzam
483904656b ref(cmd): Use string method to list formats
This greatly simplifies how to obtain the list of output.Format.
It no longer provides a way to list all output.Format, but focuses
on providing a list of string representation of output.Format, as this
is what is actually needed.

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
2019-10-10 22:39:18 -04:00
Marc Khouzam
7fd384c8fb ref(cmd): Use method to list formats
This isolates the listing of the different formats to the output.go
file.  It is more future-proof if another format is added.

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
2019-10-10 21:38:38 -04:00
Aaron Mell
8b8ffcdb21 Moved config and configOnce to struct
Signed-off-by: Aaron Mell <amell@lumindigital.com>
2019-10-10 16:51:59 -05:00
Aaron Mell
00249a3235 Moved namespace and kubeconfig variable back to original place.
Signed-off-by: Aaron Mell <amell@lumindigital.com>
2019-10-10 14:01:28 -05:00
Aaron Mell
1d66a676c8 Moved the GetNamespace and KubeConfig function from action to cli
Signed-off-by: Aaron Mell <amell@lumindigital.com>
2019-10-10 13:35:46 -05:00
Taylor Thomas
768d27b387 ref(*): Refactors output into its own package
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
2019-10-07 10:09:28 -06:00
Matt Farina
9bc7934f35
Updating the module for v3 as the major version
Signed-off-by: Matt Farina <matt@mattfarina.com>
2019-10-03 14:27:05 -04:00
Adam Reese
d3805a1d54
ref(pkg/cli): refactor environment variable setup
This change sets proper defaults based on environment variables for
global settings and plugin environments.

Signed-off-by: Adam Reese <adam@reese.io>
2019-09-25 14:00:43 -07:00
Taylor Thomas
7599c5d489 feat(*): Ports --set-file flag to v3
I made a few modifications from the original code to fit in with the new
code layout and to clarify a few things. This is a port of #3758

Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
2019-09-24 12:43:43 -06:00
Adam Reese
b4788481b7
fix(pkg/cli): do not override users xdg directories
Signed-off-by: Adam Reese <adam@reese.io>
2019-09-05 10:43:36 -07:00
Matt Farina
1ea53d8934
Unifity environment variable naming and use
Signed-off-by: Matt Farina <matt@mattfarina.com>
2019-09-04 14:15:30 -04:00
Matt Farina
378b9dd29e
Remove ability to have duplicates in environment variables
Signed-off-by: Matt Farina <matt@mattfarina.com>
2019-09-04 13:48:30 -04:00
Matt Farina
ec31f13ee9
Merge pull request #6244 from waveywaves/feature/helmenv
(feature/helm-env) `helm env`
2019-09-04 13:38:12 -04:00
Ivan Towlson
cd42b26a6a Distinct doc strings for repository-cache and repository-config
Signed-off-by: Ivan Towlson <itowlson@microsoft.com>
2019-09-02 09:19:29 +12:00
Vibhav Bobade
66b037f6be Move the logic for checking env in pkg/cli and store all envs in a central place
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
2019-08-30 23:09:50 +05:30
Adam Reese
1779ad5302
ref(cmd/helm): remove init command
Signed-off-by: Adam Reese <adam@reese.io>
2019-08-26 10:21:52 -07:00
Adam Reese
b6fdd8783b
feat(cmd/helm): remove need for helm init command
* allow repository config via cli
* make `helm repo add` create repo config file if it does not exist
* squash a ton of bugs

Signed-off-by: Adam Reese <adam@reese.io>
2019-08-22 23:31:50 -07:00
Adam Reese
2aee21730d
Merge pull request #6142 from joelanford/decouple-cli-vals
cmd/*,pkg/*: move ValueOptions and decouple from SDK
2019-08-06 09:53:24 -07:00
Joe Lanford
45f697b507 pkg/cli/values/options_test.go: re-add MergeValues test with mergeMaps
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
2019-08-05 23:33:39 -04:00
Matthew Fisher
c728611e5a
feat(cli): support XDG base directory specification
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-08-02 13:15:03 -07:00
Joe Lanford
8a4b70b1e3 review: move ValueOptions to SDK
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
2019-08-01 20:00:47 -04:00
Adam Reese
895e9192d4
feat(*): use vanity import helm.sh/helm
Signed-off-by: Adam Reese <adam@reese.io>
2019-03-13 13:43:47 -07:00
Matthew Fisher
2571dbf82f
ref: remove pkg/helm, pkg/hapi, pkg/tiller
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-03-12 09:47:12 -07:00