Commit graph

2810 commits

Author SHA1 Message Date
Benoit Tigeot
cda0865d64
Update pkg/plugin/plugin.go
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
2025-05-21 09:45:40 +02:00
Benoit Tigeot
5d9d9a0fb8
Wait for Helm v4 before raising when platformCommand and Command are set
same for `PlatformHooks` and `hooks`.

When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.

See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270

Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-20 23:11:47 +02:00
Feng Cao
afefca8b2d chore: update generalization warning message
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
2025-05-16 15:50:18 +09:30
Feng Cao
eb5b6d5047 fix: move warning to top of block
Emit the warning first to ensure it's always logged. This clarifies that any following errors are due to using a local chart instead of a remote repository.

Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
2025-05-13 17:51:49 +09:30
Feng Cao
6b5c94475d fix: replace fmt warning with slog
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
2025-05-11 02:46:50 +09:30
Feng Cao
247bf7c2e0 fix: add warning when ignore repo flag
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
2025-05-11 01:48:39 +09:30
George Jenkins
b4e06a11d2
Merge pull request #30658 from helm/gjenkins/backport_12912
[v3 backport] feat: add httproute from gateway-api to create chart template
2025-05-06 20:51:07 -07:00
George Jenkins
a69eaf6098
Merge pull request #30764 from nvanthao/backport-30673
v3 backport: Process all hook deletions on failure
2025-05-06 10:57:16 -07:00
Robert Sirchia
94044595c7
bump version to v3.18.0
(cherry picked from commit 74c3d1dc0de0335f941362c80447871e7d6bc78e)
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-05-05 16:09:20 -04:00
Terry Howe
cdd7c105a6 docs: Note about http fallback for OCI registries
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-04-26 10:00:30 -06:00
Scott Rigby
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership
v3 backport - fix --take-ownership
2025-04-21 10:45:45 -04:00
Benoit Tigeot
087fa18276
Bump toml
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0). I think it's safe to change the test here.

For main: https://github.com/helm/helm/pull/30775

Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-04-19 09:06:19 +02:00
Evans Mungai
0906fe7f6b
Add install test for TakeOwnership flag
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-04-17 18:19:27 +01:00
Patrick Seidensal
4ee3a19e9a
Fix --take-ownership
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.

This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.

By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.

Fixes #30622

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2025-04-17 17:55:06 +01:00
Gerard Nguyen
0a800e84b0 backport #30673 to dev-v3
Signed-off-by: Gerard Nguyen <gerard@replicated.com>
2025-04-17 10:11:10 +10:00
Matt Farina
3ce10e4f81
Unarchiving fix
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2)
2025-04-09 09:23:13 -04:00
Benoit Tigeot
422c58e4a2
Fix typo
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-03-20 21:44:13 +01:00
Benoit Tigeot
5e7f12d4c3
Report as debug log, the time spent waiting for resources
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-03-19 23:09:25 +01:00
Terry Howe
1435ec7c77 Update pkg/registry/fallback.go
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-03-14 08:46:25 -06:00
Terry Howe
674e882c88 automatic fallback to http
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-03-14 08:46:25 -06:00
Terry Howe
c188441757 chore(oci): upgrade to ORAS v2
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-03-14 08:46:18 -06:00
Henrik Gerdes
bd1b67b082 feat: add httproute from gateway-api to create chart template
Adds the HTTPRoute from https://gateway-api.sigs.k8s.io/reference/spec/ to the example getting started chart.

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
2025-03-12 10:27:53 -07:00
Scott Rigby
bcb83e465f
Fix cherry-pick helm.sh/helm/v4 -> helm.sh/helm/v3
Signed-off-by: Scott Rigby <scott@r6by.com>
2025-02-21 19:19:39 -05:00
Chris Berry
2aa90b8f26
Refactor based on review comment
Signed-off-by: Chris Berry <bez625@gmail.com>
2025-02-21 19:00:41 -05:00
Chris Berry
5739197faa
Refactor based on review comment
Signed-off-by: Chris Berry <bez625@gmail.com>
2025-02-21 19:00:41 -05:00
Chris Berry
b8e13878fc
Add HookOutputFunc and generic yaml unmarshaller
Signed-off-by: Chris Berry <bez625@gmail.com>
2025-02-21 19:00:41 -05:00
Scott Rigby
97b0e11871
clarify fix error message
Signed-off-by: Scott Rigby <scott@r6by.com>
2025-02-21 19:00:41 -05:00
Scott Rigby
2f79afb0a3
fix err check
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
2025-02-21 19:00:40 -05:00
Scott Rigby
c77f4ec6c4
remove comments about previous functionality
Signed-off-by: Scott Rigby <scott@r6by.com>
2025-02-21 19:00:40 -05:00
Scott Rigby
3cd6afe845
add short circuit return
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
2025-02-21 19:00:40 -05:00
Chris Berry
5367001f4f
Update based on review comments
Signed-off-by: Chris Berry <bez625@gmail.com>
2025-02-21 19:00:40 -05:00
Chris Berry
3c445158d8
Update based on review comments
Signed-off-by: Chris Berry <bez625@gmail.com>
2025-02-21 19:00:39 -05:00
Chris Berry
4cb639ed4e
Fix lint
Signed-off-by: Chris Berry <bez625@gmail.com>
2025-02-21 18:55:47 -05:00
Chris
20f859c9ff
Tidy up imports
Signed-off-by: Chris <bez625@gmail.com>
2025-02-21 18:55:33 -05:00
Chris Berry
ca90972b3d
Add hook annotations to output pod logs to client on success and fail
Signed-off-by: Chris Berry <bez625@gmail.com>
2025-02-21 18:54:56 -05:00
Matt Farina
e2c7986f30
Merge pull request #13534 from althmoha/dev-v3-12987
fix (helm) : toToml` renders int as float [ backport to v3 ]
2025-02-05 15:33:56 -05:00
George Jenkins
80f87ab636
Merge pull request #13654 from ryanhockstad/subchart-null
[backport] bugfix: Override subcharts with null values
2025-01-26 21:18:13 -08:00
Matt Farina
9aff8bdaa0
Merge pull request #13644 from mattfarina/backport-13583
fix: check group for resource info match (v3 backport)
2025-01-22 14:58:30 +01:00
George Jenkins
6ed9d2f2d5
Merge pull request #13592 from stevehipwell/add-plugin-platform-hooks-v3
feat: Add multi-platform plugin hook support [v3 backport]
2025-01-18 08:18:47 -08:00
Jiasheng Zhu
2ebce786ba
fix: check group for resource info match
Closes: #13582

Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>
(cherry picked from commit f5d488122b)
2025-01-17 15:33:33 -05:00
Ryan Hockstad
326c1e3f67 add test for nullifying nested global value
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
2025-01-17 07:29:48 -05:00
Matt Farina
fba9d08dce
Ensuring the file paths are clean prior to passing to securejoin
securejoin v0.4.0 made a possibly breaking change. Only clean paths
are safe to pass to SecureJoin or they could return an error or
have the wrong path. The details are in the release notes for v0.4.0.

This change ensures the paths are clean prior to passing to SecureJoin.

Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 35a9ead998)
2025-01-14 15:35:47 -05:00
Matt Farina
d6db69ed66
bump version to v3.17.0
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 301108edc7)
2025-01-06 14:20:59 -05:00
Ryan Hockstad
ef2eb55283 Add test case for removing an entire object
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
2025-01-02 22:19:19 -05:00
Scott Rigby
60fcce18d1 Tests for bugfix: Override subcharts with null values #12879
- Add consistency for null test in given values, parent chart, subchart, and
  sub-sub-chart
- Remove bar null test to keep consistent with boat=null at top level

Signed-off-by: Scott Rigby <scott@r6by.com>
2025-01-02 21:17:30 -05:00
Andrew Block
83dddb1839
feat: Added multi-platform plugin hook support to v3
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
2025-01-02 12:45:36 +00:00
Terry Howe
949b2e6040 fix: make ORAS reference private
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit d2b94f6200)
2025-01-01 11:50:58 -05:00
Terry Howe
aba95b9cb4 fix: issue with helm template and oci chart
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit aca7e8d775)
2025-01-01 11:50:43 -05:00
Terry Howe
c3e5217d85 feat: allow installation by OCI digest
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit ad9fb68fa3)
2025-01-01 11:50:26 -05:00
Matt Farina
9ade3b502a
Merge pull request #13574 from gjenkins8/v3_13343
Add annotations and dependencies to get metadata output [v3 backport]
2024-12-30 15:06:08 +01:00