Orgad Shaneh
df8757a6c8
Merge 3575c04de7 into 5b78ee8dff
2026-02-01 12:06:04 -05:00
Evans Mungai
5b78ee8dff
Merge pull request #31644 from banjoh/em/fix-nil-values
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(values): preserve nil values when chart default is empty map
2026-01-31 13:03:55 +00:00
Matheus Pimenta
787b61cedb
Revert "Consider GroupVersionKind when matching resources"
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-29 06:04:56 +00:00
Orgad Shaneh
3575c04de7
fix(downloader): prevent concurrent file access errors on Windows
...
When DownloadTo runs in parallel for the same ref and version, both
processes try to write the same target file, causing "Access Denied"
errors on Windows.
This change refactors the file locking mechanism based on maintainer
feedback:
- Add LockedAtomicWriteFile to internal/fileutil package to encapsulate
locking logic
- Use the new function for both chart and provenance files
- Lock is cross-process safe and automatically released on process exit
- Files are only written if they don't already exist (avoiding
duplicate work)
The TestParallelDownloadTo test verifies the fix works correctly.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
2026-01-25 11:42:19 +02:00
Scott Rigby
f928025cdb
Merge pull request #31717 from AustinAbro321/use-logger-with-waiter
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix: use kube logger with status waiter
2026-01-22 19:18:14 -05:00
Evans Mungai
9211dfef6a
Merge pull request #31743 from banjoh/em/document-uninstall-using-cascade
...
docs: document uninstall using cascade foreground flag
2026-01-22 21:37:51 +00:00
Austin Abro
ec0726523e
whitespace
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
2026-01-22 15:45:29 -05:00
Austin Abro
63b40a7a5e
use logger with waiter
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
2026-01-22 09:12:53 -05:00
Matheus Pimenta
b0b35f1231
feat(kstatus): fine-grained context options for waiting
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-21 19:03:20 +00:00
Evans Mungai
e70d59de7c
docs: document uninstall using cascade foreground flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-19 16:42:04 +00:00
Matheus Pimenta
bbec77c1f7
bugfix(kstatus): do not wait forever on failed resources
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-17 12:18:16 +00:00
George Jenkins
50546ef665
Merge pull request #31723 from matheuscscp/fix-storage-logger
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
bugfix(logging): fix storage not getting logger from driver
2026-01-16 19:12:22 -08:00
Matheus Pimenta
c1cc625323
chore(defaults): server-side apply SDK defaults should always match the CLI defaults
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-15 10:04:07 +00:00
Evans Mungai
828038a8fe
chore: clarify --wait flag help text
...
Improve the description to explain the three usage scenarios:
- --wait alone defaults to 'watcher' strategy
- --wait=<value> uses the specified strategy
- flag omitted defaults to 'hookOnly'
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-14 12:15:00 +00:00
Matheus Pimenta
a8eb527847
bugfix(storage): fix storage not getting logger from driver
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-13 15:46:01 +00:00
Evans Mungai
40a9de1086
Merge pull request #31412 from fmuyassarov/devel/rollback
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Fix rollback for missing resources
2026-01-13 11:07:24 +00:00
Evans Mungai
f46f1ce55d
Update pkg/kube/statuswait.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-12 18:32:31 +00:00
Matheus Pimenta
59ece92bed
pkg/kube: introduce support for custom kstatus readers
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-12 18:16:26 +00:00
Evans Mungai
e751a70e84
fix(release): fix test compilation error
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-09 19:32:29 +00:00
Evans Mungai
2e2cb05855
Merge pull request #31427 from tisonkun/resolve-todo
...
Check plugin name is not used
2026-01-09 18:55:44 +00:00
Evans Mungai
05f25a3834
Merge pull request #31579 from benoittgt/delete-hook-after-log-retrieval
...
fix: Delay test hook deletion until after logs are retrieved with `helm test release --logs`
2026-01-09 15:02:37 +00:00
Terry Howe
429ce93848
Merge pull request #31613 from aslafy-z/feat/getter-env
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
govulncheck / govulncheck (push) Has been cancelled
fix(getter): pass settings environment variables
2026-01-07 07:41:31 -07:00
Evans Mungai
0298b2ffd0
Remove refactorring changes from coalesce_test.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-07 13:16:11 +00:00
Evans Mungai
b8937ad192
Fix import
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-07 12:58:21 +00:00
Evans Mungai
a333bbaf27
Update pkg/chart/common/util/coalesce_test.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-07 12:51:47 +00:00
Feruzjon Muyassarov
374aeb4b4e
Fix rollback for missing resources
...
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
2026-01-05 18:34:33 +02:00
Terry Howe
08f17fc947
Merge pull request #31683 from majiayu000/fix-13198---api-versions-is-undocumented-1230-2329
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix: `--api-versions` is undocumented
2026-01-04 10:08:17 -07:00
George Jenkins
fa41d60d73
Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Add tests to action package to improve coverage
2026-01-02 20:24:27 -08:00
Mads Jensen
2d6d9c09c4
Replace reflect.Ptr with reflect.Pointer
...
The reflect package has a go:fix annotation for Ptr = Pointer.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-31 10:05:43 +01:00
majiayu000
c7cc77b68d
Add documentation for --api-versions flag in template command
...
The --api-versions flag was undocumented in the template command's
help text. This adds usage documentation and examples showing both
comma-separated and multiple flag usage patterns.
Fixes #13198
Signed-off-by: majiayu000 <1835304752@qq.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: majiayu000 <1835304752@qq.com>
2025-12-30 23:41:29 +08:00
Matt Farina
fe1c749183
Fixing failing tests for cli-tools update
...
Tests were failing for cli-utils watcher because upstream k8s made
changes that impacted cli-utils. In k8s WatchListClient is now
enabled by default. Fake clients used for testing don't know this
semantic. cli-utils leverages reflection in k8s to handle this.
The Helm tests didn't handle this well.
The tests are updated to use PrependReactor and PrependWatchReactor
in the same way that cli-utils does for testing. This works without
wrapping the client.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-12-27 10:25:08 -05:00
George Jenkins
118d90e810
Merge pull request #31677 from gjenkins8/gjenkins/new_client_set
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
chore: Replace deprecated `NewSimpleClientset`
2025-12-26 19:21:06 -08:00
George Jenkins
a15db7f087
Replace deprecated NewSimpleClientset
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-12-26 08:36:42 -08:00
Terry Howe
8802d959cb
Merge pull request #31104 from LinPr/fix
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
2025-12-25 04:52:18 -07:00
George Jenkins
f05c21b6b6
Merge pull request #31296 from gjenkins8/gjenkins/runtime_kube_version
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
build: set kube version via `debug.BuildInfo`
2025-12-22 19:15:22 -08:00
George Jenkins
24e8297343
Merge pull request #31610 from mohsenmottaghi/fix-helm-4-watch-strategy
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: use namespace-scoped watching to avoid cluster-wide LIST permiss…
2025-12-22 12:41:17 -08:00
Brenden Ehlers
1c119bcaa6
fix: add default casess to switch statements
...
Signed-off-by: Brenden Ehlers <brenden@theehlers.org>
2025-12-21 09:13:24 -07:00
Branch Vincent
c6d9a5bdc2
build: set kube version via debug.BuildInfo
...
Signed-off-by: Branch Vincent <branchevincent@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-12-19 21:13:47 -08:00
Matt Farina
2108bc5070
Merge pull request #31448 from laervn/feat/add-no-headers-option
...
feat(repo): add --no-headers option to 'helm repo list'
2025-12-17 15:33:36 -05:00
Deepak Chethan
55a4aed67f
doc: update based on review suggestion
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
2025-12-17 14:41:37 +05:30
Mohsen Mottaghi
d6b35cedeb
test(statuswait): fix Copilot code review suggestion for goroutine in tests
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
2025-12-16 17:43:15 +03:30
Mohsen Mottaghi
a1543d5947
test(statuswait): add more tests suggested by Copilot code review
...
add missing coverage for the positive case where cluster-scoped resources (like ClusterRole or Namespace) should work correctly
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
2025-12-16 17:33:29 +03:30
Mohsen Mottaghi
dd44f4ecd0
test(statuswait): add some tests for statuswait
...
Adding some tests for multi namespace deployment, simulate restrcited rbac access and mixed namespace scope and cluster scope resources
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
2025-12-16 13:55:07 +03:30
Mohsen Mottaghi
3dd54ed0b6
fix: use namespace-scoped watching to avoid cluster-wide LIST permissions
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
2025-12-16 13:55:02 +03:30
Deepak
f92ae18977
fix(doc): Update default wait strategy
...
fixes : #31652
Default wait strategy is hookOnly, so updated the docs to reflect the same
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
2025-12-16 11:41:04 +05:30
Terry Howe
019e7e7145
Merge pull request #31650 from helm/gjenkins/fix_TestConcurrencyDownloadIndex
...
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Fix `TestConcurrencyDownloadIndex` typo
2025-12-15 05:28:19 -07:00
tison
9772037ed8
Update to use slog
...
Signed-off-by: tison <wander4096@gmail.com>
2025-12-15 13:37:55 +08:00
tison
3c6557dcf5
Fix TestCliPluginExitCode
...
Signed-off-by: tison <wander4096@gmail.com>
2025-12-15 13:36:26 +08:00
tison
5196b8431a
Check plugin name is not used
...
Signed-off-by: tison <wander4096@gmail.com>
2025-12-15 13:36:26 +08:00
George Jenkins
592815ea2b
Fix TestConcurrencyDownloadIndex typo
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-12-14 20:42:29 -08:00