Commit graph

786 commits

Author SHA1 Message Date
Matheus Pimenta
c1cc625323
chore(defaults): server-side apply SDK defaults should always match the CLI defaults
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-15 10:04:07 +00:00
Matheus Pimenta
59ece92bed
pkg/kube: introduce support for custom kstatus readers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-01-12 18:16:26 +00:00
Evans Mungai
e751a70e84
fix(release): fix test compilation error
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-09 19:32:29 +00:00
Evans Mungai
05f25a3834
Merge pull request #31579 from benoittgt/delete-hook-after-log-retrieval
fix: Delay test hook deletion until after logs are retrieved with `helm test release --logs`
2026-01-09 15:02:37 +00:00
George Jenkins
fa41d60d73
Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Add tests to action package to improve coverage
2026-01-02 20:24:27 -08:00
Terry Howe
5d2ab10caa
Merge pull request #12564 from hiddeco/supersede-on-uninstall
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix(uninstall): supersede deployed releases
2025-12-13 09:15:54 -07:00
Terry Howe
2597088a20
Merge pull request #31586 from calvinbui/main
fix: use length check for MetaDependencies instead of nil comparison
2025-12-13 08:20:08 -07:00
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
chore: fix some comments to improve readability
2025-12-12 19:34:20 +01:00
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
govulncheck / govulncheck (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Enable the `sloglint` linter
2025-12-12 08:04:45 -07:00
wangjingcun
858cf31583 chore: fix some comments to improve readability
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2025-12-12 12:01:35 +08:00
Mads Jensen
a18e59e465 Enable the sloglint linter
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-09 08:24:36 +01:00
George Jenkins
3165e5463a
Merge pull request #31528 from benoittgt/31423-git-version
fix: preserve vendor suffixes in KubeVersion.GitVersion
2025-12-08 08:35:56 -08:00
Stephanie Hohenberg
a109ac2f06 fixes comment in install.go
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
2025-12-04 17:47:54 +05:30
Stephanie Hohenberg
2f598ffc85 fixes tests after merge
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
2025-12-03 13:21:25 +05:30
Stephanie Hohenberg
bb9356e182 fixes lint issue
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
2025-12-03 13:18:00 +05:30
Stephanie Hohenberg
8cf4ad73c3 updates tests after rebase from master
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
2025-12-03 13:18:00 +05:30
Stephanie Hohenberg
31131cff9b Add tests to action package to improve coverage
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
2025-12-03 13:17:58 +05:30
George Jenkins
dfa1e3c3c5
Merge pull request #31562 from atombrella/feature/modernize
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Use modernize to use newer Golang features.
2025-11-30 06:04:31 -08:00
Benoit Tigeot
45c5f3aaca
Deal with golint warning with private executeShutdownFunc
```
  Error: pkg/action/release_testing.go:60:57: unexported-return: exported method Run returns unexported type action.executeShutdownFunc, which can be annoying to use (revive)
  func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) {

```

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-27 08:49:18 +01:00
Calvin Bui
b33d4ae0c0
Use length check for MetaDependencies instead of nil comparison
Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
2025-11-27 16:56:17 +11:00
Benoit Tigeot
70fc5f97e2
Code review
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-26 23:30:10 +01:00
Michelle Fernandez Bieber
6bb5bcc212
Update pkg/action/hooks.go
Co-authored-by: Marco Lecheler <marco@task.media>
Signed-off-by: Michelle Fernandez Bieber <37021266+mfbieber@users.noreply.github.com>
2025-11-26 17:02:48 +01:00
Michelle Fernandez Bieber
d9301441f4
added check for nil shutdown
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
2025-11-26 17:02:19 +01:00
Michelle Fernandez Bieber
7a61ebf013
cleaned up empty line
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
2025-11-26 17:01:54 +01:00
Michelle Fernandez Bieber
10714772be
updated comment and made defer of shutdown function return errors as before and not the possible shutdown error
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
2025-11-26 17:01:54 +01:00
Michelle Fernandez Bieber
7a557580e1
added shutdown hook that is executed after the logs have been retrieved
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
2025-11-26 17:01:13 +01:00
Mads Jensen
6cceead399 Use modernize to use newer Golang features.
The rangeint suggestion is faster.
The maps.Copy and slices.Contains are just syntatic sugar.

Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-11-22 18:52:40 +01:00
Matt Farina
61d289c119
Merge pull request #31518 from gjenkins8/gjenkins/fix_update_create
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix: Use server-side apply for object create during update
2025-11-21 17:13:56 -05:00
Matt Farina
698fcd2290
Merge pull request #31515 from gjenkins8/gjenkins/copy_adopted
fix: Copy adopted resource info
2025-11-21 16:29:50 -05:00
Benoit Tigeot
ce273eea48
fix: preserve vendor suffixes in KubeVersion.GitVersion
Helm 3.19.0 introduced a regression where vendor-specific suffixes
(e.g., -gke.1245000, -eks-4096722, +) are stripped from
.Capabilities.KubeVersion.GitVersion, breaking charts that detect
managed Kubernetes platforms.

The root cause was using k8sversion.ParseGeneric().String() which
intentionally discards vendor suffixes. The fix stores both the full
version (with vendor suffix) and a normalized version. String() returns
the normalized version for constraint checking (e.g., ">= 1.21.0"),
while Version/GitVersion preserve the full string for template access.

Fixes #31423
Related to #31063, #31078

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-18 15:28:16 +01:00
George Jenkins
18616e6ce9 fix: Use server-side apply for object create during update
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-11-15 20:37:30 -05:00
George Jenkins
855ebb6884 Copy adopted resource info
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-11-15 08:37:54 -05:00
promalert
d8c4040336 refactor: use strings.Builder to improve performance
Signed-off-by: promalert <promalert@outlook.com>
2025-11-11 23:32:47 +08:00
Scott Rigby
0ee89d2d4e
Merge pull request #31418 from tisonkun/typo
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
chore: fix typo of public field
2025-11-10 13:56:39 -05:00
Hidde Beydals
d158708fbf
fix(rollback): errors.Is instead of string comp
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
2025-11-07 23:09:49 +01:00
Hidde Beydals
2f1ecc7100
fix(uninstall): supersede deployed releases
This ensures that when `helm uninstall` is run with `--keep-history`
any release in a `deployed` state other than the last release (e.g.
due to a failed upgrade) is being marked as `superseded`.

As a by-effect, running `helm upgrade` on a release which has been
uninstalled after an upgrade failure now no longer works. But instead
fails with a `"<name>" has no deployed releases` error. Which is the
(likely) intended behavior, and prevents other side-effects like
rolling back to a release version which happened before the uninstall
if `--atomic` (or `--rollback-on-failure`) was provided.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
2025-11-07 23:09:48 +01:00
George Jenkins
384a3f0ff8
Merge pull request #31385 from porridge/test-unknown-policy
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
test: protect unknown hook delete policies
2025-11-05 10:35:23 -08:00
tison
90d01915f9
for all other similar cases
Signed-off-by: tison <wander4096@gmail.com>
2025-11-04 11:33:42 +08:00
Matt Farina
ca8eae9361
Reproducible chart archive builds
Building the same chart into an archive multiple times will have
the same sha256 hash.

Perviously, the time in the headers for a file was time.Now() which
changed each time. The time is now collected from the operating
system when the file is loaded and this time is used.

Fixes: #3612

Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-29 11:49:22 -04:00
Scott Rigby
f4c5220d99
Merge pull request #31411 from banjoh/em/reinstate-logger-param
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
feat: reinstate logger parameter to actions package
2025-10-29 10:03:03 -04:00
tison
0d6de28bf4
chore: fix typo of public field
Signed-off-by: tison <wander4096@gmail.com>
2025-10-24 15:02:25 +08:00
Evans Mungai
2ddeb50fa6
Set default logger in Configuration constructor
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-23 18:09:58 +01:00
Evans Mungai
a112bf5aa6
Remove non-reachable code
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-23 09:53:25 +01:00
Robert Sirchia
25ad74f5a7
Merge pull request #31337 from rachelvweber/rawo/fixingWaitStrategy
Fixing rollback and uninstall client WaitStrategy
2025-10-22 15:40:33 -04:00
Evans Mungai
aed687eaa1
Add config options to NewConfiguration()
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 19:18:32 +01:00
Evans Mungai
b6eca1c0f1
Refactor logging functionality to use slog.Handler
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 15:26:48 +01:00
Evans Mungai
5ab4ca5490
Embed logging functionality to DRY code
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 13:55:12 +01:00
Evans Mungai
9c32e34d60
Add logger to sql driver and ensure storage has logger
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 13:29:37 +01:00
Evans Mungai
50e43f4017
nil logger should be handled by discard handler
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 00:40:03 +01:00
Evans Mungai
7a5816b106
Self review changes
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-21 23:53:09 +01:00