George Jenkins
592815ea2b
Fix TestConcurrencyDownloadIndex typo
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-12-14 20:42:29 -08:00
George Jenkins
7edfdb6c5e
Merge pull request #31549 from benoittgt/31548
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: prevent reporting fallback on version when none specified
2025-12-08 08:48:31 -08:00
Mads Jensen
380abe2b16
Remove two redundant if-checks.
...
These were found with the nilness checker.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-11-22 10:13:05 +01:00
Benoit Tigeot
40e22dedb2
fix: prevent reporting fallback on version when none specified
...
Fixes: https://github.com/helm/helm/issues/31548
```
❯ helm pull rancher/longhorn-crd --version 106.2.0+up1.8.2 --destination /tmp/
level=WARN msg="unable to find exact version; falling back to closest available version" chart=longhorn-crd requested=106.2.0+up1.8.2 selected=106.2.0+up1.8.1
❯ bin/helm show chart brigade/brigade
apiVersion: v1
appVersion: v1.5.0
dependencies:
- condition: kashti.enabled
name: kashti
repository: https://brigadecore.github.io/charts
version: 0.7.0
- condition: brigade-github-app.enabled
name: brigade-github-app
repository: https://brigadecore.github.io/charts
version: 0.8.0
- alias: gw
condition: gw.enabled
name: brigade-github-oauth
repository: https://brigadecore.github.io/charts
version: 0.4.0
description: Brigade provides event-driven scripting of Kubernetes pipelines.
name: brigade
version: 1.10.0
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-20 20:49:26 +01:00
Scott Rigby
e7ac8fe3b8
Merge pull request #30984 from fm1ck3y/bug/index-concurrency
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
govulncheck / govulncheck (push) Has been cancelled
feat(concurrency): allow concurrent dependency build with atomic file write
2025-11-13 17:10:33 -05:00
tison
90d01915f9
for all other similar cases
...
Signed-off-by: tison <wander4096@gmail.com>
2025-11-04 11:33:42 +08:00
Artem Vdovin
ae4af69b9d
fix test
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
2025-09-13 16:23:23 +05:00
Artem Vdovin
aaaa457f04
Merge branch 'main' into bug/index-concurrency
2025-09-13 08:29:01 +05:00
Benoit Tigeot
9e2d4680e1
Warn when we fallback to a different version on helm pull
...
Close: https://github.com/helm/helm/issues/31253
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-09-05 19:27:44 +02:00
Matt Farina
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-09-02 10:19:48 -04:00
Matt Farina
3726d01c5c
Merge pull request #31132 from joemicky/main
...
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
2025-08-19 10:51:00 -04:00
joemicky
762ef3ee80
refactor: omit unnecessary reassignment
...
Signed-off-by: joemicky <joemickychang@outlook.com>
2025-08-14 19:30:33 +08:00
joemicky
fab70472af
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
...
Signed-off-by: joemicky <joemickychang@outlook.com>
2025-08-14 19:21:52 +08:00
Robert Sirchia
d7d072b7f6
Merge commit from fork
...
Advisory fix 1
2025-08-13 15:10:00 -04:00
Matt Farina
69efc0d4fb
Handle messy index files
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-07-29 15:37:57 -04:00
Mikel Olasagasti Uranga
7007d4d485
chore(deps): remove phayes/freeport module
...
Replaces the `phayes/freeport` module with the standard library's
`net.Listen("tcp", "127.0.0.1:0")` idiom. This removes an unnecessary
dependency and simplifies the codebase.
Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
2025-07-25 22:23:15 +02:00
Artem Vdovin
118d0eb697
add concurrency test on write & load index file
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
2025-07-20 11:42:20 +05:00
Artem Vdovin
314bd19d11
update writing index files to writeAtomicFile
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
2025-07-13 22:58:37 +05:00
jingchanglu
2da734d0b2
chore: fix typo in pkg/repo/chartrepo.go
...
Signed-off-by: jingchanglu <jingchanglu@outlook.com>
2025-07-10 15:36:39 +08:00
Artem Vdovin
351bb78ee5
fix index concurrency
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
2025-06-16 09:24:30 +05:00
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-05-30 08:12:11 +02:00
Matt Farina
f043faf0a3
Merge pull request #30862 from OmriSteiner/fix-absolute-uri
...
fix: correctly concat absolute URIs in repo cache
2025-05-20 15:38:49 +01:00
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-05-16 10:25:08 +02:00
Omri Steiner
c47c8fc868
fix: correctly concat absolute URIs in repo cache
...
There used to be two implemenations for concatenating the repo URL with
the chart URI / URL. In case the chart specified an absolute URI, one of
the implementations performed an incorrect concatenation between the
two, resulting in a URL which looks like <repo-URL><absolute-chart-URI>.
This commit removes the faulty implementation and uses the other correct
one instead.
Signed-off-by: Omri Steiner <omri@steiners.co.il>
2025-05-15 20:55:08 +02:00
Matthieu MOREL
77a267dacf
chore: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-04-27 22:44:46 +02:00
Justen Stall
4905a61026
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2025-04-23 15:58:33 -04:00
Stephen Murray
1682895636
ref(helm): Export Chart Not Found error
...
Closes #30746
Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>
2025-04-22 20:29:38 +01:00
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2025-04-21 12:13:10 -04:00
Matt Farina
a842140ef6
Merge pull request #13578 from gjenkins8/rm_chart_repo_load_func
...
refactor: Remove ChartRepository `[]ChartPaths`
2025-04-18 20:43:52 +01:00
Benoit Tigeot
a9b7732367
could remove embedded field X from selector
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-04-14 10:43:48 +02:00
Matt Farina
ab9f0c80b5
Merge pull request #30603 from robertsirc/converting-to-slog
...
converting inline log to slog
2025-03-21 16:18:40 -04:00
Robert Sirchia
3a19576377
making changes as requested by matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-03-10 15:40:10 -04:00
George Jenkins
e354dd296d
Merge branch 'main' into rm_chart_repo_load_func
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-03-01 10:49:57 -08:00
Robert Sirchia
848c134e0c
fixing error messages
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-02-28 16:14:48 -05:00
Robert Sirchia
f50547bf51
changing error to warn as requested by Matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-02-28 15:22:47 -05:00
Robert Sirchia
c36bc25fb1
fixing missing attributes
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-02-27 14:48:29 -05:00
Robert Sirchia
1ad79a2bb7
converting inline log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-02-27 14:21:57 -05:00
Robert Sirchia
a11f4c0026
changing info to error
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-02-27 12:56:52 -05:00
Robert Sirchia
48f03d316b
changing from log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-02-26 15:21:47 -05:00
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-02-25 15:20:44 -05:00
Matt Farina
5c0deec327
Moving chartutil to chart/util
...
chartutil was originally created to operate on protobufs which are
no longer part of Helm. The util package makes more sense to be
part of the chart package.
This change is part of the HIP 20 to create v3 charts and
explicitly call out v2 charts. The changes for this are in smaller
bite size changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-02-21 15:25:55 -05:00
George Jenkins
2caca2b167
remove ChartPaths[]
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-02-16 11:04:39 -08:00
George Jenkins
17bc0b3845
refactor: Remove ChartRepository Load() function
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-02-16 11:04:35 -08:00
George Jenkins
234d171da5
Cleanup repotest Server constructors
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-02-08 18:51:37 -08:00
George Jenkins
3253059438
Merge pull request #13535 from helm/refactor_tlsutil
...
refactor: tlsutil use options pattern
2025-02-05 13:23:50 -08:00
George Jenkins
547f49abf6
Merge pull request #13579 from gjenkins8/rm_chart_repo_find_repo_dups
...
refactor: Remove duplicate `FindChartIn*RepoURL` functions
2025-02-05 13:21:35 -08:00
George Jenkins
814ede5427
Merge pull request #13656 from gjenkins8/repotest_server_localhost
...
fix: Bind repotest server to `localhost`
2025-02-03 15:59:07 -08:00
Terry Howe
5a7046b9bf
chore(oci): upgrade to ORAS v2
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
2025-02-02 07:28:41 -07:00
George Jenkins
c68e345663
fix: Bind repotest server to localhost
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-01-25 11:31:46 -08:00
George Jenkins
0ce267d907
more options
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-01-24 20:44:45 -08:00