upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-02-22 09:22:46 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
6789 commits 59 branches 244 tags 136 MiB
Commit graph

129 commits

Author SHA1 Message Date
Matt Farina
863bc74e5a
Update to func handling 
Signed-off-by: Matt Farina <matt@mattfarina.com>
 2023-02-03 15:36:32 -05:00
cui fliter
09d3f31358 fix a few function names on comments 
Signed-off-by: cui fliter <imcusg@gmail.com>
 2022-10-17 20:41:59 +08:00
Matthew Fisher
aa6e82bac8
fix: use go install instead of go get 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
 2022-07-06 13:34:15 -07:00
Matt Farina
f895948ae2
Fixing issue with non-existant .Template when using tpl function 
This is a regression accidently introduced in #9957.

A delete call had been used on the Template key of vals. This caused
a condition where Template was not available when rendering via tpl.
The delete happened after ExecuteTemplate so the issue is surpsising.
It may possibly be a race condition. Existing tests did not catch it.
I tried to create a test that directly tested the issue and was
unable to replicate the error seen with real charts. This leads me
to believe it is a race condition in the underlying Go template
package.

The delete call was not there before #9957. It should be safe to
remove and keep that information.

Closes #10082

Signed-off-by: Matt Farina <matt.farina@suse.com>
 2021-08-31 10:19:54 -04:00
Matt Farina
ac80a5eec9
Merge branch 'main' into feat/subcharts-scope 2021-08-25 10:18:31 -04:00
Matt Farina
2de6f9d424
Merge pull request #9993 from Ka0o0/make-isroot-available-to-template 
Make Chart's IsRoot available to templates
 2021-08-25 10:14:05 -04:00
Kai Takac
8fcaf7b85c Add Chart IsRoot test 
Signed-off-by: Kai Takac <kai.takac@gmail.com>
 2021-08-23 20:10:37 +02:00
Kai Takac
06ae6f933a Make Chart's IsRoot available to templates 
Signed-off-by: Kai Takac <kai.takac@gmail.com>
 2021-08-23 19:27:41 +02:00
Cory Snider
79df3926f6 fix(engine): parse fail messages with newlines 
The templating engine handles errors originating from the `required` and
`fail` template functions specially, cleaning up the error messages to
be more presentable to users. Go's text/template package unfortunately
does not make this straightforward to implement. Despite
template.ExecError implementing Unwrap, the error value returned from
the template function cannot be retrieved using errors.As. The wrapped
error in ExecError is a pre-formatted error string with the template
function's error string interpolated in with the original error value
erased. Helm works around this limitation by delimiting the
template-supplied message and extracting the message out of the
ExecError string with a regex.

Fix the parsing of `required` and `fail` error messages containing
newlines by setting the regex flag to make `.` match newline characters.

Signed-off-by: Cory Snider <csnider@mirantis.com>
 2021-08-10 12:38:43 -04:00
Valentin Flaux
3daaea0a1c feat(pkg/engine): expose subcharts scope in parent 
Expose the scope (.Values, .Charts, .Releases etc.) of subcharts to the parent scope.

Signed-off-by: Valentin Flaux <vflaux@oui.sncf>
 2021-07-20 12:24:27 +02:00
Martin Hickey
dffc2a30c7
Merge pull request #9035 from wizbit/fail-message 
Fail message is now the same as the required message.
 2021-06-02 12:26:39 +01:00
Martin Hickey
699ea6dcef
Merge pull request #9066 from scaat/fix-specification 
[FIX]Unified go specification
 2021-06-02 11:55:53 +01:00
Josh Soref
2bf8fdf45d
chore: Spelling (#9410) 
* spelling: annotate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: asserts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: behavior

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: binary

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: contain

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: copied

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dependency

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: depending

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: deprecated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: doesn't

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: donot

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: inputting

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: iteration

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: jabberwocky

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: kubernetes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: length

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: mismatch

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: multiple

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nonexistent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: outputs

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: panicking

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: plugins

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parsing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: porthos

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: regular

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resource

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: repositories

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: something

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: strict

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: string

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unknown

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-03-15 21:11:57 -04:00
Marcus Speight
7a663a56c2 Fixed Test 
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
Signed-off-by: Marcus Speight <marcus@pmconnect.co.uk>
 2020-12-07 14:58:40 +00:00
Marcus Speight
8aa42824f9 Added test for lint mode 
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
 2020-12-02 18:24:00 +00:00
Scaat Feng
1852694a65 [FIX]comment should start with whitespace 
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
 2020-11-26 14:03:41 +08:00
Marcus Speight
7a0739a863 Fail message is now the same as the required message. 
Fixed #8973 Helm function 'fail' should not fail when doing 'helm lint'

Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
 2020-11-19 08:10:38 +00:00
Paul Brousseau
3192408415 Fixing typo in engine comments 
Signed-off-by: Paul Brousseau <object88@gmail.com>
 2020-09-13 21:31:38 -07:00
Matt Farina
dbd001e532
Removing tiller language 
Since Tiller is no longer part of Helm v3, internal documentation
language about Tiller can be removed

Signed-off-by: Matt Farina <matt@mattfarina.com>
 2020-05-21 15:26:16 -04:00
Matt Butcher
bb47286f09
fix linting error with lookup function (#7969) 
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
 2020-04-22 10:09:34 -06:00
Andre Sencioles
d0726e07ab
Parse reference templates in predictable order (#7702) 
* Parse reference templates in predictable order

Fix issue #7701

Signed-off-by: Andre Sencioles <asenci@gmail.com>

* Add test case for issue #7701 regression

Signed-off-by: Andre Sencioles <asenci@gmail.com>

* gofmt

Signed-off-by: Andre Sencioles <asenci@gmail.com>
 2020-04-21 13:16:55 -06:00
Matt Farina
3b8521c1f0
Updating sprig and semver to newer versions 
Note, there is an issue with a dependency of sprig changing
behavior. A test has been added with a description to catch if a
behavior breaking change of mergo is used.

See https://github.com/imdario/mergo/issues/139 for the mergo
issue and sprig for further details on handling this in the
future.

Closes  #7533

Signed-off-by: Matt Farina <matt@mattfarina.com>
 2020-04-16 14:12:30 -04:00
Adam Reese
c2da4fd53d
ref(*): kubernetes v1.18 (#7831) 
Upgrade Kubernetes libraries to v0.18.0

Add new lazy load KubernetesClientSet to avoid missing kubeconfig error

In kubernetes v1.18 kubeconfig validation was added.  Minikube and Kind
both remove kubeconfig when stopping clusters.  This causes and error
when running any helm commands because we initialize the client before
executing the command.

Signed-off-by: Adam Reese <adam@reese.io>
 2020-04-13 08:40:38 -07:00
Tuan
97c68adc4d
Add fromYamlArray and fromJsonArray template helpers (#7712) 
Signed-off-by: Tuan Nguyen <nmtuan.dev@gmail.com>
 2020-03-27 19:39:41 -06:00
Daniel Cheng
206d4a9053 add test for template recursion 
Signed-off-by: Daniel Cheng <dcheng@us.ibm.com>
 2020-02-10 12:25:41 -05:00
Daniel Cheng
8528548441 fix recursion count in templates 
Signed-off-by: Daniel Cheng <dcheng@us.ibm.com>
 2020-02-07 18:35:21 -05:00
Jon Huhn
43e6285995
Fix engine.newFiles doc comment 
Signed-off-by: Jon Huhn <huhnjon@gmail.com>
 2020-02-06 11:13:20 -06:00
Matthew Fisher
1b1d6bba9c
fix(lookup_func): do not return error when object is not found 
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
 2020-01-30 10:55:33 -08:00
Matthew Fisher
9c680e604b
Merge pull request #7443 from zwwhdls/fix7439 
allow limited recursion in templates
 2020-01-27 09:51:29 -08:00
zwwhdls
16a85f7570 fix test-style 
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
 2020-01-21 22:04:13 +08:00
zwwhdls
4eda4fa06d allow limited recursion in templates 
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
 2020-01-21 21:46:34 +08:00
Matthew Fisher
e84b61b2db
Merge pull request #6752 from raffaelespazzoli/lookup 
Lookup template function
 2020-01-14 11:01:45 -08:00
Josh Soref
02ad2b1187 Spelling (#7258) 
* spelling: constraint

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cryptographic

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dependency

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: doesnot

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: don't

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unexpected

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dreadnought

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: default

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: envvars

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: evaluates

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: execute

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extractor

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: frobnitz

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: generated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: implementation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: jabba

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: keywords

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: kubernetes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: override

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: package

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parsable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: progress

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: recursively

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: release

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cache

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: representing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: serializer

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: subchart

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: utilities

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
 2019-12-18 12:04:08 +00:00
raffaelespazzoli
fa643cfa31 fixed golint 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:37:17 -05:00
raffaelespazzoli
a62ba04962 additional fixes based on @thomastaylor312 comment 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:31:47 -05:00
raffaelespazzoli
0bb4eaace7 addressing some feedback from @thomastaylor312 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:31:47 -05:00
raffaelespazzoli
e98cd621f0 added rest client passed with action configuration 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:31:47 -05:00
raffaelespazzoli
b3495c7353 added license header 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:31:47 -05:00
raffaelespazzoli
02ce01b241 fixed circle ci issues 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:31:47 -05:00
raffaelespazzoli
30d245a0e3 added check on namespaced resource 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:31:47 -05:00
raffaelespazzoli
d564d4bf2d first lookup template function implementation 
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
 2019-12-17 08:31:47 -05:00
海的澜色
750b870aed fix stack overflow error (#7114) 
* fixed #7111

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* update error message

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* add test case

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix lint error

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
 2019-12-02 14:57:51 +00:00
KUOKA Yusuke
4c351c7248 fix(v3): fix type error while merging map loaded with fromYaml template func (#6630) 
Fixes #6626

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
 2019-10-10 16:37:54 +01:00
Matt Farina
9bc7934f35
Updating the module for v3 as the major version 
Signed-off-by: Matt Farina <matt@mattfarina.com>
 2019-10-03 14:27:05 -04:00
Matt Farina
967f4fed42
Update dependencies 
* Kubernetes updated to 1.16.1
* SemVer and Sprig updated to latest releases that leverage go
  modules
* Tests and checks updated. These already landed in v2 via PR 6457

Signed-off-by: Matt Farina <matt@mattfarina.com>
 2019-10-03 13:49:07 -04:00
Adam Reese
4fcc876786
ref(pkg/engine): cleanup of development hack 
This was left in from some of the chart builder work.  I forgot to
remove it.

Signed-off-by: Adam Reese <adam@reese.io>
 2019-09-03 15:31:58 -07:00
Martin Hickey
5906b9dfee Fix style conformance issue 
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
 2019-07-30 16:00:18 +01:00
Ian Howell
c92e3351f7 Switch to a more unique delimiter for template execution errors 
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
 2019-07-29 15:39:44 -05:00
Ian Howell
31b940a61d fix(engine): Fix eating too many colons during template execution 
This fixes #6044, in which error parsing is greedily eating too many
colons, preventing users from using colons in their warning messages to
the `required` function

Signed-off-by: Ian Howell <ian.howell0@gmail.com>
 2019-07-23 11:33:03 -05:00
Thomas O'Donnell
213f714604 Stop Lint from breaking when using required 
Have updated the required filter so that it doesn't break when linting a
chart. This work is based off #4221 and #4748 which didn't make it into
the v3 branch.

Signed-off-by: Thomas O'Donnell <andy.tom@gmail.com>
 2019-06-13 20:32:37 +02:00