mirror of
https://github.com/helm/helm.git
synced 2026-02-03 20:39:45 -05:00
9f620b857a
Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.
To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.
There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.
The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 5727f56a96)
44 lines
1.5 KiB
Bash
Executable file
44 lines
1.5 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
# Copyright The Helm Authors.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
set -euo pipefail
|
|
IFS=$'\n\t'
|
|
|
|
find_files() {
|
|
find . -not \( \
|
|
\( \
|
|
-wholename './.git' \
|
|
-o -wholename '*testdata*' \
|
|
-o -wholename '*third_party*' \
|
|
\) -prune \
|
|
\) \
|
|
\( -name '*.go' -o -name '*.sh' \)
|
|
}
|
|
|
|
# Use "|| :" to ignore the error code when grep returns empty
|
|
failed_license_header=($(find_files | xargs grep -L 'Licensed under the Apache License, Version 2.0 (the "License")' || :))
|
|
if (( ${#failed_license_header[@]} > 0 )); then
|
|
echo "Some source files are missing license headers."
|
|
printf '%s\n' "${failed_license_header[@]}"
|
|
exit 1
|
|
fi
|
|
|
|
# Use "|| :" to ignore the error code when grep returns empty
|
|
failed_copyright_header=($(find_files | xargs grep -L 'Copyright The Helm Authors.' || :))
|
|
if (( ${#failed_copyright_header[@]} > 0 )); then
|
|
echo "Some source files are missing the copyright header."
|
|
printf '%s\n' "${failed_copyright_header[@]}"
|
|
exit 1
|
|
fi
|