mirror of
https://github.com/helm/helm.git
synced 2026-04-15 21:59:50 -04:00
512544b9ab
* Fixing issue with PAX headers in plugin archive PAX Headers can be added by some systems that create archives. Helm should ignore them when extracting. There are two PAX headers. One is global and the other is not. Both are ignored. The test adds only the PAX global header because the Go tar package is unable to write the header that is not global. Closes #8084 Signed-off-by: Matt Farina <matt@mattfarina.com> * Removing the PAX header test as it is not working The PAX header test was making a WriteHeader call and ignoring the error. When writing the type TypeXHeader it was causing an error that was being silently ignored. The Go tar package cannot write this type and produces an error when one tries to. The error reads "cannot manually encode TypeXHeader, TypeGNULongName, or TypeGNULongLink headers" Signed-off-by: Matt Farina <matt@mattfarina.com> * Adding check of returned error in test Adding a check for the returned error to make sure a non-nil value is not returned. Signed-off-by: Matt Farina <matt@mattfarina.com>
90 lines
2.3 KiB
Go
90 lines
2.3 KiB
Go
/*
|
|
Copyright The Helm Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package loader
|
|
|
|
import (
|
|
"archive/tar"
|
|
"bytes"
|
|
"compress/gzip"
|
|
"testing"
|
|
)
|
|
|
|
func TestLoadArchiveFiles(t *testing.T) {
|
|
tcs := []struct {
|
|
name string
|
|
generate func(w *tar.Writer)
|
|
check func(t *testing.T, files []*BufferedFile, err error)
|
|
}{
|
|
{
|
|
name: "empty input should return no files",
|
|
generate: func(w *tar.Writer) {},
|
|
check: func(t *testing.T, files []*BufferedFile, err error) {
|
|
if err.Error() != "no files in chart archive" {
|
|
t.Fatalf(`expected "no files in chart archive", got [%#v]`, err)
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "should ignore files with XGlobalHeader type",
|
|
generate: func(w *tar.Writer) {
|
|
// simulate the presence of a `pax_global_header` file like you would get when
|
|
// processing a GitHub release archive.
|
|
err := w.WriteHeader(&tar.Header{
|
|
Typeflag: tar.TypeXGlobalHeader,
|
|
Name: "pax_global_header",
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// we need to have at least one file, otherwise we'll get the "no files in chart archive" error
|
|
err = w.WriteHeader(&tar.Header{
|
|
Typeflag: tar.TypeReg,
|
|
Name: "dir/empty",
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
},
|
|
check: func(t *testing.T, files []*BufferedFile, err error) {
|
|
if err != nil {
|
|
t.Fatalf(`got unwanted error [%#v] for tar file with pax_global_header content`, err)
|
|
}
|
|
|
|
if len(files) != 1 {
|
|
t.Fatalf(`expected to get one file but got [%v]`, files)
|
|
}
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range tcs {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
buf := &bytes.Buffer{}
|
|
gzw := gzip.NewWriter(buf)
|
|
tw := tar.NewWriter(gzw)
|
|
|
|
tc.generate(tw)
|
|
|
|
_ = tw.Close()
|
|
_ = gzw.Close()
|
|
|
|
files, err := LoadArchiveFiles(buf)
|
|
tc.check(t, files, err)
|
|
})
|
|
}
|
|
}
|