mirror of
https://github.com/helm/helm.git
synced 2026-02-03 20:39:45 -05:00
Linting is specific to the chart versions. A v2 and v3 chart will lint differently. To accomplish this, packages like engine need to be able to handle different chart versions. This was accomplished by some changes: 1. The introduction of a Charter interface for charts 2. The ChartAccessor which is able to accept a chart and then provide access to its data via an interface. There is an interface, factory, and implementation for each version of chart. 3. Common packages were moved to a common and util packages. Due to some package loops, there are 2 packages which may get some consolidation in the future. The new interfaces provide the foundation to move the actions and cmd packages to be able to handle multiple apiVersions of charts. Signed-off-by: Matt Farina <matt.farina@suse.com>
136 lines
3.7 KiB
Go
136 lines
3.7 KiB
Go
/*
|
|
Copyright The Helm Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package action
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"helm.sh/helm/v4/pkg/chart/common"
|
|
"helm.sh/helm/v4/pkg/chart/v2/lint"
|
|
"helm.sh/helm/v4/pkg/chart/v2/lint/support"
|
|
chartutil "helm.sh/helm/v4/pkg/chart/v2/util"
|
|
)
|
|
|
|
// Lint is the action for checking that the semantics of a chart are well-formed.
|
|
//
|
|
// It provides the implementation of 'helm lint'.
|
|
type Lint struct {
|
|
Strict bool
|
|
Namespace string
|
|
WithSubcharts bool
|
|
Quiet bool
|
|
SkipSchemaValidation bool
|
|
KubeVersion *common.KubeVersion
|
|
}
|
|
|
|
// LintResult is the result of Lint
|
|
type LintResult struct {
|
|
TotalChartsLinted int
|
|
Messages []support.Message
|
|
Errors []error
|
|
}
|
|
|
|
// NewLint creates a new Lint object with the given configuration.
|
|
func NewLint() *Lint {
|
|
return &Lint{}
|
|
}
|
|
|
|
// Run executes 'helm Lint' against the given chart.
|
|
func (l *Lint) Run(paths []string, vals map[string]interface{}) *LintResult {
|
|
lowestTolerance := support.ErrorSev
|
|
if l.Strict {
|
|
lowestTolerance = support.WarningSev
|
|
}
|
|
result := &LintResult{}
|
|
for _, path := range paths {
|
|
linter, err := lintChart(path, vals, l.Namespace, l.KubeVersion, l.SkipSchemaValidation)
|
|
if err != nil {
|
|
result.Errors = append(result.Errors, err)
|
|
continue
|
|
}
|
|
|
|
result.Messages = append(result.Messages, linter.Messages...)
|
|
result.TotalChartsLinted++
|
|
for _, msg := range linter.Messages {
|
|
if msg.Severity >= lowestTolerance {
|
|
result.Errors = append(result.Errors, msg.Err)
|
|
}
|
|
}
|
|
}
|
|
return result
|
|
}
|
|
|
|
// HasWarningsOrErrors checks is LintResult has any warnings or errors
|
|
func HasWarningsOrErrors(result *LintResult) bool {
|
|
for _, msg := range result.Messages {
|
|
if msg.Severity > support.InfoSev {
|
|
return true
|
|
}
|
|
}
|
|
return len(result.Errors) > 0
|
|
}
|
|
|
|
func lintChart(path string, vals map[string]interface{}, namespace string, kubeVersion *common.KubeVersion, skipSchemaValidation bool) (support.Linter, error) {
|
|
var chartPath string
|
|
linter := support.Linter{}
|
|
|
|
if strings.HasSuffix(path, ".tgz") || strings.HasSuffix(path, ".tar.gz") {
|
|
tempDir, err := os.MkdirTemp("", "helm-lint")
|
|
if err != nil {
|
|
return linter, fmt.Errorf("unable to create temp dir to extract tarball: %w", err)
|
|
}
|
|
defer os.RemoveAll(tempDir)
|
|
|
|
file, err := os.Open(path)
|
|
if err != nil {
|
|
return linter, fmt.Errorf("unable to open tarball: %w", err)
|
|
}
|
|
defer file.Close()
|
|
|
|
if err = chartutil.Expand(tempDir, file); err != nil {
|
|
return linter, fmt.Errorf("unable to extract tarball: %w", err)
|
|
}
|
|
|
|
files, err := os.ReadDir(tempDir)
|
|
if err != nil {
|
|
return linter, fmt.Errorf("unable to read temporary output directory %s: %w", tempDir, err)
|
|
}
|
|
if !files[0].IsDir() {
|
|
return linter, fmt.Errorf("unexpected file %s in temporary output directory %s", files[0].Name(), tempDir)
|
|
}
|
|
|
|
chartPath = filepath.Join(tempDir, files[0].Name())
|
|
} else {
|
|
chartPath = path
|
|
}
|
|
|
|
// Guard: Error out if this is not a chart.
|
|
if _, err := os.Stat(filepath.Join(chartPath, "Chart.yaml")); err != nil {
|
|
return linter, fmt.Errorf("unable to check Chart.yaml file in chart: %w", err)
|
|
}
|
|
|
|
return lint.RunAll(
|
|
chartPath,
|
|
vals,
|
|
namespace,
|
|
lint.WithKubeVersion(kubeVersion),
|
|
lint.WithSkipSchemaValidation(skipSchemaValidation),
|
|
), nil
|
|
}
|