upstream/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2026-02-03 20:40:17 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix -Wsign-compare warnings

Browse source
This commit is contained in:
Johannes Schmidt 2025-10-17 14:27:18 +02:00
parent 758d1b6873
commit 93e69ed0e8
5 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/base/netstring.cpp
View file

@ -167,7 +167,7 @@ String NetString::ReadStringFromStream(const Shared<AsioTlsStream>::Ptr& stream,
}
}
if (maxMessageLength >= 0 && len > maxMessageLength) {
if (maxMessageLength >= 0 && len > static_cast<std::size_t>(maxMessageLength)) {
std::stringstream errorMessage;
errorMessage << "Max data length exceeded: " << (maxMessageLength / 1024) << " KB";
@ -246,7 +246,7 @@ String NetString::ReadStringFromStream(const Shared<AsioTlsStream>::Ptr& stream,
}
}
if (maxMessageLength >= 0 && len > maxMessageLength) {
if (maxMessageLength >= 0 && len > static_cast<std::size_t>(maxMessageLength)) {
std::stringstream errorMessage;
errorMessage << "Max data length exceeded: " << (maxMessageLength / 1024) << " KB";

2
lib/icingadb/icingadb-objects.cpp
View file

@ -549,7 +549,7 @@ std::vector<std::vector<intrusive_ptr<ConfigObject>>> IcingaDB::ChunkObjects(std
chunks.reserve((std::distance(offset, end) + chunkSize - 1) / chunkSize);
while (std::distance(offset, end) >= chunkSize) {
while (static_cast<std::size_t>(std::distance(offset, end)) >= chunkSize) {
auto until (offset + chunkSize);
chunks.emplace_back(offset, until);
offset = until;

2
lib/remote/apilistener-authority.cpp
View file

@ -25,7 +25,7 @@ void ApiListener::UpdateObjectAuthority()
std::vector<Endpoint::Ptr> endpoints;
Endpoint::Ptr my_endpoint;
int hostChildrenInheritObjectAuthority = 0;
std::size_t hostChildrenInheritObjectAuthority = 0;
if (my_zone) {
my_endpoint = Endpoint::GetLocalEndpoint();

7
test/icinga-dependencies.cpp
View file

@ -35,7 +35,12 @@ static void RegisterDependency(Dependency::Ptr dep, const String& redundancyGrou
dep->GetParent()->AddReverseDependency(dep);
}
static void AssertCheckableRedundancyGroup(Checkable::Ptr checkable, int dependencyCount, int groupCount, int totalDependenciesCount)
static void AssertCheckableRedundancyGroup(
Checkable::Ptr checkable,
std::size_t dependencyCount,
std::size_t groupCount,
std::size_t totalDependenciesCount
)
{
BOOST_CHECK_MESSAGE(
dependencyCount == checkable->GetDependencies().size(),

2
test/remote-httpserverconnection.cpp
View file

@ -56,7 +56,7 @@ struct HttpServerConnectionFixture : TlsStreamFixture, ConfigurationCacheDirFixt
template<class Rep, class Period>
bool AssertServerDisconnected(const std::chrono::duration<Rep, Period>& timeout)
{
auto iterations = timeout / std::chrono::milliseconds(50);
std::size_t iterations = timeout / std::chrono::milliseconds(50);
for (std::size_t i = 0; i < iterations && !m_Connection->Disconnected(); i++) {
Utility::Sleep(std::chrono::duration<double>(timeout).count() / iterations);
}