Commit graph

55 commits

Author SHA1 Message Date
Eric Lippmann
7bb09036fc Fix const visibility 2025-10-21 14:56:41 +02:00
Johannes Meyer
3f1cdc0a85 forms/Command/Object: Show progress labels upon submit
fixes #1204
2025-06-10 15:24:22 +02:00
Johannes Meyer
2da207bedd commands: Send multiple commands while bulk processing
Reduces risk of timeouts in case Icinga takes its time to respond.
The timeout of 15 seconds introduced earlier has been kept.

Chunk sizes were chosen as follows:
- 1000: Cheap calculations (object features, check scheduling)
- 500: Expected disk writes (comments)
- 250: Process check result, Downtimes, Acks
2025-06-10 15:24:22 +02:00
Sukhwinder Dhillon
8d67f55c30 Delete(Downtime|Comment)Form: Fix the incorrect success message 2025-05-21 16:47:35 +02:00
Johannes Meyer
08bbf39048 downtimes: Support automated removal 2025-05-12 16:59:07 +02:00
Johannes Meyer
c78d664f79 comments: Support automated removal 2025-05-12 16:59:07 +02:00
marianrh
c4a8f4748f
Support setting a default comment for acknowledgements (#1178)
I propose to add a new option for setting a default comment for
acknowledging problems (`acknowledge_comment_text`), similar to the
existing `hostdowntime_comment_text` and `servicedowntime_comment_text`
options.

This originally was a pull request for Icinga Web 2
(https://github.com/Icinga/icingaweb2/pull/5365). I was asked to
implement this in Icinga DB Web as well. *However, since I'm not using
Icinga DB Web myself, this is untested.*

Beside adding the new feature, I also fixed a copy-and-paste error for
the `servicedowntime_comment_text` option.
2025-05-08 14:24:15 +02:00
Johannes Meyer
0b06486147 ScheduleHostDowntimeForm: Don't yield command duplicates
fixes #1145
2025-03-24 14:24:23 +01:00
Johannes Meyer
464a440f0f Introduce new class ScheduleDowntimeCommand
Covers the full functionality of the schedule-downtime
endpoint of Icinga 2's api now.

fixes #1090
2024-12-09 12:51:12 +01:00
Johannes Meyer
d5b4087a50 CommandForm: Don't pass generators to commands 2024-04-08 09:17:04 +02:00
Johannes Meyer
bcdbda1e40 CommandForm: Expect Iterator in method getCommands() 2024-03-26 17:05:32 +01:00
Johannes Meyer
435a58b4f6 CommandForm: Ensure getCommands() is passed an Iterator 2024-03-26 17:05:32 +01:00
Johannes Meyer
3d0949edcb CommandForm: Don't add a submit button and CSRF token..
..if it's an API target
2023-09-08 16:37:44 +02:00
Johannes Meyer
4714790b5d Use ipl\Stdlib\iterable_value_first to access the first item..
..a command has been transmitted for.
2023-09-05 09:16:56 +02:00
Alexander A. Klimov
bbf2739b6e DeleteDowntimeCommand: process multiple objects at once 2023-08-02 12:44:02 +02:00
Alexander A. Klimov
cd5f52c1bc DeleteCommentCommand: process multiple objects at once 2023-08-02 12:44:02 +02:00
Alexander A. Klimov
b92eeb69e7 Actually let ObjectsCommand derivates process multiple objects at once 2023-08-02 12:44:02 +02:00
Alexander A. Klimov
1a04927c8b Introduce CommandForm#filterGrantedOn() 2023-08-02 12:44:02 +02:00
Alexander A. Klimov
b4222228cc ObjectCommand and derivates: handle multiple objects 2023-08-02 12:44:02 +02:00
Alexander A. Klimov
051a391444 CommandForm#getCommand(): take (and process) multiple objects, not just one 2023-08-02 12:44:02 +02:00
Ravi Srinivasa
4f7b56ade1 Prevent downtime flexible duration being set to 0h0m 2023-06-02 12:19:15 +02:00
Sukhwinder Dhillon
d4958a4a6a (AddComment/AcknowledgeProblem)Form: Add validators to expire_time element 2023-06-02 09:35:45 +02:00
Sukhwinder Dhillon
f818356ec6 Ipl-html SelectElement: Use options attr instead of multiOptions 2023-05-26 15:06:13 +02:00
Sukhwinder Dhillon
8fa8f4baf0 AcknowledgeProblem|AddComment-Form: Don't show datepicker if expire checkbox is unchecked 2023-05-22 15:07:29 +02:00
Johannes Meyer
ae1d3d1624 DeleteCommentForm: Make it just an inline form
It doesn't need any icinga form layout or style rules
2022-03-21 12:55:46 +01:00
raviks789
2a2ac29589 Fix dis/enabling of feature commands of multi-selected hosts or services.
In case of elements other than CheckboxElement $element->getValue() must be used instead of $element->isChecked().
2021-11-12 12:09:28 +01:00
raviks789
13669fd1ae Set default value of mixed type feature commands of multi-selected hosts or services to "noop". 2021-11-12 12:07:55 +01:00
Yonas Habteab
342ceca676 Display a proper success message when toggling object passive checks 2021-11-05 08:54:57 +01:00
Yonas Habteab
aefd0e1f7d Add PHP 7 argument & return type declarations to all member methods 2021-11-03 16:06:59 +01:00
Sukhwinder Dhillon
5da4b91098 ScheduleServiceDowntimeForm: Add DateTimeValidator 2021-10-07 16:14:06 +02:00
Yonas Habteab
a0499f2cfa Don't show success messages when an error occurred 2021-09-21 15:54:41 +02:00
Johannes Meyer
cde7d6ae65
Merge pull request #333 from Icinga/bugfix/dont-allow-user-to-delete-scheduled-downtimes
Don't allow user to delete scheduled downtimes
2021-09-10 14:27:14 +02:00
Sukhwinder Dhillon
14823480a9 Disable delete button if downtime cannot be deleted 2021-09-08 16:34:06 +02:00
Yonas Habteab
c67b873096 Show a notification for every successful action 2021-09-07 12:11:09 +02:00
Ravi Kumar Kempapura Srinivasa
f662646278 Add end time and comment options to settings section for host/service downtime dialog
[hostdowntime_end_fixed], [hostdowntime_end_flexible], [hostdowntime_flexible_duration], [servicedowntime_end_fixed], [servicedwontime_end_flexible],
[servicedowntime_flexible_duration] and [comment_text] options added to [settings] section in config.ini file used in  host/service downtime dialog.
2021-07-16 15:48:26 +02:00
Johannes Meyer
3bf8944316
Use strict ipl-html interfaces (#217)
* Command forms: Use strict interfaces to construct ipl\Html objects

* BaseTableRowItem: Use strict interfaces to create ipl\Html objects

* ObjectInspectionDetail: Use strict interfaces..

..to create ipl\Html objects

* Setup/*Step: Use strict interfaces to create ipl\Html objects

* ObjectSuggestions: Use strict interfaces to create ipl\Html objects

* Widget: Use strict interfaces to create ipl\Html objects

* Widget\Detail: Use strict interfaces to create ipl\Html objects

* Widget\ItemList: Use strict interfaces to create ipl\Html objects

* ServiceLink: Don't return an array
2021-06-22 10:29:25 +02:00
Florian Strohmaier
9f72fcdf66 DeleteDowntimeForm: Fix typo 2021-06-08 15:03:43 +02:00
Johannes Meyer
b04a2a29d0 command forms: Enable datetime picker widget on datetime elements 2021-05-17 14:22:00 +02:00
Johannes Meyer
d4136d9d83 ProcessCheckResultForm: Skip objects with passive checks disabled
Icinga won't accept check results for such.
2021-04-14 10:56:54 +02:00
Johannes Meyer
213092684e Introduce native object permissions 2021-03-19 15:47:57 +01:00
Johannes Meyer
057b7dc8e0 Check permissions in object context when issuing commands 2021-03-19 15:47:57 +01:00
Johannes Meyer
b33026dc6a Add native implementation to toggle instance features 2021-03-09 09:13:20 +01:00
Johannes Meyer
f88066a930 Add native implementation to toggle object features 2021-03-09 09:13:20 +01:00
Johannes Meyer
47a90b6393 Add native implementation to delete downtimes 2021-03-09 09:13:20 +01:00
Johannes Meyer
c05a5f0f36 Introduce class ProcessCheckResultForm 2021-03-09 09:13:20 +01:00
Johannes Meyer
e52918211c Introduce class ScheduleCheckForm 2021-03-09 09:13:20 +01:00
Johannes Meyer
42c9d78346 Introduce class ScheduleHostDowntimeForm 2021-03-09 09:13:20 +01:00
Johannes Meyer
4f75ddc246 Introduce class ScheduleServiceDowntimeForm 2021-03-09 09:13:20 +01:00
Johannes Meyer
7eb573164a Introduce class SendCustomNotificationForm 2021-03-09 09:13:20 +01:00
Johannes Meyer
b9c1fb1e0b Introduce class AcknowledgeProblemForm 2021-03-09 09:13:20 +01:00