icingadb-web/library/Icingadb/Widget/Health.php
Alvar Penning 3e0bd96ec6 IcingaHealth: Fix version comparison
There are multiple possible outputs for an Icinga DB version. The
package version contain the git tag, with a leading "v". The development
version mimics git-describe(1), including a commit hash separated by a
dash after the semantic version.

The current version comparison uses PHP's builtin version_compare().

This results in leading "v"s to return invalid results. Furthermore, it
treats everything behind the version as an "any string"[^0], which is
smaller than dev, alpha, beta, and so on. Thus, any git-describe(1)
version of Icinga DB 1.4.0 would be considered smaller as 1.4.0.

Fixes #1230.

[^0]: https://www.php.net/manual/en/function.version-compare.php
2025-06-20 10:13:00 +02:00

85 lines
2.7 KiB
PHP

<?php
/* Icinga DB Web | (c) 2020 Icinga GmbH | GPLv2 */
namespace Icinga\Module\Icingadb\Widget;
use Icinga\Module\Icingadb\ProvidedHook\IcingaHealth;
use ipl\Html\BaseHtmlElement;
use ipl\Html\Html;
use ipl\Web\Widget\TimeAgo;
use ipl\Web\Widget\TimeSince;
use ipl\Web\Widget\VerticalKeyValue;
class Health extends BaseHtmlElement
{
protected $data;
protected $tag = 'section';
public function __construct($data)
{
$this->data = $data;
}
protected function assemble()
{
if (
! isset($this->data->icingadb_version)
|| version_compare(
IcingaHealth::normalizeVersion($this->data->icingadb_version),
IcingaHealth::REQUIRED_ICINGADB_VERSION,
'<'
)
) {
$this->addHtml(Html::tag('div', ['class' => 'icinga-health down'], [
sprintf(
t('Icinga DB is outdated, please upgrade to version %s or later.'),
IcingaHealth::REQUIRED_ICINGADB_VERSION
)
]));
} elseif ($this->data->heartbeat->getTimestamp() > time() - 60) {
$this->add(Html::tag('div', ['class' => 'icinga-health up'], [
Html::sprintf(
t('Icinga 2 is up and running %s', '...since <timespan>'),
new TimeSince($this->data->icinga2_start_time->getTimestamp())
)
]));
} else {
$this->add(Html::tag('div', ['class' => 'icinga-health down'], [
Html::sprintf(
t('Icinga 2 or Icinga DB is not running %s', '...since <timespan>'),
new TimeSince($this->data->heartbeat->getTimestamp())
)
]));
}
$icingaInfo = Html::tag('div', ['class' => 'icinga-info'], [
new VerticalKeyValue(
t('Icinga 2 Version'),
$this->data->icinga2_version
),
new VerticalKeyValue(
t('Icinga 2 Start Time'),
new TimeAgo($this->data->icinga2_start_time->getTimestamp())
),
new VerticalKeyValue(
t('Last Heartbeat'),
new TimeAgo($this->data->heartbeat->getTimestamp())
),
new VerticalKeyValue(
t('Active Icinga 2 Endpoint'),
$this->data->endpoint->name ?: t('N/A')
),
new VerticalKeyValue(
t('Icinga DB Version'),
$this->data->icingadb_version ?? t('N/A')
),
new VerticalKeyValue(
t('Active Icinga Web Endpoint'),
gethostname() ?: t('N/A')
)
]);
$this->add($icingaInfo);
}
}