kubectl/pkg/polymorphichelpers
Leoy 39dad5862b kubectl: use %w for error wrapping and remove redundant .Error() calls (#138223)
* kubectl: use %w for error wrapping and remove redundant .Error() calls

Replace fmt.Errorf with %s and err.Error() with idiomatic %w wrapping
in kubectl's polymorphichelpers, wait, and drain packages. This enables
proper error chain inspection via errors.Is/As and follows Go best
practices.

Also fixes a typo: "Statefulset" -> "StatefulSet" in history.go.

* Address review: use %w for error wrapping in extendErrWaitTimeout

Use fmt.Errorf with %w instead of %v to preserve the error chain,
allowing wait.Interrupted() to correctly detect timeout errors.

Signed-off-by: supermario_leo <leo.stack@outlook.com>

* Fix lint: wrap both errors with %w in cordon error path

The linter flags err used with %v when it is an error type. Since
Go 1.20+ supports multiple %w verbs in a single fmt.Errorf call,
wrap both err and patchErr to preserve both error chains.

Signed-off-by: supermario_leo <leo.stack@outlook.com>

---------

Signed-off-by: supermario_leo <leo.stack@outlook.com>

Kubernetes-commit: d916c320deb859cd264354c48f3bd5419f7a2950
2026-04-23 08:37:22 +08:00
..
attachablepodforobject.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
canbeexposed.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
canbeexposed_test.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
helpers.go feat: add all-pods log flag to kubectl 2024-05-07 19:43:46 -04:00
helpers_test.go client-go testing: start ResourceVersion at 1 for empty set 2026-01-14 12:19:32 +01:00
history.go kubectl: use %w for error wrapping and remove redundant .Error() calls (#138223) 2026-04-23 08:37:22 +08:00
history_test.go describer: improve job and pod template output 2024-01-05 14:29:01 -08:00
historyviewer.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
interface.go feat: add all-pods log flag to kubectl 2024-05-07 19:43:46 -04:00
logsforobject.go List containers when given container is not found 2026-02-12 09:47:30 +03:00
logsforobject_test.go List containers when given container is not found 2026-02-12 09:47:30 +03:00
mapbasedselectorforobject.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
mapbasedselectorforobject_test.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
multiprotocolsforobject.go fix: kubectl expose fails for apps with same-port, different-protocol 2023-06-19 09:58:54 +08:00
multiprotocolsforobject_test.go fix: kubectl expose fails for apps with same-port, different-protocol 2023-06-19 09:58:54 +08:00
objectpauser.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
objectpauser_test.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
objectrestarter.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
objectresumer.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
objectresumer_test.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
portsforobject.go fix: kubectl expose fails for apps with same-port, different-protocol 2023-06-19 09:58:54 +08:00
portsforobject_test.go fix: kubectl expose fails for apps with same-port, different-protocol 2023-06-19 09:58:54 +08:00
protocolsforobject.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
protocolsforobject_test.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
rollback.go kubectl: use %w for error wrapping and remove redundant .Error() calls (#138223) 2026-04-23 08:37:22 +08:00
rollback_test.go Drop null creationTimestamp from test fixtures 2025-03-24 09:37:26 -04:00
rollbacker.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
rollout_status.go Fix kubectl conversions 2019-11-17 18:35:55 +01:00
rollout_status_test.go Fix kubectl conversions 2019-11-17 18:35:55 +01:00
statusviewer.go Move pkg/kubectl/polymorphichelpers staging 2019-07-27 19:48:15 -07:00
updatepodspec.go Fix batch/v1 CronJob support in create, describe and polymorphichelpers 2021-03-09 09:44:02 +01:00
updatepodspec_test.go Fix batch/v1 CronJob support in create, describe and polymorphichelpers 2021-03-09 09:44:02 +01:00