mirror of
https://github.com/kubernetes/kubectl.git
synced 2026-02-03 20:39:39 -05:00
309d0ee885
Some unit tests throw this warning. W1013 09:06:21.581870 176998 helpers.go:567] --dry-run=true is deprecated (boolean value) and can be replaced with --dry-run=client. This patch removes the warning by using --dry-run=client instead of --dry-run=true. The unit tests that are affected are: make test WHAT=./vendor/k8s.io/kubectl/pkg/cmd/apply GOFLAGS=-v make test WHAT=./vendor/k8s.io/kubectl/pkg/cmd/create GOFLAGS=-v Signed-off-by: Masashi Honma <masashi.honma@gmail.com> Kubernetes-commit: ad7cbac16354e19981e986bbc2b3fd9cfa930d45
85 lines
2.4 KiB
Go
85 lines
2.4 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package create
|
|
|
|
import (
|
|
"bytes"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
"k8s.io/cli-runtime/pkg/genericclioptions"
|
|
restclient "k8s.io/client-go/rest"
|
|
"k8s.io/client-go/rest/fake"
|
|
cmdtesting "k8s.io/kubectl/pkg/cmd/testing"
|
|
"k8s.io/kubectl/pkg/scheme"
|
|
)
|
|
|
|
func TestCreatePriorityClass(t *testing.T) {
|
|
pcName := "my-pc"
|
|
tf := cmdtesting.NewTestFactory()
|
|
defer tf.Cleanup()
|
|
|
|
ns := scheme.Codecs.WithoutConversion()
|
|
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: schema.GroupVersion{Group: "scheduling.k8s.io", Version: "v1beta1"},
|
|
NegotiatedSerializer: ns,
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: ioutil.NopCloser(&bytes.Buffer{}),
|
|
}, nil
|
|
}),
|
|
}
|
|
tf.ClientConfigVal = &restclient.Config{}
|
|
|
|
outputFormat := "name"
|
|
|
|
ioStreams, _, buf, _ := genericclioptions.NewTestIOStreams()
|
|
cmd := NewCmdCreatePriorityClass(tf, ioStreams)
|
|
cmd.Flags().Set("value", "1000")
|
|
cmd.Flags().Set("global-default", "true")
|
|
cmd.Flags().Set("description", "my priority")
|
|
cmd.Flags().Set("dry-run", "client")
|
|
cmd.Flags().Set("output", outputFormat)
|
|
cmd.Flags().Set("preemption-policy", "Never")
|
|
|
|
printFlags := genericclioptions.NewPrintFlags("created").WithTypeSetter(scheme.Scheme)
|
|
printFlags.OutputFormat = &outputFormat
|
|
|
|
options := &PriorityClassOptions{
|
|
PrintFlags: printFlags,
|
|
Name: pcName,
|
|
IOStreams: ioStreams,
|
|
}
|
|
err := options.Complete(tf, cmd, []string{pcName})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
err = options.Run()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
expectedOutput := "priorityclass.scheduling.k8s.io/" + pcName + "\n"
|
|
if buf.String() != expectedOutput {
|
|
t.Errorf("expected output: %s, but got: %s", expectedOutput, buf.String())
|
|
}
|
|
}
|