mirror of
https://github.com/kubernetes/kubectl.git
synced 2026-02-17 01:28:18 -05:00
e9f6aad68f
Quite a lot of unit tests set up informers with a fake client, do
informerFactory.WaitForCacheSync, then create or modify objects. Such tests
suffered from a race: because the fake client only delivered objects to the
watch after the watch has been created, creating an object too early caused
that object to not get delivered to the informer.
Usually the timing worked out okay because WaitForCacheSync typically slept a
bit while polling, giving the Watch call time to complete, but this race has
also gone wrong occasionally. Now with WaitForCacheSync returning more promptly
without polling (work in progress), the race goes wrong more often.
Instead of working around this in unit tests it's better to improve the fake
client such that List+Watch works reliably, regardless of the timing. The fake
client has traditionally not touched ResourceVersion in stored objects and
doing so now might break unit tests, so the added support for ResourceVersion
is intentionally limited to List+Watch.
The test simulates "real" usage of informers. It runs in a synctest bubble and
completes quickly:
go test -v .
=== RUN TestListAndWatch
listandwatch_test.go:67: I0101 01:00:00.000000] Listed configMaps="&ConfigMapList{ListMeta:{ 1 <nil>},Items:[]ConfigMap{ConfigMap{ObjectMeta:{cm1 default 0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []},Data:map[string]string{},BinaryData:map[string][]byte{},Immutable:nil,},},}" err=null
listandwatch_test.go:79: I0101 01:00:00.000000] Delaying Watch...
listandwatch_test.go:90: I0101 01:00:00.100000] Caches synced
listandwatch_test.go:107: I0101 01:00:00.100000] Created second ConfigMap
listandwatch_test.go:81: I0101 01:00:00.100000] Continuing Watch...
--- PASS: TestListAndWatch (0.00s)
PASS
ok k8s.io/client-go/testing/internal 0.009s
Some users of the fake client need to be updated to avoid test failures:
- ListMeta comparisons have to be updated.
- Optional: pass ListOptions into tracker.Watch. It's optional because
the implementation behaves as before when options are missing,
but the List+Watch race fix only works when options are passed.
Kubernetes-commit: 56448506075c3db1d16b5bbf0c581b833a4646f1
|
||
|---|---|---|
| .. | ||
| attachablepodforobject.go | ||
| canbeexposed.go | ||
| canbeexposed_test.go | ||
| helpers.go | ||
| helpers_test.go | ||
| history.go | ||
| history_test.go | ||
| historyviewer.go | ||
| interface.go | ||
| logsforobject.go | ||
| logsforobject_test.go | ||
| mapbasedselectorforobject.go | ||
| mapbasedselectorforobject_test.go | ||
| multiprotocolsforobject.go | ||
| multiprotocolsforobject_test.go | ||
| objectpauser.go | ||
| objectpauser_test.go | ||
| objectrestarter.go | ||
| objectresumer.go | ||
| objectresumer_test.go | ||
| portsforobject.go | ||
| portsforobject_test.go | ||
| protocolsforobject.go | ||
| protocolsforobject_test.go | ||
| rollback.go | ||
| rollback_test.go | ||
| rollbacker.go | ||
| rollout_status.go | ||
| rollout_status_test.go | ||
| statusviewer.go | ||
| updatepodspec.go | ||
| updatepodspec_test.go | ||