diff --git a/cluster/gce/gci/configure-helper.sh b/cluster/gce/gci/configure-helper.sh index c21361817f7..d819de8649c 100755 --- a/cluster/gce/gci/configure-helper.sh +++ b/cluster/gce/gci/configure-helper.sh @@ -1963,10 +1963,14 @@ def resolve(host): fi sed -i -e "s@{{ *etcd_protocol *}}@$etcd_protocol@g" "${temp_file}" sed -i -e "s@{{ *etcd_apiserver_protocol *}}@$etcd_apiserver_protocol@g" "${temp_file}" - sed -i -e "s@{{ *etcd_creds *}}@$etcd_creds@g" "${temp_file}" + + etcd_creds_and_extra_args="${etcd_creds} ${etcd_apiserver_creds} ${etcd_extra_args}" + etcd_creds_and_extra_args=$(echo "$etcd_creds_and_extra_args" | awk '{for (i=1;i<=NF;i++) printf "\"%s\"%s", $i, (i>/var/log/etcd{{ suffix }}.log 2>&1; fi; exec /usr/local/bin/etcd --name etcd-{{ hostname }} --listen-peer-urls {{ etcd_protocol }}://{{ host_ip }}:{{ server_port }} --initial-advertise-peer-urls {{ etcd_protocol }}://{{ hostname }}:{{ server_port }} --advertise-client-urls {{ etcd_apiserver_protocol }}://127.0.0.1:{{ port }} --listen-client-urls {{ etcd_apiserver_protocol }}://{{ listen_client_ip }}:{{ port }} {{ quota_bytes }} --data-dir /var/etcd/data{{ suffix }} --initial-cluster-state {{ cluster_state }} --initial-cluster {{ etcd_cluster }} {{ etcd_creds }} {{ etcd_apiserver_creds }} {{ etcd_extra_args }} 1>>/var/log/etcd{{ suffix }}.log 2>&1" - ], + "/usr/local/bin/etcd", + "--name=etcd-{{ hostname }}", + "--listen-peer-urls={{ etcd_protocol }}://{{ host_ip }}:{{ server_port }}", + "--initial-advertise-peer-urls={{ etcd_protocol }}://{{ hostname }}:{{ server_port }}", + "--advertise-client-urls={{ etcd_apiserver_protocol }}://127.0.0.1:{{ port }}", + "--listen-client-urls={{ etcd_apiserver_protocol }}://{{ listen_client_ip }}:{{ port }}", + "{{ quota_bytes }}", + "--data-dir=/var/etcd/data{{ suffix }}", + "--initial-cluster-state={{ cluster_state }}", + "--initial-cluster={{ etcd_cluster }}", + "--log-outputs=/var/log/etcd{{ suffix }}.log", + {{ etcd_creds_and_extra_args }} + ], "env": [ { "name": "TARGET_STORAGE", "value": "{{ pillar.get('storage_backend', 'etcd3') }}" @@ -52,12 +61,6 @@ { "name": "INITIAL_ADVERTISE_PEER_URLS", "value": "{{ etcd_protocol }}://{{ hostname }}:{{ server_port }}" }, - { "name": "ETCD_CREDS", - "value": "{{ etcd_creds }}" - }, - { "name": "ETCD_APISERVER_CREDS", - "value": "{{ etcd_apiserver_creds }}" - }, { "name": "ETCD_SNAPSHOT_COUNT", "value": "10000" }, @@ -72,9 +75,12 @@ "livenessProbe": { "exec": { "command": [ - "/bin/sh", - "-c", - "set -x; exec /usr/local/bin/etcdctl --endpoints=127.0.0.1:{{ port }} {{ etcdctl_certs }} --command-timeout=15s endpoint health" + "/usr/local/bin/etcdctl", + "--endpoints=127.0.0.1:{{ port }}", + "--command-timeout=15s", + {{ etcdctl_certs }} + "endpoint", + "health" ] }, "initialDelaySeconds": {{ liveness_probe_initial_delay }},