Prevent nil pointer exception in aggregated discovery

Signed-off-by: Monis Khan <mok@microsoft.com>
This commit is contained in:
Monis Khan 2026-01-26 15:33:16 -05:00
parent 4d212f7f47
commit e7de8ba856
No known key found for this signature in database

View file

@ -559,9 +559,13 @@ func writeDiscoveryResponse(
return
}
var targetGV schema.GroupVersion
if mediaType.Convert == nil ||
(mediaType.Convert.GroupVersion() != apidiscoveryv2.SchemeGroupVersion &&
mediaType.Convert.GroupVersion() != apidiscoveryv2beta1.SchemeGroupVersion) {
if mediaType.Convert == nil {
utilruntime.HandleError(fmt.Errorf("expected aggregated discovery group version, got unknown group and version"))
w.WriteHeader(http.StatusInternalServerError)
return
}
if mediaType.Convert.GroupVersion() != apidiscoveryv2.SchemeGroupVersion &&
mediaType.Convert.GroupVersion() != apidiscoveryv2beta1.SchemeGroupVersion {
utilruntime.HandleError(fmt.Errorf("expected aggregated discovery group version, got group: %s, version %s", mediaType.Convert.Group, mediaType.Convert.Version))
w.WriteHeader(http.StatusInternalServerError)
return