Kubernetes Prow Robot
6d92449054
Merge pull request #134290 from huww98/kcm-no-get-pv
...
Do not get PV for externally deleting volume
2026-03-12 05:13:35 +05:30
Kubernetes Prow Robot
c6f70e3a38
Merge pull request #136399 from tico88612/feat/storage-metric-beta
...
Rename metric `volume_operation_total_errors` to `volume_operation_errors_total`
2026-03-06 00:46:18 +05:30
Mads Jensen
f11bb48738
Remove redundant re-assignment in for-loops under pkg
...
This the forvar rule from modernize. The semantics of the for-loop
changed from Go 1.22 to make this pattern obsolete.
2026-03-02 08:47:43 +01:00
ChengHao Yang
5c88906dca
Rename volume_operation_total_errors to volume_operation_errors_total
...
Raname this because facing lint error, counter metrics should have
"_total" suffix. Add the test `volume_operation_errors_total`
Marked `volume_operation_total_errors` as deprecated
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
2026-02-28 20:08:07 +08:00
Stephen Kitt
d42d1e3d1f
Deprecate obsolete slice utility functions
...
... and update users to use standard library functions.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2026-02-16 10:04:33 +01:00
胡玮文
6b4a37194a
Do not get PV for externally deleting volume
...
Currently, we get each released PV every 15s, and in parallel. If there are a lot of released PV and we cannot finish all the get in 15s, it will starve other request by making the queue waiting for client-side throttling very long.
Even in a normal cluster, these requests are taking majority of all get requests from KCM (58% or 470 qps) in our stress test.
2026-02-16 08:51:08 +08:00
carlory
4bc5464553
Remove feature gate HonorPVReclaimPolicy
...
Signed-off-by: carlory <baofa.fan@daocloud.io>
2026-02-06 13:31:16 +08:00
carlory
be0e68ba84
remove featureGate from PluginManager
...
Signed-off-by: carlory <baofa.fan@daocloud.io>
2026-01-19 11:35:30 +08:00
carlory
6d1afce678
remove GetHostName func from the VolumeHost interface
...
Signed-off-by: carlory <baofa.fan@daocloud.io>
2026-01-19 11:35:30 +08:00
Kubernetes Prow Robot
df9a0bda18
Merge pull request #133797 from tico88612/cleanup/new-fake-with-options
...
Replace apimachinery/pkg/watch.NewFake with NewFakeWithOptions in pkg/controller
2026-01-08 03:01:38 +05:30
carlory
f8e8e55f1d
locked the feature-gate VolumeAttributesClass to default (true) and switch storage version from v1beta1 to v1
...
Signed-off-by: carlory <baofa.fan@daocloud.io>
2025-12-18 15:59:33 +08:00
xigang
8f1ff1d8ce
Refactor PV controller to use rate-limiting queues and improve error handling
...
Signed-off-by: xigang <wangxigang2014@gmail.com>
2025-12-01 19:11:52 +08:00
Ondra Kupka
ed74779a0f
controller/volume/persistentvolume: Improve goroutine mgmt
...
Make sure all threads are terminated when Run returns.
2025-11-04 23:58:15 +01:00
Aditi Gupta
af231d2153
Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/
2025-09-16 14:51:34 -07:00
ChengHao Yang
ef96d9cbd2
Replace NewFake with NewFakeWithOptions in pkg/controller
...
CreateTestClient add the argument logger for support contextual logging
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
2025-09-11 08:39:49 +08:00
Kubernetes Prow Robot
566d6acb70
Merge pull request #131759 from carlory/clean-volumehost
...
Remove unused GetHostIP method
2025-07-12 05:35:28 -07:00
PatrickLaabs
baf71997f5
chore: depr. pointer pkg replacement for pkg/controller
2025-07-07 13:22:36 +02:00
Kubernetes Prow Robot
f407bd6d24
Merge pull request #132254 from carlory/cleanup-MountContainers
...
Cleanup after Alpha feature MountContainers was removed
2025-06-18 17:24:50 -07:00
Davanum Srinivas
03afe6471b
Add a replacement for cmp.Diff using json+go-difflib
...
Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2025-06-16 17:10:42 -04:00
carlory
85bc3cb096
Remove GetExec method from VolumeHost
...
Signed-off-by: carlory <baofa.fan@daocloud.io>
2025-06-13 10:58:37 +08:00
carlory
f0dde38234
Remove pluginName param from GetMounter and GetExec
...
Signed-off-by: carlory <baofa.fan@daocloud.io>
2025-06-12 17:29:17 +08:00
carlory
fe1b1fff7c
Remove unused GetHostIP method
2025-05-14 14:50:59 +08:00
carlory
28d359beec
promote HonorPVReclaimPolicy to GA
...
Signed-off-by: carlory <baofa.fan@daocloud.io>
2025-02-27 14:01:22 +08:00
Davanum Srinivas
4e05bc20db
Linter to ensure go-cmp/cmp is used ONLY in tests
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2025-01-24 20:49:14 -05:00
Patrick Ohly
8a908e0c0b
remove import doc comments
...
The "// import <path>" comment has been superseded by Go modules.
We don't have to remove them, but doing so has some advantages:
- They are used inconsistently, which is confusing.
- We can then also remove the (currently broken) hack/update-vanity-imports.sh.
- Last but not least, it would be a first step towards avoiding the k8s.io domain.
This commit was generated with
sed -i -e 's;^package \(.*\) // import.*;package \1;' $(git grep -l '^package.*// import' | grep -v 'vendor/')
Everything was included, except for
package labels // import k8s.io/kubernetes/pkg/util/labels
because that package is marked as "read-only".
2024-12-02 16:59:34 +01:00
Abhishek Kr Srivastav
95860cff1c
Fix Go vet errors for master golang
...
Co-authored-by: Rajalakshmi-Girish <rajalakshmi.girish1@ibm.com>
Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
2024-09-20 12:36:38 +05:30
Joe Betz
2595aa1309
generate
2024-09-03 14:26:26 -04:00
carlory
c4851c64a0
remove volumeoptions from VolumePlugin and BlockVolumePlugin
2024-07-24 14:07:02 +08:00
Drew Sirenko
16c2ad5b84
Add labels to PVCollector bound/unbound PVC metrics for VolumeAttributesClass Feature ( #126166 )
...
* Add labels to PVCollector bound/unbound PVC metrics
* fixup! Add labels to PVCollector bound/unbound PVC metrics
* wip: Fix 'Unknown
Decorator'
* fixup! Add labels to PVCollector bound/unbound PVC metrics
2024-07-23 12:21:29 -07:00
carlory
3a6a4830df
pvc bind pv with vac
2024-07-23 15:04:11 +08:00
carlory
cd2c8cb5fd
Fix pv reclaim failed due to its phase is wrongly updated to the Failed state by kcm
2024-06-28 01:25:45 +08:00
Kubernetes Prow Robot
aeed1d0e1a
Merge pull request #124842 from carlory/honor-pv-reclaim-policy-e2e
...
Promote HonorPVReclaimPolicy to beta and enable it by default
2024-06-19 13:26:41 -07:00
carlory
4058178b8c
Promote HonorPVReclaimPolicy to beta and enable it by default
2024-06-19 13:51:37 +08:00
carlory
214287b370
kube-controller-manager removed deprecated command flags: --volume-host-cidr-denylist and --volume-host-allow-local-loopback
2024-05-27 10:59:09 +08:00
carlory
9c92b37d4e
remove clusterName from VolumeOptions
2024-05-10 16:42:31 +08:00
Alvaro Aleman
6d0ac8c561
Use the generic/typed workqueue throughout
...
This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.
2024-05-04 14:33:12 -04:00
Kubernetes Prow Robot
dbb7004385
Merge pull request #121256 from liyuerich/workqueue
...
drop deprecated workqueue NewNamed package
2024-04-29 09:33:05 -07:00
Kubernetes Prow Robot
38c2a963b4
Merge pull request #123984 from carlory/volume-remove-cloud-provider
...
Remove cloud provider dependency from volume host and volume controllers
2024-04-28 02:54:14 -07:00
liyuerich
98dfaed4be
drop deprecated workqueue NewNamed package
...
Signed-off-by: liyuerich <yue.li@daocloud.io>
2024-04-28 14:04:51 +08:00
Marek Siarkowicz
3ee8178768
Cleanup defer from SetFeatureGateDuringTest function call
2024-04-24 20:25:29 +02:00
carlory
9ec6ee539a
Remove cloud provider dependency from volume host and volume controllers
2024-04-18 19:00:37 +08:00
Mengjiao Liu
b584b87a94
kube-controller-manager: readjust log verbosity
...
- Increase the global level for broadcaster's logging to 3 so that users can ignore event messages by lowering the logging level. It reduces information noise.
- Making sure the context is properly injected into the broadcaster, this will allow the -v flag value to be used also in that broadcaster, rather than the above global value.
- test: use cancellation from ktesting
- golangci-hints: checked error return value
2024-02-26 14:51:56 +08:00
Kubernetes Prow Robot
eb1ae05cf0
Merge pull request #122030 from carlory/121799
...
fix issue with using feature HonorPVReclaimPolicy in csi-provisioner
2024-01-19 04:35:48 +01:00
carlory
5ff42b2368
fix issue with using feature HonorPVReclaimPolicy in csi-provisioner
2024-01-17 10:57:30 +08:00
carlory
8af9a177b2
If a pvc has an empty storageclass name, don't try to assign a default StorageClass to it.
2024-01-13 21:25:43 +08:00
Kubernetes Prow Robot
c24e8ee403
Merge pull request #121697 from carlory/clean-111
...
add comments for switch case of syncUnboundClaim
2023-12-13 22:35:00 +01:00
carlory
ae24846c48
add comments for switch of syncUnboundClaim
2023-11-08 17:15:27 +08:00
carlory
58236aa3eb
remove EventRecorder from ControllerParameters of pv base controller
2023-11-01 17:54:00 +08:00
Patrick Ohly
2472291790
api: introduce separate VolumeResourceRequirements struct
...
PVC and containers shared the same ResourceRequirements struct to define their
API. When resource claims were added, that struct got extended, which
accidentally also changed the PVC API. To avoid such a mistake from happening
again, PVC now uses its own VolumeResourceRequirements struct.
The `Claims` field gets removed because risk of breaking someone is low:
theoretically, YAML files which have a claims field for volumes now
get rejected when validating against the OpenAPI. Such files
have never made sense and should be fixed.
Code that uses the struct definitions needs to be updated.
2023-08-21 15:31:28 +02:00
Ziqi Zhao
dfc1838379
Migrated pkg/controller/volume|util|replicaset|nodeipam to contextual logging
...
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-07-06 07:39:52 +08:00