This patch replaces direct struct initialization cpuset.CPUSet{} with
cpuset.New() to ensure the internal map is properly initialized.
While most CPUSet methods work correctly without this change, the Equals
method uses reflect.DeepEqual which returns false when comparing CPUSet
instances where one has a nil internal map and the other has an initialized
(empty) map. This can lead to unexpected false negatives in equality checks.
For example, the following comparison would incorrectly return false:
cpuset.CPUSet{}.Equals(cpuset.New())
This change ensures consistent behavior across all CPUSet operations.
Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
consolidate the pattern
```
pod = e2epod.NewPodClient(f).CreateSync(ctx, pod)
podMap[string(pod.UID)] = pod
```
into a new helper function. More than reducing code duplication,
this is to avoid bugs and leaks.
Signed-off-by: Francesco Romani <fromani@redhat.com>
we get flakes on CI, not on dev environments, which
suggests a timing issue. From test perspective,
there is no need of immediate response, so adding
an Eventually doesn't invalidate the test and should reduce flakes.
Signed-off-by: Francesco Romani <fromani@redhat.com>
move generic helpers in the generic utilities file,
because this code is not topology-manager specific and we
lack a better place.
trivial code movement.
Signed-off-by: Francesco Romani <fromani@redhat.com>
we have 2 almost identical tests, one of them being labeled NodeConformance,
the other being a strict subset of the former, both enabled
unconditionally. This seems redundant by any account.
Let's keep the conformance one.
Signed-off-by: Francesco Romani <fromani@redhat.com>
Replace all imports of k8s.io/apimachinery/pkg/util/dump with
k8s.io/utils/dump across the repo. The apimachinery dump package
now contains deprecated wrapper functions that delegate to
k8s.io/utils/dump for backwards compatibility.
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
- Moved sample device plugin constants and helper code to the
test/e2e/node/framework, so that both deviceplugin and DRA tests can
use it without creating e2e -> e2e_node dependency.
- Moved SampleDevsAmount constant from the
test/e2e_node/device_plugin_test.go
kubelet: defer the configurations flags (and the related fallback behavior) deprecation removal timeline from 1.36 to 1.37 to align with containerd v1.7 support
Graduates the ImageVolume feature gate to GA in v1.36, locked to enabled.
Changes:
- Add v1.36 GA entry with LockToDefault: true
- Remove +featureGate=ImageVolume annotations from API types
- Promote e2e test to conformance
- Add emulation versioning to disablement tests
- Update conformance test metadata
- Remove feature-gated test expectations for ImageVolume PullPolicy
Ref: https://github.com/kubernetes/enhancements/issues/4639
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Change /etc/os-release to /etc/passwd in subPath test to avoid
symlink issues with Alpine 3.21 (kitten:1.8).
Add Feature:ImageVolume tag to properly categorize tests for CI.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Two test contexts were failing because their AfterEach blocks run even
when BeforeEach skips the test (standard Ginkgo behavior). This caused
resetCRIProxyInjector to fail with "CRI Proxy is undefined".
Switched to using DeferCleanup inside BeforeEach instead, which only
runs if BeforeEach succeeds. This is the same pattern the other test
contexts in this file already use.
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
