mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-05-15 10:29:48 -04:00
e4ed3aa73b
Go 1.26's testing.testDeps interface added a ModulePath() string method.
Without it, fakeTestDeps no longer satisfies the interface and any build
with -tags=coverage (KUBE_BUILD_WITH_COVERAGE=true) fails to compile at
pkg/util/coverage/coverage.go:84 (testing.MainStart):
pkg/util/coverage/coverage.go:84:32: cannot use deps (variable of
struct type fakeTestDeps) as testing.testDeps value in argument to
testing.MainStart: fakeTestDeps does not implement testing.testDeps
(missing method ModulePath)
This restores the two coverage jobs that have been failing for ~65 days:
ci-kubernetes-coverage-conformance
history: https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/ci-kubernetes-coverage-conformance
sample: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-coverage-conformance/2053245547074031616
ci-kubernetes-coverage-e2e-gci-gce
history: https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/ci-kubernetes-coverage-e2e-gci-gce
sample: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-coverage-e2e-gci-gce/2053247811943665664
The build image kube-cross:v1.36.0-go1.26.2-bullseye.0 is what surfaced
this once kube-cross moved to Go 1.26.
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
|
||
|---|---|---|
| .. | ||
| coverage.go | ||
| coverage_disabled.go | ||
| fake_test_deps.go | ||
| OWNERS | ||