kubernetes/cmd
Kubernetes Submit Queue ef3b27cbd4
Merge pull request #55642 from dashpole/disable_cadvisor_disk_for_cri
Automatic merge from submit-queue (batch tested with PRs 55642, 55897, 55835, 55496, 55313). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Disable container disk metrics when using the CRI stats integration

Issue: https://github.com/kubernetes/kubernetes/issues/51798

As explained in the issue, runtimes which make use of the CRI Stats API still have the performance overhead of collecting those same stats through cAdvisor.
The CRI Stats API has metrics for CPU, Memory, and Disk.  This PR significantly reduces the added overhead due to collecting these stats in both cAdvisor and in the runtime.
This PR disables container disk metrics, which are very expensive to collect.

This PR does not disable node-level disk stats, as the "Raw" container handler does not currently respect ignoring DiskUsageMetrics.
This PR factors out the logic for determining whether or not to use the CRI stats provider into a helper function, as cAdvisor is instantiated before it is passed to the kubelet as a dependency.

cc @kubernetes/sig-node-pr-reviews @derekwaynecarr  
/kind feature
/sig node

/assign @Random-Liu @derekwaynecarr
2017-11-18 10:46:30 -08:00
..
clicheck update BUILD files 2017-10-15 18:18:13 -07:00
cloud-controller-manager Fix typo in CloudControllerManager 2017-11-15 22:17:55 -08:00
gendocs update BUILD files 2017-10-15 18:18:13 -07:00
genkubedocs kubeadm-doc-gen 2017-11-13 15:32:58 +01:00
genman kubeadm-doc 2017-10-27 09:57:25 +02:00
genswaggertypedocs update BUILD files 2017-10-15 18:18:13 -07:00
genutils cmd: genutils: remove golint_failure entry 2017-11-02 12:48:15 +11:00
genyaml update BUILD files 2017-10-15 18:18:13 -07:00
gke-certificates-controller use versiond group clients from client-go 2017-11-07 14:47:22 +08:00
hyperkube respond to wlan0's feedback 2017-11-10 14:29:00 -08:00
importverifier Merge pull request #54568 from sttts/sttts-import-verifier-yaml 2017-10-25 23:10:29 -07:00
kube-apiserver Adding the mutating webhook 2017-11-17 21:02:47 -08:00
kube-controller-manager add clusterrole aggregation controller 2017-11-13 08:18:00 -05:00
kube-proxy Enforce use of fixed size int types in the API 2017-11-13 11:28:59 -08:00
kubeadm Add test case for phase kubelet. 2017-11-18 10:22:16 +08:00
kubectl Merge pull request #50887 from netroby/patch-1 2017-11-02 15:40:15 -07:00
kubelet Merge pull request #55642 from dashpole/disable_cadvisor_disk_for_cri 2017-11-18 10:46:30 -08:00
kubemark remove duplicated import 2017-11-14 17:18:17 +08:00
linkcheck update BUILD files 2017-10-15 18:18:13 -07:00
BUILD Remove seemingly obsolete binaries 2017-08-18 21:01:19 -07:00
OWNERS Updated top level owners file to match new format 2017-01-19 11:29:16 -08:00