kubernetes/pkg/controller
Kubernetes Submit Queue 5a54555f59
Merge pull request #63049 from andrewsykim/kcm-nodeipam
Automatic merge from submit-queue (batch tested with PRs 63049, 59731). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

re-enable nodeipam in kube-controller-manager

**What this PR does / why we need it**:
Re-enables nodeipam controller for external clouds. Also does a small refactor so that we don't need to pass in `allocateNodeCidr` into the controller. 

In v1.10 we made a change (9187b343e1 (diff-f11913dc67d80d36b3d06a93f61c49cf) in https://github.com/kubernetes/kubernetes/pull/57492) where nodeipam would be disabled for any cluster that sets `--cloud-provider=external`. The original intention behind this was that the nodeipam controller is cloud specific for some clouds (only GCE at the moment) so it should be moved to the CCM (cloud controller manager). After some discussions with wg-cloud-provider it makes sense to re-enable nodeipam controller in KCM and have GCE CCM enable its own cloud-specific IPAM controller as part of [Initialize()](https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/cloud.go#L33-L35). This would allow for GCE to run nodeipam in both KCM (by setting --cloud-provider=gce and --allocate-node-cidr) and in the CCM (once implemented in `Initialize()`) without disabling nodeipam in the KCM for all external clouds and avoids having to implement nodeipam in CCM. 

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes # 

**Special notes for your reviewer**:


**Release note**:
```release-note
Re-enable nodeipam controller for external clouds. 
```
2018-05-11 11:07:12 -07:00
..
bootstrap should use time.Since instead of time.Now().Sub 2018-04-10 12:05:51 +08:00
certificates Merge pull request #59727 from wgliang/master.time 2018-05-10 20:29:40 -07:00
cloud Update error assertation 2018-05-03 10:22:20 +08:00
clusterroleaggregation Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
cronjob Merge pull request #62011 from hanxiaoshuai/fixtodo0402 2018-04-05 18:47:07 -07:00
daemon Merge pull request #59727 from wgliang/master.time 2018-05-10 20:29:40 -07:00
deployment update tests to be specific about the versions they are testing instead of floating 2018-05-01 13:18:41 -04:00
disruption Merge pull request #59727 from wgliang/master.time 2018-05-10 20:29:40 -07:00
endpoint Merge pull request #59727 from wgliang/master.time 2018-05-10 20:29:40 -07:00
garbagecollector simplify api registration 2018-05-08 18:33:50 -04:00
history remove versioning interface 2018-04-27 07:56:42 -04:00
job Merge pull request #59727 from wgliang/master.time 2018-05-10 20:29:40 -07:00
namespace Merge pull request #59727 from wgliang/master.time 2018-05-10 20:29:40 -07:00
nodeipam renable nodeipam in kube-controller-manager 2018-04-23 22:28:37 -04:00
nodelifecycle PR #59323, fix bug and remove one api call, add node util dependency to cloud controller 2018-04-22 20:32:26 +03:00
podautoscaler simplify api registration 2018-05-08 18:33:50 -04:00
podgc Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
replicaset update tests to be specific about the versions they are testing instead of floating 2018-05-01 13:18:41 -04:00
replication Use typed events client directly 2018-04-01 18:57:29 +10:00
resourcequota should use time.Since instead of time.Now().Sub 2018-04-10 12:05:51 +08:00
route should use time.Since instead of time.Now().Sub 2018-04-10 12:05:51 +08:00
service Use typed events client directly 2018-04-01 18:57:29 +10:00
serviceaccount should use time.Since instead of time.Now().Sub 2018-04-10 12:05:51 +08:00
statefulset should use time.Since instead of time.Now().Sub 2018-04-10 12:05:51 +08:00
testutil PR #59323, fix bug and remove one api call, add node util dependency to cloud controller 2018-04-22 20:32:26 +03:00
ttl Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
util/node PR #59323, fix bug and remove one api call, add node util dependency to cloud controller 2018-04-22 20:32:26 +03:00
volume Merge pull request #59727 from wgliang/master.time 2018-05-10 20:29:40 -07:00
.import-restrictions add import restrictions 2016-10-13 16:10:24 -07:00
BUILD update tests to be specific about the versions they are testing instead of floating 2018-05-01 13:18:41 -04:00
client_builder.go remove duplicated import 2017-11-14 17:18:17 +08:00
controller_ref_manager.go Update the DaemonSet controller to use the apps/v1 API 2018-02-22 11:38:54 -08:00
controller_ref_manager_test.go Merge pull request #50353 from zhangxiaoyu-zidif/Delete-redundant-expectError-for-controller-ref-test 2017-08-12 00:00:55 -07:00
controller_utils.go PR #59323, fix bug and remove one api call, add node util dependency to cloud controller 2018-04-22 20:32:26 +03:00
controller_utils_test.go update tests to be specific about the versions they are testing instead of floating 2018-05-01 13:18:41 -04:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
lookup_cache.go Use fnv.New32a() in hash instead adler32 2017-02-15 14:03:54 +08:00
OWNERS remove some people from OWNERS so they don't get reviews anymore 2017-07-13 10:02:21 -07:00