kubernetes/pkg
k8s-merge-robot 707cc2bbb8 Merge pull request #26493 from caesarxuchao/fix-gc-flake
Automatic merge from submit-queue

Fixes 25890 flake. Let GC convert ListOptions to v1 before passing it to the dynamic client

GC's ListWatcher directly passed the api.ListOptions to the dynamic client, but the parameter codec of dynamic client converts the options to queries based on the tags in the struct, which are not present in api.ListOptions, so the queries are not sent to the server. As a result, the Watch request was sent without a resourceVersion, causing missed events. Flake #25890 is caused by the missed deletion events.

This PR converts the api.ListOptions to v1.ListOptions before the GC passes it to the dynamic codec. The flaky test has successfully passed 79 times ([log](https://00e9e64bacd064560a027fbee9c5a373a1614f3a56e652ae40-apidata.googleusercontent.com/download/storage/v1_internal/b/kubernetes-jenkins/o/pr-logs%2Fpull%2F25923%2Fkubernetes-pull-test-unit-integration%2F28364%2Fbuild-log.txt?qk=AD5uMEv72OjSUqDyk5i-ZLurcmM4i7gket1c7WaqR7yuIYz7WhPYT7ewVBafijV0ymnPTYqxRYt1kp6S9YQv7chPwC-3UtrKetKfhYnvAFrPGXAIBxHytTmpFohRAYgsARN1B6j1f9vyK5lM-8jyzRGhCK3sCRsAPnbDBWIWFlbH4b1n3vUET3P71QamHrF5itYyaqRU5pMZV3Cwwr81X8q7h5hCzm3Ip78RpMzfjEqTG0RcM2TLGccUrlkWVBLh4hn0NFpUIkzVFugFA5ooJffo-0AdJnO3mGWEOnXNVFWftJbK8cKnTns0DISrYFOyH_PlOe_YHCxgIXIT-dW8G-nbqoUjn5SBqunr36rcpaYCIwe2va4W_AcLCT43xiEAezRER_U9AuIqi_22KMd6SuHTyljhmWFPvPk8-gpjthLWXhcE7LPO5dV41hnZHnbI4n_9eI1nSVm7q9XdSvX1sWKV1GCwn8oj017AnxVvl9bScultko_0dTC747UqJ6UTFakLuFcHFe-F5Tz7ItDWlBVPoXeC7gTpyuicFKLsdqGlW9F5X6kIwNrBRj9uRsS-QuzSER-fVkQCn4dUTcokttRH_0bYvyfr9oqiDXmywMgOp-L0sKayk8JOVynh2q0Tju9sdkvFr0PxoAjhofomfIC1SZ_JkOzwAT1TUW8dLjPHluMct34xW_-qna1AmkoxM4bZQLhllap96NTC-0IdtzeKDrTul8p7u3WXSJjjEMSijibTNMlnkB0AluT1_RNO94OnzuFv4YlcV24FPhJzchhbyKREkOb_wzgcnSbRwGHjIcfRgkX-IzoXHVBcMYFUrPmsXrnRcfad4XwjkUOgvivkURW2_EwnzgrLDh-IKek51_0FpT1MnFCSG0gQbVSs_iMVPr6UXNAw62LGbKVtl3ZMXyapEpcO8azNbn6Wvd550R704JXxYlU)).

@lavalamp @krousey @smarterclayton
2016-06-04 01:52:31 -07:00
..
admission make admission plugins configurable based on external criteria 2016-05-26 09:12:17 -04:00
api Attach/Detach Controller Kubelet Changes 2016-06-02 16:47:11 -07:00
apimachinery Moving StorageFactory building logic to genericapiserver 2016-05-10 00:57:11 -07:00
apis Attach/Detach Controller Kubelet Changes 2016-06-02 16:47:11 -07:00
apiserver Merge pull request #26085 from smarterclayton/delay_flush 2016-05-28 11:53:51 -07:00
auth Add an 'authenticated user' metric to the RequestAuthenticator. 2016-05-19 16:04:11 -07:00
capabilities
client Merge pull request #26493 from caesarxuchao/fix-gc-flake 2016-06-04 01:52:31 -07:00
cloudprovider Add Amazon ELB proxy protocol support 2016-05-31 10:33:16 -05:00
controller Merge pull request #26493 from caesarxuchao/fix-gc-flake 2016-06-04 01:52:31 -07:00
conversion Remove src and dest version - they are not used (now) 2016-05-12 10:10:35 -04:00
credentialprovider Add ap-northeast-2 2016-05-10 12:03:41 -04:00
dns Fix srv record lookup 2016-06-03 20:41:08 -07:00
fieldpath Downward API implementation for resources limits and requests 2016-05-24 12:22:35 -04:00
fields
genericapiserver Merge pull request #26169 from victorgp/master 2016-05-29 13:24:46 -07:00
healthz
httplog
hyperkube
kubectl Merge pull request #26693 from AdoHe/init_containers 2016-06-03 10:13:49 -07:00
kubelet Merge pull request #26747 from freehan/kubenetdir 2016-06-03 15:38:09 -07:00
kubemark Added pods-per-core to kubelet. #25762 2016-05-27 07:10:13 -04:00
labels Make IsValidLabelValue return error strings 2016-05-17 21:36:10 -07:00
master Merge pull request #25374 from brendandburns/plural 2016-06-01 02:25:30 -07:00
metrics Fix call-sites after dep updates 2016-06-02 16:57:28 -07:00
probe followup to add http server close method 2016-05-05 12:04:41 +08:00
proxy add hostport support for kubenet 2016-05-22 22:18:58 -07:00
quota Update use of Quantity in other classes 2016-05-19 08:41:43 -04:00
registry Merge pull request #26693 from AdoHe/init_containers 2016-06-03 10:13:49 -07:00
runtime Merge pull request #26251 from caesarxuchao/add-serializer 2016-06-01 23:31:47 -07:00
security Adding volume plugin to api/v1 and updating auto-generated files 2016-05-21 12:53:03 -07:00
securitycontext Merge pull request #24909 from pmorie/security-context-loc 2016-05-27 10:27:55 -07:00
serviceaccount Make name validators return string slices 2016-05-18 00:48:01 -07:00
ssh Merge pull request #24506 from timstclair/ssh 2016-04-19 22:36:44 -07:00
storage Merge pull request #26386 from janetkuo/etcd-test-flake 2016-05-27 05:49:51 -07:00
types
ui Remove url query param that is leading to XSS issue 2016-03-22 10:35:06 -07:00
util Merge pull request #26654 from janetkuo/e2e-deployment-list-rs 2016-06-02 08:54:36 -07:00
version Include Go version, platform, and other build info in version string 2016-03-14 13:55:28 -07:00
volume Merge pull request #26777 from jsafrane/fix-attach-errors 2016-06-03 22:34:56 -07:00
watch Merge pull request #24789 from wojtek-t/use_proper_codec_in_client 2016-05-04 11:00:04 -07:00
OWNERS Move blunderbuss assignees into tree 2016-03-02 20:46:32 -05:00