mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-02-03 20:40:26 -05:00
The verbs parameter slice might be shared between different rule instances and
gets sorted (= written), so we have to make a copy or (even better) also
de-duplicate as in pkg/apis/rbac/helpers.go.
More specifically, plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go
shares the Read and ReadWrite slices, causing:
WARNING: DATA RACE
Read at 0x000008e5e5b0 by goroutine 124:
slices.insertionSortOrdered[go.shape.string]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/slices/zsortordered.go:14 +0x126
slices.pdqsortOrdered[go.shape.string]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/slices/zsortordered.go:75 +0x6c4
slices.Sort[go.shape.[]string,go.shape.string]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/slices/sort.go:18 +0x64
sort.Strings()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/sort/sort.go:181 +0xe
k8s.io/kubernetes/pkg/apis/rbac/v1.(*PolicyRuleBuilder).Rule()
/home/prow/go/src/k8s.io/kubernetes/pkg/apis/rbac/v1/helpers.go:98 +0x2c9
k8s.io/kubernetes/pkg/apis/rbac/v1.(*PolicyRuleBuilder).RuleOrDie()
/home/prow/go/src/k8s.io/kubernetes/pkg/apis/rbac/v1/helpers.go:65 +0x2f44
k8s.io/kubernetes/plugin/pkg/auth/authorizer/rbac/bootstrappolicy.ClusterRoles()
/home/prow/go/src/k8s.io/kubernetes/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go:404 +0x2c13
...
Previous write at 0x000008e5e5b0 by goroutine 123:
slices.insertionSortOrdered[go.shape.string]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/slices/zsortordered.go:15 +0x2f9
slices.pdqsortOrdered[go.shape.string]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/slices/zsortordered.go:75 +0x6c4
slices.Sort[go.shape.[]string,go.shape.string]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/slices/sort.go:18 +0x64
sort.Strings()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.25.6.linux-amd64/src/sort/sort.go:181 +0xe
k8s.io/kubernetes/pkg/apis/rbac/v1.(*PolicyRuleBuilder).Rule()
/home/prow/go/src/k8s.io/kubernetes/pkg/apis/rbac/v1/helpers.go:98 +0x2c9
k8s.io/kubernetes/pkg/apis/rbac/v1.(*PolicyRuleBuilder).RuleOrDie()
/home/prow/go/src/k8s.io/kubernetes/pkg/apis/rbac/v1/helpers.go:65 +0x2f44
k8s.io/kubernetes/plugin/pkg/auth/authorizer/rbac/bootstrappolicy.ClusterRoles()
/home/prow/go/src/k8s.io/kubernetes/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go:404 +0x2c13
Seen in test/integration/apiserver/oidc.
238 lines
7.5 KiB
Go
238 lines
7.5 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package v1
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
rbacv1 "k8s.io/api/rbac/v1"
|
|
|
|
"sort"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/util/sets"
|
|
)
|
|
|
|
// +k8s:deepcopy-gen=false
|
|
|
|
// PolicyRuleBuilder let's us attach methods. A no-no for API types.
|
|
// We use it to construct rules in code. It's more compact than trying to write them
|
|
// out in a literal and allows us to perform some basic checking during construction
|
|
type PolicyRuleBuilder struct {
|
|
PolicyRule rbacv1.PolicyRule `protobuf:"bytes,1,opt,name=policyRule"`
|
|
}
|
|
|
|
func NewRule(verbs ...string) *PolicyRuleBuilder {
|
|
return &PolicyRuleBuilder{
|
|
PolicyRule: rbacv1.PolicyRule{Verbs: sets.NewString(verbs...).List()},
|
|
}
|
|
}
|
|
|
|
func (r *PolicyRuleBuilder) Groups(groups ...string) *PolicyRuleBuilder {
|
|
r.PolicyRule.APIGroups = combine(r.PolicyRule.APIGroups, groups)
|
|
return r
|
|
}
|
|
|
|
func (r *PolicyRuleBuilder) Resources(resources ...string) *PolicyRuleBuilder {
|
|
r.PolicyRule.Resources = combine(r.PolicyRule.Resources, resources)
|
|
return r
|
|
}
|
|
|
|
func (r *PolicyRuleBuilder) Names(names ...string) *PolicyRuleBuilder {
|
|
r.PolicyRule.ResourceNames = combine(r.PolicyRule.ResourceNames, names)
|
|
return r
|
|
}
|
|
|
|
func (r *PolicyRuleBuilder) URLs(urls ...string) *PolicyRuleBuilder {
|
|
r.PolicyRule.NonResourceURLs = combine(r.PolicyRule.NonResourceURLs, urls)
|
|
return r
|
|
}
|
|
|
|
func combine(s1, s2 []string) []string {
|
|
s := sets.NewString(s1...)
|
|
s.Insert(s2...)
|
|
return s.List()
|
|
}
|
|
|
|
func (r *PolicyRuleBuilder) RuleOrDie() rbacv1.PolicyRule {
|
|
ret, err := r.Rule()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func (r *PolicyRuleBuilder) Rule() (rbacv1.PolicyRule, error) {
|
|
if len(r.PolicyRule.Verbs) == 0 {
|
|
return rbacv1.PolicyRule{}, fmt.Errorf("verbs are required: %#v", r.PolicyRule)
|
|
}
|
|
|
|
switch {
|
|
case len(r.PolicyRule.NonResourceURLs) > 0:
|
|
if len(r.PolicyRule.APIGroups) != 0 || len(r.PolicyRule.Resources) != 0 || len(r.PolicyRule.ResourceNames) != 0 {
|
|
return rbacv1.PolicyRule{}, fmt.Errorf("non-resource rule may not have apiGroups, resources, or resourceNames: %#v", r.PolicyRule)
|
|
}
|
|
case len(r.PolicyRule.Resources) > 0:
|
|
if len(r.PolicyRule.NonResourceURLs) != 0 {
|
|
return rbacv1.PolicyRule{}, fmt.Errorf("resource rule may not have nonResourceURLs: %#v", r.PolicyRule)
|
|
}
|
|
if len(r.PolicyRule.APIGroups) == 0 {
|
|
// this a common bug
|
|
return rbacv1.PolicyRule{}, fmt.Errorf("resource rule must have apiGroups: %#v", r.PolicyRule)
|
|
}
|
|
default:
|
|
return rbacv1.PolicyRule{}, fmt.Errorf("a rule must have either nonResourceURLs or resources: %#v", r.PolicyRule)
|
|
}
|
|
|
|
sort.Strings(r.PolicyRule.Resources)
|
|
sort.Strings(r.PolicyRule.ResourceNames)
|
|
sort.Strings(r.PolicyRule.APIGroups)
|
|
sort.Strings(r.PolicyRule.NonResourceURLs)
|
|
sort.Strings(r.PolicyRule.Verbs)
|
|
return r.PolicyRule, nil
|
|
}
|
|
|
|
// +k8s:deepcopy-gen=false
|
|
|
|
// ClusterRoleBindingBuilder let's us attach methods. A no-no for API types.
|
|
// We use it to construct bindings in code. It's more compact than trying to write them
|
|
// out in a literal.
|
|
type ClusterRoleBindingBuilder struct {
|
|
ClusterRoleBinding rbacv1.ClusterRoleBinding `protobuf:"bytes,1,opt,name=clusterRoleBinding"`
|
|
}
|
|
|
|
func NewClusterBinding(clusterRoleName string) *ClusterRoleBindingBuilder {
|
|
return &ClusterRoleBindingBuilder{
|
|
ClusterRoleBinding: rbacv1.ClusterRoleBinding{
|
|
ObjectMeta: metav1.ObjectMeta{Name: clusterRoleName},
|
|
RoleRef: rbacv1.RoleRef{
|
|
APIGroup: GroupName,
|
|
Kind: "ClusterRole",
|
|
Name: clusterRoleName,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func (r *ClusterRoleBindingBuilder) Groups(groups ...string) *ClusterRoleBindingBuilder {
|
|
for _, group := range groups {
|
|
r.ClusterRoleBinding.Subjects = append(r.ClusterRoleBinding.Subjects, rbacv1.Subject{APIGroup: rbacv1.GroupName, Kind: rbacv1.GroupKind, Name: group})
|
|
}
|
|
return r
|
|
}
|
|
|
|
func (r *ClusterRoleBindingBuilder) Users(users ...string) *ClusterRoleBindingBuilder {
|
|
for _, user := range users {
|
|
r.ClusterRoleBinding.Subjects = append(r.ClusterRoleBinding.Subjects, rbacv1.Subject{APIGroup: rbacv1.GroupName, Kind: rbacv1.UserKind, Name: user})
|
|
}
|
|
return r
|
|
}
|
|
|
|
func (r *ClusterRoleBindingBuilder) SAs(namespace string, serviceAccountNames ...string) *ClusterRoleBindingBuilder {
|
|
for _, saName := range serviceAccountNames {
|
|
r.ClusterRoleBinding.Subjects = append(r.ClusterRoleBinding.Subjects, rbacv1.Subject{Kind: rbacv1.ServiceAccountKind, Namespace: namespace, Name: saName})
|
|
}
|
|
return r
|
|
}
|
|
|
|
func (r *ClusterRoleBindingBuilder) BindingOrDie() rbacv1.ClusterRoleBinding {
|
|
ret, err := r.Binding()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func (r *ClusterRoleBindingBuilder) Binding() (rbacv1.ClusterRoleBinding, error) {
|
|
if len(r.ClusterRoleBinding.Subjects) == 0 {
|
|
return rbacv1.ClusterRoleBinding{}, fmt.Errorf("subjects are required: %#v", r.ClusterRoleBinding)
|
|
}
|
|
|
|
return r.ClusterRoleBinding, nil
|
|
}
|
|
|
|
// +k8s:deepcopy-gen=false
|
|
|
|
// RoleBindingBuilder let's us attach methods. It is similar to
|
|
// ClusterRoleBindingBuilder above.
|
|
type RoleBindingBuilder struct {
|
|
RoleBinding rbacv1.RoleBinding
|
|
}
|
|
|
|
// NewRoleBinding creates a RoleBinding builder that can be used
|
|
// to define the subjects of a role binding. At least one of
|
|
// the `Groups`, `Users` or `SAs` method must be called before
|
|
// calling the `Binding*` methods.
|
|
func NewRoleBinding(roleName, namespace string) *RoleBindingBuilder {
|
|
return &RoleBindingBuilder{
|
|
RoleBinding: rbacv1.RoleBinding{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: roleName,
|
|
Namespace: namespace,
|
|
},
|
|
RoleRef: rbacv1.RoleRef{
|
|
APIGroup: GroupName,
|
|
Kind: "Role",
|
|
Name: roleName,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
// Groups adds the specified groups as the subjects of the RoleBinding.
|
|
func (r *RoleBindingBuilder) Groups(groups ...string) *RoleBindingBuilder {
|
|
for _, group := range groups {
|
|
r.RoleBinding.Subjects = append(r.RoleBinding.Subjects, rbacv1.Subject{Kind: rbacv1.GroupKind, APIGroup: GroupName, Name: group})
|
|
}
|
|
return r
|
|
}
|
|
|
|
// Users adds the specified users as the subjects of the RoleBinding.
|
|
func (r *RoleBindingBuilder) Users(users ...string) *RoleBindingBuilder {
|
|
for _, user := range users {
|
|
r.RoleBinding.Subjects = append(r.RoleBinding.Subjects, rbacv1.Subject{Kind: rbacv1.UserKind, APIGroup: GroupName, Name: user})
|
|
}
|
|
return r
|
|
}
|
|
|
|
// SAs adds the specified service accounts as the subjects of the
|
|
// RoleBinding.
|
|
func (r *RoleBindingBuilder) SAs(namespace string, serviceAccountNames ...string) *RoleBindingBuilder {
|
|
for _, saName := range serviceAccountNames {
|
|
r.RoleBinding.Subjects = append(r.RoleBinding.Subjects, rbacv1.Subject{Kind: rbacv1.ServiceAccountKind, Namespace: namespace, Name: saName})
|
|
}
|
|
return r
|
|
}
|
|
|
|
// BindingOrDie calls the binding method and panics if there is an error.
|
|
func (r *RoleBindingBuilder) BindingOrDie() rbacv1.RoleBinding {
|
|
ret, err := r.Binding()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return ret
|
|
}
|
|
|
|
// Binding builds and returns the RoleBinding API object from the builder
|
|
// object.
|
|
func (r *RoleBindingBuilder) Binding() (rbacv1.RoleBinding, error) {
|
|
if len(r.RoleBinding.Subjects) == 0 {
|
|
return rbacv1.RoleBinding{}, fmt.Errorf("subjects are required: %#v", r.RoleBinding)
|
|
}
|
|
|
|
return r.RoleBinding, nil
|
|
}
|