kubernetes/test/utils/ktesting/helper_test.go
Patrick Ohly 551cf6f171 ktesting: reimplement without interface
The original implementation was inspired by how context.Context is handled via
wrapping a parent context. That approach had several issues:

- It is useful to let users call methods (e.g. tCtx.ExpectNoError)
  instead of ktesting functions with a tCtx parameters, but that only
  worked if all implementations of the interface implemented that
  set of methods. This made extending those methods cumbersome (see
  the commit which added Require+Assert) and could potentially break
  implementations of the interface elsewhere, defeating part of the
  motivation for having the interface in the first place.

- It was hard to see how the different TContext wrappers cooperated
  with each other.

- Layering injection of "ERROR" and "FATAL ERROR" on top of prefixing
  with the klog header caused post-processing of a failed unit test to
  remove that line because it looked like log output. Other log output
  lines where kept because they were not indented.

- In Go <=1.25, the `go vet sprintf` check only works for functions and
  methods if they get called directly and themselves directly pass their
  parameters on to fmt.Sprint. The check does not work when calling
  methods through an interface. Support for that is coming in Go 1.26,
  but will depend on bumping the Go version also in go.mod and thus
  may not be immediately possible in Kubernetes.

- Interface documentation in
  https://pkg.go.dev/k8s.io/kubernetes@v1.34.2/test/utils/ktesting#TContext
  is a monolithic text block. Documentation for methods is more readable and allows
  referencing those methods with [] (e.g. [TC.Errorf] works, [TContext.Errorf]
  didn't).

The revised implementation is a single struct with (almost) no exported
fields. The two exceptions (embedded context.Context and TB) are useful because
it avoids having to write wrappers for several functions resp. necessary
because Helper cannot be wrapped. Like a logr.LogSink, With* methods can make a
shallow copy and then change some fields in the cloned instance.

The former `ktesting.TContext` interface is now a type alias for
`*ktesting.TC`. This ensures that existing code using ktesting doesn't need to
be updated and because that code is a bit more compact (`tCtx
ktesting.TContext` instead of `tCtx *ktesting.TContext` when not using such an
alias). Hiding that it is a pointer might discourage accessing the exported
fields because it looks like an interface.

Output gets fixed and improved such that:
- "FATAL ERROR" and "ERROR" are at the start of the line, followed by the klog header.
- The failure message follows in the next line.
- Continuation lines are always indented.

The set of methods exposed via TB is now a bit more complete (Attr, Chdir).

All former stand-alone With* functions are now also available as methods and
should be used instead of the functions. Those will be removed.

Linting of log calls now works and found some issues.
2026-01-05 13:45:03 +01:00

175 lines
4.6 KiB
Go

/*
Copyright 2024 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package ktesting
import (
"fmt"
"regexp"
"strings"
"testing"
"time"
"github.com/stretchr/testify/assert"
)
// testcase wraps a callback which is called with a TContext that intercepts
// errors and log output. Those get compared.
type testcase struct {
cb func(TContext)
expectDuration time.Duration
expectTrace string
}
func (tc testcase) run(t *testing.T) {
buffer := &mockTB{}
tCtx := Init(buffer)
start := time.Now()
func() {
defer func() {
if r := recover(); r != nil && r != logBufferStop {
panic(r)
}
}()
tc.cb(tCtx)
}()
duration := time.Since(start)
trace := buffer.log.String()
t.Logf("Trace:\n%s\n", trace)
assert.InDelta(t, tc.expectDuration.Seconds(), duration.Seconds(), 0.1, "callback invocation duration %s", duration)
assert.Equal(t, tc.expectTrace, normalize(trace))
}
// normalize replaces parts of message texts which may vary with constant strings.
func normalize(msg string) string {
// duration
msg = regexp.MustCompile(`[[:digit:]]+\.[[:digit:]]+s`).ReplaceAllString(msg, "x.y s")
// hex pointer value
msg = regexp.MustCompile(`0x[[:xdigit:]]+`).ReplaceAllString(msg, "0xXXXX")
// per-test klog header
msg = regexp.MustCompile(`[EI][[:digit:]]{4} [[:digit:]]{2}:[[:digit:]]{2}:[[:digit:]]{2}\.[[:digit:]]{6}\]`).ReplaceAllString(msg, "<klog header>:")
return msg
}
// mockTB records which calls were made (type and parameters)
//
// The final string looks similar to the output visible in `go test -v`,
// except that it is visible how the sausage was made (Fatal vs Log + FailNow).
// Log+FailNow and Fatal are equivalent with testing.T, but not
// with Ginkgo as underlying TB because it can only properly
// capture the failure message if Fatal is used.
type mockTB struct {
log strings.Builder
}
func (m *mockTB) Attr(key, value string) {
m.log.WriteString(fmt.Sprintf("(ATTR) %q %q\n", key, value))
}
func (m *mockTB) Chdir(dir string) {
m.log.WriteString(fmt.Sprintf("(CHDIR) %q\n", dir))
}
func (m *mockTB) Cleanup(func()) {
// Gets called by Init all the time, not logged because it's distracting.
// m.log.WriteString("(CLEANUP)\n")
}
func (m *mockTB) Error(args ...any) {
m.log.WriteString(fmt.Sprintln(append([]any{"(ERROR)"}, args...)...))
}
func (m *mockTB) Errorf(format string, args ...any) {
m.log.WriteString(fmt.Sprintf("(ERRORF) "+format+"\n", args))
}
func (m *mockTB) Fail() {
m.log.WriteString("(FAIL)\n")
}
func (m *mockTB) FailNow() {
m.log.WriteString("(FAILNOW)\n")
panic(logBufferStop)
}
func (m *mockTB) Failed() bool {
m.log.WriteString("(FAILED)\n")
return false
}
func (m *mockTB) Fatal(args ...any) {
m.log.WriteString(fmt.Sprintln(append([]any{"(FATAL)"}, args...)...))
panic(logBufferStop)
}
func (m *mockTB) Fatalf(format string, args ...any) {
m.log.WriteString(fmt.Sprintf("(FATALF) "+format+"\n", args))
panic(logBufferStop)
}
func (m *mockTB) Helper() {
// TODO: include stack unwinding to verify that Helper is called in the right places.
// Merely logging it is not sufficient.
// m.log.WriteString("HELPER\n")
}
func (m *mockTB) Log(args ...any) {
m.log.WriteString(fmt.Sprintln(append([]any{"(LOG)"}, args...)...))
}
func (m *mockTB) Logf(format string, args ...any) {
m.log.WriteString(fmt.Sprintf("(LOGF) "+format+"\n", args))
}
func (m *mockTB) Name() string {
// Gets called by Init all the time, not logged because its distracting.
// m.log.WriteString("(NAME)\n")
return "logBufferT"
}
func (m *mockTB) Setenv(key, value string) {
m.log.WriteString("(SETENV)\n")
}
func (m *mockTB) Skip(args ...any) {
m.log.WriteString(fmt.Sprintln(append([]any{"(SKIP)"}, args...)...))
panic(logBufferStop)
}
func (m *mockTB) SkipNow() {
m.log.WriteString("(SKIPNOW)\n")
panic(logBufferStop)
}
func (m *mockTB) Skipf(format string, args ...any) {
m.log.WriteString(fmt.Sprintf("(SKIPF) "+format+"\n", args...))
panic(logBufferStop)
}
func (m *mockTB) Skipped() bool {
m.log.WriteString("(SKIPPED)\n")
return false
}
func (m *mockTB) TempDir() string {
m.log.WriteString("(TEMPDIR)\n")
return "/no-such-dir"
}
var (
logBufferStop = "STOP"
)