mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-02-14 08:14:28 -05:00
36a95a05eb
Bumping to 5 is useful in unit tests. Those tend to not produce less output and ideally use per-test output, so we end up keeping only the output of failed tests where increased verbosity also in CI runs is useful. But ktesting now also gets imported into e2e test binaries through the framework. There the increased verbosity is apparently causing OOM killing in some jobs which previously worked fine. Long term we need a better solution than simply disabling the verbosity change. We could modify each unit test to call SetDefaultVerbosity, but that's tedious. Perhaps an env variable? It cannot be a command line flag because not all unit tests accept `-v`.
51 lines
1.7 KiB
Go
51 lines
1.7 KiB
Go
/*
|
|
Copyright 2023 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package ktesting
|
|
|
|
import (
|
|
"flag"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"k8s.io/klog/v2"
|
|
|
|
// Initialize command line parameters.
|
|
_ "k8s.io/component-base/logs/testinit"
|
|
)
|
|
|
|
// SetDefaultVerbosity can be called during init to modify the default
|
|
// log verbosity of the program.
|
|
//
|
|
// Note that this immediately reconfigures the klog verbosity, already before
|
|
// flag parsing. If the verbosity is non-zero and SetDefaultVerbosity is called
|
|
// during init, then other init functions might start logging where normally
|
|
// they wouldn't log anything. Should this occur, then the right fix is to
|
|
// remove those log calls because logging during init is discouraged. It leads
|
|
// to unpredictable output (init order is not specified) and/or is useless
|
|
// (logging not initialized during init and thus conditional log output gets
|
|
// omitted).
|
|
func SetDefaultVerbosity(v int) {
|
|
f := flag.CommandLine.Lookup("v")
|
|
_ = f.Value.Set(fmt.Sprintf("%d", v))
|
|
}
|
|
|
|
// NewTestContext is a replacement for ktesting.NewTestContext
|
|
// which returns a more versatile context.
|
|
func NewTestContext(tb testing.TB) (klog.Logger, TContext) {
|
|
tCtx := Init(tb)
|
|
return tCtx.Logger(), tCtx
|
|
}
|