mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-02-23 10:10:47 -05:00
eb317ecd40
Fixes instances of #98213 (to ultimately complete #98213 linting is required). This commit fixes a few instances of a common mistake done when writing parallel subtests or Ginkgo tests (basically any test in which the test closure is dynamically created in a loop and the loop doesn't wait for the test closure to complete). I'm developing a very specific linter that detects this king of mistake and these are the only violations of it it found in this repo (it's not airtight so there may be more). In the case of Ginkgo tests, without this fix, only the last entry in the loop iteratee is actually tested. In the case of Parallel tests I think it's the same problem but maybe a bit different, iiuc it depends on the execution speed. Waiting for the CI to confirm the tests are still passing, even after this fix - since it's likely it's the first time those test cases are executed - they may be buggy or testing code that is buggy. Another instance of this is in `test/e2e/storage/csi_mock_volume.go` and is still failing so it has been left out of this commit and will be addressed in a separate one |
||
|---|---|---|
| .. | ||
| config | ||
| metrics | ||
| options | ||
| testing | ||
| binder_test.go | ||
| delete_test.go | ||
| framework_test.go | ||
| index.go | ||
| index_test.go | ||
| OWNERS | ||
| provision_test.go | ||
| pv_controller.go | ||
| pv_controller_base.go | ||
| pv_controller_test.go | ||
| recycle_test.go | ||
| volume_host.go | ||