Patrick Ohly fa1f9d444c apiserver: avoid default toleration seconds data race for all tests ... This reverts commit 2e756e7412, which addressed the data race only for test/integration/apiserver/oidc. It also occurs for test/integration/controlplane/transformation: WARNING: DATA RACE Read at 0x000008b9de38 by goroutine 104616: k8s.io/kubernetes/plugin/pkg/admission/defaulttolerationseconds.RegisterFlags() /home/prow/go/src/k8s.io/kubernetes/plugin/pkg/admission/defaulttolerationseconds/admission.go:42 +0x30 k8s.io/kubernetes/pkg/kubeapiserver/options.registerAllAdmissionPluginFlags() /home/prow/go/src/k8s.io/kubernetes/pkg/kubeapiserver/options/plugins.go:115 +0x64 k8s.io/kubernetes/pkg/kubeapiserver/options.(*AdmissionOptions).AddFlags() /home/prow/go/src/k8s.io/kubernetes/pkg/kubeapiserver/options/admission.go:73 +0x55 k8s.io/kubernetes/pkg/controlplane/apiserver/options.(*Options).AddFlags() /home/prow/go/src/k8s.io/kubernetes/pkg/controlplane/apiserver/options/options.go:154 +0x388 k8s.io/kubernetes/cmd/kube-apiserver/app/options.(*ServerRunOptions).Flags() /home/prow/go/src/k8s.io/kubernetes/cmd/kube-apiserver/app/options/options.go:101 +0x73 k8s.io/kubernetes/cmd/kube-apiserver/app/testing.StartTestServer() /home/prow/go/src/k8s.io/kubernetes/cmd/kube-apiserver/app/testing/testserver.go:219 +0xb77 k8s.io/kubernetes/test/integration/controlplane/transformation.newTransformTest() /home/prow/go/src/k8s.io/kubernetes/test/integration/controlplane/transformation/transformation_test.go:131 +0x6d0 k8s.io/kubernetes/test/integration/controlplane/transformation.TestKMSv2Healthz() /home/prow/go/src/k8s.io/kubernetes/test/integration/controlplane/transformation/kmsv2_transformation_test.go:874 +0x1c8 testing.tRunner() /usr/local/go/src/testing/testing.go:1792 +0x225 testing.(*T).Run.gowrap1() /usr/local/go/src/testing/testing.go:1851 +0x44 Previous write at 0x000008b9de38 by goroutine 111926: github.com/spf13/pflag.newInt64Value() /home/prow/go/src/k8s.io/kubernetes/vendor/github.com/spf13/pflag/int64.go:9 +0x49 github.com/spf13/pflag.(*FlagSet).Int64Var() /home/prow/go/src/k8s.io/kubernetes/vendor/github.com/spf13/pflag/int64.go:41 +0x3d k8s.io/kubernetes/plugin/pkg/admission/defaulttolerationseconds.RegisterFlags() /home/prow/go/src/k8s.io/kubernetes/plugin/pkg/admission/defaulttolerationseconds/admission.go:42 +0x25 k8s.io/kubernetes/pkg/kubeapiserver/options.registerAllAdmissionPluginFlags() /home/prow/go/src/k8s.io/kubernetes/pkg/kubeapiserver/options/plugins.go:115 +0x64 k8s.io/kubernetes/pkg/kubeapiserver/options.(*AdmissionOptions).AddFlags() /home/prow/go/src/k8s.io/kubernetes/pkg/kubeapiserver/options/admission.go:73 +0x55 k8s.io/kubernetes/pkg/controlplane/apiserver/options.(*Options).AddFlags() /home/prow/go/src/k8s.io/kubernetes/pkg/controlplane/apiserver/options/options.go:154 +0x388 k8s.io/kubernetes/cmd/kube-apiserver/app/options.(*ServerRunOptions).Flags() /home/prow/go/src/k8s.io/kubernetes/cmd/kube-apiserver/app/options/options.go:101 +0x73 k8s.io/kubernetes/cmd/kube-apiserver/app/testing.StartTestServer() /home/prow/go/src/k8s.io/kubernetes/cmd/kube-apiserver/app/testing/testserver.go:219 +0xb77 k8s.io/kubernetes/test/integration/controlplane/transformation.newTransformTest() /home/prow/go/src/k8s.io/kubernetes/test/integration/controlplane/transformation/transformation_test.go:131 +0x6d0 k8s.io/kubernetes/test/integration/controlplane/transformation.TestKMSv2FeatureFlag() /home/prow/go/src/k8s.io/kubernetes/test/integration/controlplane/transformation/kmsv2_transformation_test.go:1009 +0x117 testing.tRunner() /usr/local/go/src/testing/testing.go:1792 +0x225 testing.(*T).Run.gowrap1() /usr/local/go/src/testing/testing.go:1851 +0x44 A more general solution is to lock while registering the variables (= write) and while reading the variables once in InspectFeatureGates.		2025-09-02 21:01:04 +02:00
..
pkg	apiserver: avoid default toleration seconds data race for all tests	2025-09-02 21:01:04 +02:00
OWNERS	Add api-machinery TL owners permissions for jpbetz	2023-05-15 11:09:54 -04:00