From b2eb45e6159987b6f8c91d63bf4c6caa2eb45bbc Mon Sep 17 00:00:00 2001 From: Doug Lauder Date: Tue, 27 Jan 2026 18:07:53 -0500 Subject: [PATCH] Add missing auditRec.Success calls; fix missing return on error. (#34954) Co-authored-by: Mattermost Build --- server/channels/api4/remote_cluster.go | 5 +++++ server/channels/api4/shared_channel.go | 1 + 2 files changed, 6 insertions(+) diff --git a/server/channels/api4/remote_cluster.go b/server/channels/api4/remote_cluster.go index ac6381dd1c8..3816c24a43d 100644 --- a/server/channels/api4/remote_cluster.go +++ b/server/channels/api4/remote_cluster.go @@ -125,6 +125,8 @@ func remoteClusterAcceptMessage(c *Context, w http.ResponseWriter, r *http.Reque return } + auditRec.Success() + if _, err := w.Write(b); err != nil { c.Logger.Warn("Error while writing response", mlog.Err(err)) } @@ -575,8 +577,11 @@ func generateRemoteClusterInvite(c *Context, w http.ResponseWriter, r *http.Requ inviteCode, invErr := c.App.CreateRemoteClusterInvite(rc.RemoteId, url, rc.Token, password) if invErr != nil { c.Err = invErr + return } + auditRec.Success() + w.WriteHeader(http.StatusCreated) if err := json.NewEncoder(w).Encode(inviteCode); err != nil { c.Logger.Warn("Error while writing response", mlog.Err(err)) diff --git a/server/channels/api4/shared_channel.go b/server/channels/api4/shared_channel.go index 130960b7038..d8ef8c5c7e6 100644 --- a/server/channels/api4/shared_channel.go +++ b/server/channels/api4/shared_channel.go @@ -235,6 +235,7 @@ func uninviteRemoteClusterToChannel(c *Context, w http.ResponseWriter, r *http.R // if the channel is not shared with the remote, we return early if !hasRemote { + auditRec.Success() w.WriteHeader(http.StatusNoContent) return }