511 commits

Author	SHA1	Message	Date
Ben Cooke	36479bd721	Configurable workers and move sweeper job to job infra (#35007)	2026-02-02 15:52:42 -05:00
Matthew Birtch	95ba2db4f0	[MM-66862] Channel Info RHS: add ability to rename and open channel settings (#34708) ... * Channel Info RHS: add rename-from-info and settings access Add channel name editable area with pencil hover and wire to a lightweight Rename Channel modal; add Channel Settings item to RHS menu with permission checks; ensure navigation after rename uses relative path to avoid 404. * linter changes * add padding so field labels don't get cut off * fixes for keyboard accessibility and tooltips * don't show channel settings for DMs and GMs * chore(i18n): run extract to reorder new keys and fix CI Re-extracted webapp i18n to place newly added keys (editable tooltips and rename modal) in canonical order expected by translation tooling. * use generic_btn.cancel/save for rename modal buttons * chore(i18n): remove unused rename_channel.cancel/save keys * updated tests to account for new elements in the info rhs * add cypress test for new rhs info function * fix linting issues * fixed tests * linter fixes * tweak position of edit button * style tweaks, remove subtitle from info rhs head (redundant now), update archived state * added 'unarchive' button to archived notice, updated translations * fixed tests that I broke in channel info header * add url name to channel info view * update to 'channel handle' instead of url name' * change order of channel handle * add copy button * Update about_area_channel.test.tsx * fixed test and brought back channel subtitle in header for consistency * fixed header test * make channel info rhs scrollable * fix merge issue * Fix lint --------- Co-authored-by: yasserfaraazkhan <attitude3cena.yf@gmail.com>	2026-02-02 17:34:32 +00:00
sabril	981ff0bc46	MM-66362 feat: run e2e full tests after successful smoke tests both in cypress and playwright (#34868) ... * feat: run e2e full tests after successful smoke tests both in cypress and playwright * fix lint check on jsdoc req in playwright test * update smoke test filter * update test filter for cypress tests * update docker services, fix branch convention and rearrange secrets * update e2e-test workflow docs * reorganized * fix lint * fix playwright template * fix results assertion * add retest, e2e-test-verified, gh comments of failed tests, path filters, run e2e-tests check first and demote unstable tests * run using master image for e2e-only changes, add ts/js actions for cypress and playwright calculations, add verified by label --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-02-02 08:37:55 +08:00
Ben Cooke	36173a4948	Use one timeout config for requests to translation providers (#34957)	2026-01-29 10:00:22 -05:00
Dylan Haussermann	8e7b3da702	Fixtures that allow install of a plugin from a target repo (#34520) ... * Fixtures that allow install of a plugin from a target repo * Fixed linting error and applied `prettier` formating. * Implemeted feedback from code review * Remove unused AdminConfig import --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-27 21:41:49 +08:00
lindalumitchell	ace5810d65	Update file_preview.js (#35028) ... Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-27 05:50:08 +00:00
sabril	3db7477e45	MM-67281: (test) Migrate Enzyme to RTL (#35029) ... * test: migrate enzyme to rtl * replace renderWithIntl with renderWithContext * remove jest.clearAllMocks * use userEvent * fix unrelated lint error	2026-01-27 12:22:13 +08:00
Scott Bishel	c537b88f93	MM-65023 Add tooltip to actions buttons, display error (#33773) ... * Add tooltip support and error handling for action buttons - Add tooltip field to PostAction type definition - Display tooltips on hover for action buttons - Add comprehensive error handling for button actions - Show error messages when actions fail - Clear previous errors on subsequent actions - Add tests for error handling functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add E2E tests for action button error handling and tooltips - Test error message display when action buttons fail - Test error clearing when successful actions are performed - Test tooltip display on action button hover - Use scoped selectors to avoid test interference - Cover complete error lifecycle and tooltip functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Use WithTooltip component for action button tooltips Replace native HTML title attribute with WithTooltip component to provide consistent tooltip styling and behavior across the application. Changes: - Import and wrap ActionBtn with WithTooltip component - Remove title attribute from ActionBtn - Update E2E test to check for .tooltipContainer instead of title attribute 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix TypeScript errors and test patterns in message attachment tests - Fix TypeScript type errors in mock event objects by using arrow functions instead of jest.fn() - Update async test pattern to use process.nextTick() with done callback instead of await - Update test snapshots to reflect error handling wrapper div - Fix whitespace formatting in E2E test file 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * updated actionError to accept react node, replace hardcoded error with FormattedMessage components * Fix test to handle FormattedMessage in actionError state Update test expectation to check for FormattedMessage React element instead of plain string when no error message is provided. This aligns with the recent change to support internationalization in error messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Disable tooltip interactions when no tooltip text is present Adds disabled prop to WithTooltip component when action.tooltip is empty or undefined, preventing unnecessary tooltip event handlers from being attached to action buttons that don't have tooltips. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Add tests for action button tooltip behavior Adds three test cases to verify tooltip functionality: - Tooltip is disabled when action.tooltip is undefined - Tooltip is disabled when action.tooltip is empty string - Tooltip is enabled and displays correctly when action.tooltip has a value 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * fix e2e test --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-26 20:07:09 -07:00
Ben Cooke	a1c85007e1	Autotranslations MVP (#34696) ... --------- Co-authored-by: Elias Nahum <nahumhbl@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Nick Misasi <nick.misasi@mattermost.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Matthew Birtch <mattbirtch@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-26 17:05:34 -05:00
Matthew Birtch	09c4a61fed	[MM-67030] Remove newsletter signup and replace with terms/privacy agreement (#34801) ... * remove newsletter signup and replace with terms/privacy agreement * removed subscribeToSecurityNewsletter, made checkbox required * update signup test to remove newsletter and ensure the terms checkbox is required * update unit test and e2e test to reflect changes * fix e2e test * Removed susbcribe-newsletter endpoint in server * Update signup.test.tsx * remove unused css * remove unused css * fixed broken tests * fixed linter issues * Remove redundant IntlProvider and comments * Remove usage of test IDs from Signup tests * Remove usage of fireEvent * Remove usage of mountWithIntl from Signup tests * update e2e tests * fix playwright test * Fix Lint in signup.ts --------- Co-authored-by: maria.nunez <maria.nunez@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> Co-authored-by: yasserfaraazkhan <attitude3cena.yf@gmail.com>	2026-01-23 18:24:27 +00:00
sabril	66e5ab4c5e	E2E/Test Playwright upgrade (#35008) ... * chore: playwright upgrade * add luxon and chalk as dependency, and relax peer dependency to @playwright/test with >=1.55.0 --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-23 12:11:27 +08:00
Jesse Hallam	41e5c7286b	Remove vestigial MySQL support (#34865) ... * Remove legacy quoteColumnName() utility Since Mattermost only supports PostgreSQL, the quoteColumnName() helper that was designed to handle database-specific column quoting is no longer needed. The function was a no-op that simply returned the column name unchanged. Remove the function from utils.go and update status_store.go to use the "Manual" column name directly. * Remove legacy driver checks from store.go Since Mattermost only supports PostgreSQL, remove conditional checks for different database drivers: - Simplify specialSearchChars() to always return PostgreSQL-compatible chars - Remove driver check from computeBinaryParam() - Remove driver check from computeDefaultTextSearchConfig() - Simplify GetDbVersion() to use PostgreSQL syntax directly - Remove switch statement from ensureMinimumDBVersion() - Remove unused driver parameter from versionString() * Remove MySQL alternatives for batch delete operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific DELETE...LIMIT syntax and keep only the PostgreSQL array-based approach: - reaction_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - file_info_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - preference_store.go: Use PostgreSQL tuple IN subquery for DeleteInvalidVisibleDmsGms * Remove MySQL alternatives for UPDATE...FROM syntax Since Mattermost only supports PostgreSQL, remove the MySQL-specific UPDATE syntax that joins tables differently: - thread_store.go: Use PostgreSQL UPDATE...FROM syntax in MarkAllAsReadByChannels and MarkAllAsReadByTeam - post_store.go: Use PostgreSQL UPDATE...FROM syntax in deleteThreadFiles * Remove MySQL alternatives for JSON and subquery operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific JSON and subquery syntax: - thread_store.go: Use PostgreSQL JSONB operators for updating participants - access_control_policy_store.go: Use PostgreSQL JSONB @> operator for querying JSON imports - session_store.go: Use PostgreSQL subquery syntax for Cleanup - job_store.go: Use PostgreSQL subquery syntax for Cleanup * Remove MySQL alternatives for CTE queries Since Mattermost only supports PostgreSQL, simplify code that uses CTEs (Common Table Expressions): - channel_store.go: Remove MySQL CASE-based fallback in UpdateLastViewedAt and use PostgreSQL CTE exclusively - draft_store.go: Remove driver checks in DeleteEmptyDraftsByCreateAtAndUserId, DeleteOrphanDraftsByCreateAtAndUserId, and determineMaxDraftSize * Remove driver checks in migrate.go and schema_dump.go Simplify migration code to use PostgreSQL driver directly since PostgreSQL is the only supported database. * Remove driver checks in sqlx_wrapper.go Always apply lowercase named parameter transformation since PostgreSQL is the only supported database. * Remove driver checks in user_store.go Simplify user store functions to use PostgreSQL-only code paths: - Remove isPostgreSQL parameter from helper functions - Use LEFT JOIN pattern instead of subqueries for bot filtering - Always use case-insensitive LIKE with lower() for search - Remove MySQL-specific role filtering alternatives * Remove driver checks in post_store.go Simplify post_store.go to use PostgreSQL-only code paths: - Inline getParentsPostsPostgreSQL into getParentsPosts - Use PostgreSQL TO_CHAR/TO_TIMESTAMP for date formatting in analytics - Use PostgreSQL array syntax for batch deletes - Simplify determineMaxPostSize to always use information_schema - Use PostgreSQL jsonb subtraction for thread participants - Always execute RefreshPostStats (PostgreSQL materialized views) - Use materialized views for AnalyticsPostCountsByDay - Simplify AnalyticsPostCountByTeam to always use countByTeam * Remove driver checks in channel_store.go Simplify channel_store.go to use PostgreSQL-only code paths: - Always use sq.Dollar.ReplacePlaceholders for UNION queries - Use PostgreSQL LEFT JOIN for retention policy exclusion - Use PostgreSQL jsonb @> operator for access control policy imports - Simplify buildLIKEClause to always use LOWER() for case-insensitive search - Simplify buildFulltextClauseX to always use PostgreSQL to_tsvector/to_tsquery - Simplify searchGroupChannelsQuery to use ARRAY_TO_STRING/ARRAY_AGG * Remove driver checks in file_info_store.go Simplify file_info_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL to_tsvector/to_tsquery for file search - Use file_stats materialized view for CountAll() - Use file_stats materialized view for GetStorageUsage() when not including deleted - Always execute RefreshFileStats() for materialized view refresh * Remove driver checks in attributes_store.go Simplify attributes_store.go to use PostgreSQL-only code paths: - Always execute RefreshAttributes() for materialized view refresh - Remove isPostgreSQL parameter from generateSearchQueryForExpression - Always use PostgreSQL LOWER() LIKE LOWER() syntax for case-insensitive search * Remove driver checks in retention_policy_store.go Simplify retention_policy_store.go to use PostgreSQL-only code paths: - Remove isPostgres parameter from scanRetentionIdsForDeletion - Always use pq.Array for scanning retention IDs - Always use pq.Array for inserting retention IDs - Remove unused json import * Remove driver checks in property stores Simplify property_field_store.go and property_value_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL type casts (::text, ::jsonb, ::bigint, etc.) - Remove isPostgres variable and conditionals * Remove driver checks in channel_member_history_store.go Simplify PermanentDeleteBatch to use PostgreSQL-only code path: - Always use ctid-based subquery for DELETE with LIMIT * Remove remaining driver checks in user_store.go Simplify user_store.go to use PostgreSQL-only code paths: - Use LEFT JOIN for bot exclusion in AnalyticsActiveCountForPeriod - Use LEFT JOIN for bot exclusion in IsEmpty * Simplify fulltext search by consolidating buildFulltextClause functions Remove convertMySQLFullTextColumnsToPostgres and consolidate buildFulltextClause and buildFulltextClauseX into a single function that takes variadic column arguments and returns sq.Sqlizer. * Simplify SQL stores leveraging PostgreSQL-only support - Simplify UpdateMembersRole in channel_store.go and team_store.go to use UPDATE...RETURNING instead of SELECT + UPDATE - Simplify GetPostReminders in post_store.go to use DELETE...RETURNING - Simplify DeleteOrphanedRows queries by removing MySQL workarounds for subquery locking issues - Simplify UpdateUserLastSyncAt to use UPDATE...FROM...RETURNING instead of fetching user first then updating - Remove MySQL index hint workarounds in ORDER BY clauses - Update outdated comments referencing MySQL - Consolidate buildFulltextClause and remove convertMySQLFullTextColumnsToPostgres * Remove MySQL-specific test artifacts - Delete unused MySQLStopWords variable and stop_word.go file - Remove redundant testSearchEmailAddressesWithQuotes test (already covered by testSearchEmailAddresses) - Update comment that referenced MySQL query planning * Remove MySQL references from server code outside sqlstore - Update config example and DSN parsing docs to reflect PostgreSQL-only support - Remove mysql:// scheme check from IsDatabaseDSN - Simplify SanitizeDataSource to only handle PostgreSQL - Remove outdated MySQL comments from model and plugin code * Remove MySQL references from test files - Update test DSNs to use PostgreSQL format - Remove dead mysql-replica flag and replicaFlag variable - Simplify tests that had MySQL/PostgreSQL branches * Update docs and test config to use PostgreSQL - Update mmctl config set example to use postgres driver - Update test-config.json to use PostgreSQL DSN format * Remove MySQL migration scripts, test data, and docker image Delete MySQL-related files that are no longer needed: - ESR upgrade scripts (esr.*.mysql.*.sql) - MySQL schema dumps (mattermost-mysql-*.sql) - MySQL replication test scripts (replica-*.sh, mysql-migration-test.sh) - MySQL test warmup data (mysql_migration_warmup.sql) - MySQL docker image reference from mirror-docker-images.json * Remove MySQL references from webapp - Simplify minimumHashtagLength description to remove MySQL-specific configuration note - Remove unused HIDE_MYSQL_STATS_NOTIFICATION preference constant - Update en.json i18n source file * clean up e2e-tests * rm server/tests/template.load * Use teamMemberSliceColumns() in UpdateMembersRole RETURNING clause Refactor to use the existing helper function instead of hardcoding the column names, ensuring consistency if the columns are updated. * u.id -> u.Id * address code review feedback --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-20 21:01:59 +00:00
sabril	3ebc90bde0	fix: E2E/Tests related to create account and invite people (#34953) ... * fix: e2e tests related to create account and invite people * fix failed test	2026-01-20 11:59:47 -04:00
sabril	0a12ca2f7d	E2E/Playwright: Reorganize user and team creation (#34912) ... * pw: reorganize user and team creation * fix types and lint	2026-01-16 13:11:27 +08:00
Christopher Poile	38b413a276	MM-67077: Remove PSD file previews (#34898) ... * remove image preview support for PSD files * remove psd as a supported image type in webapp * remove unneeded comments	2026-01-15 13:39:46 -05:00
Nick Misasi	0885f56010	Add optional Claude.md orchestration for Webapp folder (#34668) ... * Add CLAUDE.md documentation files for webapp directories - Add root webapp CLAUDE.md with overview and build commands - Add channels CLAUDE.md with architecture and testing info - Add documentation for actions, components, selectors, utils - Add documentation for sass, tests, and mattermost-redux - Add platform documentation for client and types - Update .gitignore * Add CLAUDE docs and allow tracking * Clarify CLAUDE instructions for i18n workflow * Refactor webapp/CLAUDE.md into a nested hierarchy Decomposed the monolithic webapp/CLAUDE.md into focused, context-aware files distributed across the directory structure: - webapp/CLAUDE.md (Root overview) - webapp/channels/CLAUDE.md (Channels workspace) - webapp/channels/src/components/CLAUDE.md - webapp/channels/src/actions/CLAUDE.md - webapp/channels/src/selectors/CLAUDE.md - webapp/channels/src/packages/mattermost-redux/CLAUDE.md - webapp/platform/CLAUDE.md (Platform workspace) - webapp/platform/client/CLAUDE.md * Move files to optional, then add script to move them to proper claud.md	2026-01-14 13:04:20 -05:00
Scott Bishel	cc2b47bc9b	MM-66561 Add distinct archive icon for private channels (#34736) ... * MM-66561 Add distinct archive icon for private channels Archived private channels now display an archive-lock icon instead of the standard archive icon to better indicate their original privacy level. Implemented utility functions to centralize icon selection logic across all channel list views, sidebars, headers, and suggestion providers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * MM-66561 Fix linting and TypeScript errors Fix ESLint and TypeScript issues introduced in the archive icon implementation: - Remove extra blank lines to comply with no-multiple-empty-lines rule - Remove unused container variables in test files - Fix import order to comply with import/order rule - Remove unused React import - Fix TypeScript type errors by using General.OPEN_CHANNEL/PRIVATE_CHANNEL from mattermost-redux/constants which preserves literal types 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * MM-66561 Fix test failures for archive icon changes Update test snapshots and fix test data issues related to the new distinct archive icons for public and private channels. - Update snapshots for channel list components to include new channelType prop and data-testid attributes - Fix channel_mention_provider test by preserving actual module exports in mock - Add missing purpose field to searchable_channel_list test data - Fix async state handling in new_channel_modal test using waitFor instead of act 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * MM-66561 Fix remaining Cypress E2E test failures for archive icons Fix three failing Cypress tests related to archive icon changes: 1. join_archived_channel_spec.ts (MM-T1682, MM-T1683) - Add data-testid to archive icon in channel header - Update test to use findByTestId instead of CSS class selector - Compass icon components render as SVG, not <i> with classes 2. archived_channels_spec.js (system console tests) - Add "000-" prefix to private channel name/display name - Ensures proper alphabetical sorting on first page of results 3. long_draft_spec.js (MM-T211) - Fix Cypress alias timing issues in nested then() callbacks - Use local variable to track height changes during iteration - Replace cy.get('@alias').should() with direct expect() assertions All tests now pass with the distinct archive icons for private channels. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * fix lint issue * MM-66561 Refine archive icon styling and search results display - Restore CSS classes on channel header icon for proper color and size - Fix icon alignment by removing top offset in channel header context - Replace "Archived" text with icon-only tooltip in search results - Add context-specific styling to prevent conflicts between header and search 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * tweaks to css and move withtooltip to wrap the span * lint fix * lint fix * Fix archived channel icons visual test API usage Update test to use correct Playwright API patterns: - Use adminClient.createChannel with pw.random.channel for channel creation - Use adminClient.deleteChannel instead of pw.apiClient.deleteChannel - Use pw.testBrowser.login(adminUser) instead of loginAsAdmin - Remove channelsPage.toBeVisible check for archived channels since they lack post-create element Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Apply prettier formatting to archived channel icons test Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Fix timing issue in MM-T633 Elasticsearch webhook attachment search test The test was intermittently failing because it searched immediately after posting the webhook, before Elasticsearch had time to index the new post. Added explicit wait for post to appear and increased indexing wait time to 3 seconds to ensure the attachment text is indexed before performing the search. Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> Co-authored-by: Matthew Birtch <mattbirtch@gmail.com>	2026-01-14 15:35:27 +00:00
sabril	dab04576a1	MM-66972 Upgrade to node 24 and main dependencies with babel, webpack and jest (#34760) ... * chore: upgrade to node 24 and dependencies mainly with babel, webpack and jest * fix components tests, make trial modal passed on all node 20-24 * fix cache for platform packages * updated test --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-14 13:14:01 +08:00
Caleb Roseland	db55f9fa43	MM-66653: migrate i18n extraction from mmjstool to @formatjs/cli (#34498) ... * feat(webapp): migrate i18n extraction from mmjstool to @formatjs/cli Replace custom mmjstool with industry-standard @formatjs/cli for i18n message extraction. Adds support for localizeMessage as a recognized extraction function and enables comprehensive ESLint rules for i18n. Changes by area: Dependencies (package.json): - Add @formatjs/cli v6.7.4 - Remove @mattermost/mmjstool dependency - Replace i18n-extract script with formatjs command - Remove mmjstool-specific scripts (clean-empty, check-empty-src) - Add i18n-extract:check for diff validation Code (utils.tsx): - Refactor localizeMessage to accept MessageDescriptor format - Support {id, defaultMessage, description} parameters - Maintain Redux store access (non-React context compatible) - Add comprehensive JSDoc documentation Linting (.eslintrc.json): - Configure formatjs settings with additionalFunctionNames - Enable 9 formatjs ESLint rules including enforce-id (error) - Ensure all messages require explicit manual IDs CI/CD (webapp-ci.yml): - Simplify i18n check to formatjs extraction + diff - Remove mmjstool and mobile-dir references Context: Second attempt at PR #25830. Uses manual IDs only with [id] placeholder pattern to enforce explicit ID requirements. ESLint will catch missing IDs during development. * chore(webapp): add temporary i18n reconciliation tooling Add helper script to analyze conflicts between en.json and defaultMessage values in code. This tooling will be reverted after initial migration cleanup is complete. Tooling added: - scripts/i18n-reconcile-conflicts.js: Analyzes conflicts - Detects spelling corrections - Identifies placeholder mismatches - Flags significant content changes - Provides recommendations on which version to keep - npm script: i18n-reconcile Usage: npm run i18n-reconcile This will be reverted after reconciling the ~50 duplicate message warnings and determining correct versions for conflicting messages. * chore(webapp): upgrade eslint-plugin-formatjs and centralize formatjs deps Move @formatjs/cli to root webapp package.json alongside other formatjs dependencies for better monorepo organization. Upgrade eslint-plugin-formatjs from 4.12.2 to 5.4.2 for latest features and bug fixes. Changes: - Upgrade eslint-plugin-formatjs: 4.12.2 → 5.4.2 - Move @formatjs/cli to webapp/package.json (from channels) - Centralize formatjs tooling at monorepo root level This provides: - Better dependency management in monorepo - Latest formatjs ESLint rules and features - Consistent tooling across workspaces * feat(webapp): make localizeMessage fully compatible with formatMessage API Extend localizeMessage to accept a values parameter for placeholder interpolation, making it fully compatible with react-intl's formatMessage API. Remove the now-redundant localizeAndFormatMessage function. Changes to localizeMessage: - Add values parameter for {placeholder} interpolation - Use getIntl() for proper ICU message formatting - Support full formatMessage feature parity outside React contexts - Update JSDoc with interpolation examples - Mark as deprecated (prefer useIntl in React components) Code cleanup: - Remove localizeAndFormatMessage function (redundant) - Migrate all localizeAndFormatMessage usages to localizeMessage - Remove unused imports: getCurrentLocale, getTranslations - Add getIntl import Files migrated: - notification_actions.tsx: notification.crt message - app_command_parser_dependencies.ts: intlShim formatMessage This consolidates i18n logic and provides a single, feature-complete localization function for non-React contexts. Example usage: // Before (old function) localizeAndFormatMessage( {id: 'welcome', defaultMessage: 'Hello {name}'}, {name: 'John'} ) // After (consolidated) localizeMessage( {id: 'welcome', defaultMessage: 'Hello {name}'}, {name: 'John'} ) * refactor(i18n): remove intlShim abstraction, use IntlShape directly Remove intlShim wrapper and use react-intl's IntlShape type throughout. Key Changes: - Remove intlShim constant from app_command_parser_dependencies.ts - Update errorMessage() signature to accept IntlShape parameter - Use IntlShape for intl properties in AppCommandParser and ParsedCommand - Call getIntl() at function start in actions (command.ts, marketplace.ts) - Pass IntlShape to AppCommandParser and doAppSubmit consistently Files Modified: - app_command_parser_dependencies.ts: Remove intlShim, update errorMessage - app_command_parser.ts: Use IntlShape type - command.ts, marketplace.ts: Call getIntl() early, pass to parser - app_provider.tsx, command_provider.tsx: Use getIntl() in constructor - apps.ts: Update doAppSubmit signature Benefits: Better type safety, standard react-intl patterns, eliminates unnecessary abstraction. Context: Part of migration to @formatjs/cli tooling. * refactor(webapp): remove deprecated t() function and refactor login validation Remove the deprecated t() function that was used as a marker for the old mmjstool extraction. With @formatjs/cli, this is no longer needed as extraction happens directly from formatMessage calls. Changes: - Remove t() function definition from utils/i18n.tsx - Remove t() import and marker calls from login.tsx - Refactor login validation logic from multiple if statements to a clean switch(true) pattern that evaluates boolean combinations directly - Add helpful comments documenting the structure of login method combinations - Add default case as safety fallback The switch(true) pattern eliminates the need to build a key string and makes the login method combination logic clearer and more maintainable. Prompt: Remove deprecated t() translation marker function used by old mmjstool. Refactor login validation from if blocks to switch(true) with boolean cases. * refactor(i18n): share IntlProvider's intl instance with getIntl() Make getIntl() return the same IntlShape instance that IntlProvider creates, ensuring consistency between React components (using useIntl()) and non-React contexts (using getIntl()). Changes: - Add intlInstance storage in utils/i18n.tsx - Export setIntl() function to store the intl instance - Modify getIntl() to return stored instance if available, with fallback to createIntl() for tests and early initialization - Add IntlCapture component in IntlProvider that uses useIntl() hook to capture and store the intl instance via setIntl() Benefits: - Single source of truth: Both React and non-React code use the same IntlShape - Consistent translations: No duplicate translation loading or potential desync - Leverages IntlProvider's translation loading lifecycle automatically - Maintains fallback for edge cases where IntlProvider hasn't mounted yet Prompt: Refactor getIntl() to reuse IntlProvider's intl instance instead of creating a separate instance, ensuring both React and non-React contexts use the same translations and intl configuration. * 1 * exclude test files * reset en.json * refactor(i18n): inline message ID constants for formatjs extraction Replace dynamic ID references with literal strings to enable proper formatjs extraction. Formatjs can only extract from static message IDs, not from variables or computed IDs. Changes: - configuration_bar.tsx: Inline AnnouncementBarMessages constants to literal string IDs ('announcement_bar.error.past_grace', 'announcement_bar.error.preview_mode') - system_analytics.test.tsx: Replace variable IDs (totalPlaybooksID, totalPlaybookRunsID) with literal strings ('total_playbooks', 'total_playbook_runs') - password.tsx: Use full message descriptor from passwordErrors object instead of dynamic ID with hardcoded defaultMessage. The errorId is still built dynamically using template strings, but the actual message is looked up from the passwordErrors defineMessages block where formatjs can extract it. This eliminates all "[id]" placeholder entries from extraction output and ensures all messages have proper extractable definitions. Prompt: Fix dynamic message ID references that formatjs extraction can't parse. Inline constants and use message descriptor lookups to enable clean extraction without [id] placeholders. * fix(i18n): add missing defaultMessage to drafts.tooltipText The drafts.tooltipText FormattedMessage had an empty defaultMessage, causing formatjs extraction to output an empty string for this message. Added the proper defaultMessage with plural formatting for draft and scheduled post counts. Prompt: Fix empty defaultMessage in drafts tooltip causing extraction issues. * feat(i18n): add --preserve-whitespace flag to formatjs extraction Add the --preserve-whitespace flag to ensure formatjs extraction maintains exact whitespace from defaultMessage values. This is important for messages with intentional formatting like tabs, multiple spaces, or line breaks. Prompt: Add --preserve-whitespace to i18n extraction to maintain exact formatting. * feat(i18n): add custom formatjs formatter matching mmjstool ordering Create custom formatter that replicates mmjstool's sorting behavior: - Case-insensitive alphabetical sorting - Underscore (_) sorts before dot (.) to match existing en.json ordering - Simple key-value format (extracts defaultMessage) The underscore-before-dot collation matches mmjstool's actual behavior and reduces diff size by 50% compared to standard alphabetical sorting. Changes: - scripts/formatter.js: Custom compareMessages, format, and compile functions - package.json: Use --format scripts/formatter.js instead of --format simple Prompt: Create custom formatjs formatter matching mmjstool's exact sorting behavior including underscore-before-dot collation to minimize migration diff. * feat(i18n): enhance reconciliation script with git history metadata Add git log lookups to show when each message was last modified in both en.json and code files. This enables data-driven decisions about which version to keep when resolving conflicts. Enhancements: - getEnJsonLastModified(): Find when an en.json entry last changed - findCodeFile(): Locate source file for a message ID (handles id= and id:) - getCodeLastModified(): Get last modification date for source files - Caching for performance (minimizes git operations) Output includes: 📅 en.json: [date] | [hash] | [commit message] 📅 code: [date] | [hash] | [commit message] 📂 file: [source file path] Analysis shows en.json entries from 2023 while code actively updated 2024-2025, indicating code is more authoritative. Prompt: Add git history to reconciliation report showing modification dates for data-driven conflict resolution decisions. * feat(i18n): add optional duplicate message ID check script Add i18n-extract:check-duplicates script that fails if the same message ID has different defaultMessages in multiple locations. This is kept as an optional standalone script rather than auto-chained with i18n-extract to allow the migration to proceed while duplicates are addressed separately. Usage: npm run i18n-extract:check-duplicates The script runs formatjs extract to /dev/null and checks stderr for "Duplicate message id" warnings, failing if any are found. Prompt: Add optional duplicate ID check as standalone npm script for gradual migration without blocking on existing duplicate message IDs. * about.enterpriseEditionLearn * admin.accesscontrol.title * eslint-plugin-formatjs version to eslint 8 compat * admin.channel_settings.channel_detail.access_control_policy_title * admin.connectionSecurityTls - now: admin.connectionSecurityTls.title * admin.customProfileAttribDesc now: - admin.customProfileAttribDesc.ldap - admin.customProfileAttribDesc.saml * admin.gitlab.clientSecretExample * package-lock * admin.google.EnableMarkdownDesc - fix err `]` in admin.google.EnableMarkdownDesc.openid - now: - admin.google.EnableMarkdownDesc.oauth - admin.google.EnableMarkdownDesc.openid * admin.image.amazonS3BucketExample - now: - admin.image.amazonS3BucketExample - admin.image.amazonS3BucketExampleExport * admin.license.trialCard.contactSales * admin.log.AdvancedLoggingJSONDescription - now: - admin.log.AdvancedLoggingJSONDescription - admin.log.AdvancedAuditLoggingJSONDescription * admin.rate.noteDescription - now - admin.rate.noteDescription - admin.info_banner.restart_required.desc (3) * admin.system_properties.user_properties.title - now: - admin.system_properties.user_properties.title - admin.accesscontrol.user_properties.link.label * admin.system_users.filters.team.allTeams, admin.system_users.filters.team.noTeams * admin.user_item.email_title * announcement_bar.error.preview_mode * channel_settings.error_purpose_length * deactivate_member_modal.desc - now: - deactivate_member_modal.desc - deactivate_member_modal.desc_with_confirmation * deleteChannelModal.canViewArchivedChannelsWarning * edit_channel_header_modal.error * filtered_channels_list.search - now: - filtered_channels_list.search - filtered_channels_list.search.label * flag_post.flag * generic_icons.collapse * installed_outgoing_oauth_connections.header * intro_messages.group_message * intro_messages.notificationPreferences - now: - intro_messages.notificationPreferences - intro_messages.notificationPreferences.label * katex.error * multiselect.placeholder - now: - multiselect.placeholder - multiselect.placeholder.addMembers * post_info.pin, post_info.unpin, rhs_root.mobile.flag take en.json * texteditor.rewrite.rewriting * user_groups_modal.addPeople split to user_groups_modal.addPeople.field_title * user.settings.general.validImage take en.json * userSettings.adminMode.modal_header take en.json * webapp.mattermost.feature.start_call split to user_profile.call.start * admin.general.localization.enableExperimentalLocalesDescription take en.json * login.contact_admin.title, login.contact_admin.detail take en.json * fix: correct spelling of "complementary" in accessibility sections * Revert "about.enterpriseEditionLearn" This reverts commit 23ababe1ce. * about.enterpriseEditionLearn, about.planNameLearn * fix: improve clarity and consistency in activity log and command descriptions * fix: update emoji upload limits and improve help text for emoji creation * fix easy round 1 * fix: improve messaging for free trial notifications and sales contact take en.json * admin.billing.subscription.planDetails.features.limitedFileStorage take en.json * admin.billing.subscription.updatePaymentInfo take en.json * fix easy round 2 * admin.complianceExport.exportFormat.globalrelay take en.json * fix round 3 * fix round 4 * fix round 5 * fix round 6 * fix closing tag, newlines, and popout title * fix linting, + * update snapshots * test(webapp): update tests to match formatjs migration message changes Update test assertions to reflect message text changes from the mmjstool → @formatjs/cli migration. All changes align with the corresponding i18n message updates in the codebase. Changes: - limits.test.tsx: Update capitalization (Message History → Message history, File Storage → File storage) - emoji_picker.test.tsx: Update label (Recent → Recently Used) - command.test.js: Add period to error message - channel_activity_warning_modal.test.tsx: Update warning text assertion - channel_settings_archive_tab.test.tsx: Update archive warning text - feature_discovery.test.tsx: Update agreement name (Software and Services License Agreement → Software Evaluation Agreement) - flag_post_modal.test.tsx: Update placeholder text (Select a reason for flagging → Select a reason) - channel_intro_message.test.tsx: Remove trailing space from assertion - elasticsearch_settings.tsx: Fix searchableStrings placeholder names (documentationLink → link) to match updated message format All 983 test suites passing (12 tests fixed, 9088 tests total). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(i18n): improve cross-platform compatibility and cleanup temporary tooling Simplify i18n check scripts to reuse npm run i18n-extract, improving cross-platform compatibility and reducing duplication. Changes: - Refactor i18n-extract:check to reuse base extraction command - Uses project-local temp file instead of /tmp (Windows compatible) - Simplified from duplicated formatjs command to npm run reuse - Add --throws flag to fail fast on extraction errors - Add helpful error message: "To update: npm run i18n-extract" - Add i18n-extract:check to main check script - Now runs alongside ESLint and Stylelint checks - Ensures en.json stays in sync with code changes - Remove i18n-extract:check-duplicates script - Redundant - duplicates are caught by i18n-extract automatically - Avoided grep dependency (not cross-platform) - Remove temporary reconciliation tooling - Deleted scripts/i18n-reconcile-conflicts.js (served its purpose) - Removed i18n-reconcile npm script - Add .i18n-check.tmp.json to .gitignore i18n-extract:check now works on Windows, macOS, and Linux. Requires only diff command (available via Git on Windows). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * ci(webapp): simplify i18n check using npm script Replace custom i18n check in CI with npm run i18n-extract:check for consistency with local development workflow. Changes: - Update check-i18n job to use npm run i18n-extract:check - Remove manual cp/extract/diff steps (3 lines → 1 line) - Consistent behavior between CI and local development - Cross-platform compatible (no /tmp dependency) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(i18n): add i18n extraction targets to Makefile and workspace scripts Add Make targets and npm workspace scripts for i18n message extraction to provide consistent tooling access across the project. Changes: - Add make i18n-extract target to webapp/Makefile - Extracts i18n messages from code to en.json - Add make i18n-extract-check target to webapp/Makefile - Checks if en.json is in sync with code - Add i18n-extract workspace script to webapp/package.json - Runs extraction across all workspaces - Add i18n-extract:check workspace script to webapp/package.json - Runs sync check across all workspaces Usage: make i18n-extract # Extract messages make i18n-extract-check # Check if en.json needs update npm run i18n-extract # From webapp root npm run i18n-extract:check 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(i18n): add cross-platform cleanup utility for temp files Add Node.js cleanup script to handle temporary file removal in a cross-platform manner, replacing platform-specific rm commands. Changes: - Add webapp/scripts/cleanup.js - Cross-platform file deletion utility - Silently handles missing files - Works on Windows/Mac/Linux - Update i18n-extract:check to use cleanup script - Removes .i18n-check.tmp.json after diff - Cleans up on both success and failure paths Usage: node scripts/cleanup.js <file1> [file2] [...] 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(i18n): remove 'defineMessage' from additionalFunctionNames in ESLint config * chore(i18n): update i18n-extract check script and remove unused cleanup utility context: WSL is already required on windows * chore(i18n): remove ESLint rule disabling for formatjs placeholders in admin definition * chore(i18n): admin_definition - re-add defineMessage to eslint additionalfunctionnames - mark additional individual placeholder lines in admin_definition * fix(i18n): correct typo in enterprise edition link message * chore(i18n): fix escape sequences * revert emoji.ts changes * fix snapshots * fix admin.google.EnableMarkdownDesc - keep en.json but fix linkAPI and <strong>Create</strong> * restore newlines, and final corrections check * update snapshots * fix: i18n * chore(e2e): admin.complianceExport.exportJobStartTime.title * chore(e2e): emoji_picker.travel-places * chore(e2e): user.settings.general.incorrectPassword * chore(e2e): signup_user_completed.create * chore(e2e): fix Invite People * chore(fix): admin console email heading * chore(e2e): fix edit_channel_header_modal.placeholder * chore(e2e): fix Create account * chore(e2e): fix Create account * chore(e2e): correct success message text in password update alert * fix: admin guide label * chore(e2e): update role name in invite people combobox * chore(e2e): more "Create account" * chore(e2e): fix authentication_spec * lint --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-12 17:22:04 -06:00
M-ZubairAhmed	43bab4d7c7	[MM-67025] Add new E2E for testing keyboard shortcut Shift+Up (#34793) ... * add e2e test for Shift+Up keyboard shortcut in center channel * Update dependencies in package-lock.json * Update package-lock.json * Update package-lock.json --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-12 13:01:14 +08:00
sabril	0b0658bdd0	chore: upgrade playwright to 1.57 and its dependencies (#34769) ... * chore: upgrade playwright to 1.57 and its dependencies * bump webapp's npm to accept ^11.0.0 * updated per comment * fix failed tests	2026-01-09 10:48:19 +08:00
Joram Wilander	d844530496	Fix copyright date and address for email footers (#34813) ... * Fix copyright date and address for email footers * Update footer for email template	2026-01-05 13:59:37 -05:00
Pablo Vélez	1a21d34aab	MM-66925 - improve user email and password modals (#34739) ... * MM-66925 - improve user email and password modals * adjust error modal styling * adjust e2e tests	2025-12-19 15:52:59 +01:00
Pablo Vélez	b998f8c6e8	remove 'only' from Main Post Input accessibility test (#34799)	2025-12-18 17:30:35 +01:00
Pablo Vélez	e0052be9c3	MM-66890 - Set default for BurnOnRead feature flag to true (#34763) ... * MM-66890 - Set default for BurnOnRead feature flag to true * enable the feature by default * fix unit tests * fix e2e tests --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-12-18 09:39:44 +01:00
sabril	d7aebb555d	fix flaky notifications tests and migrated to playwright (#34449) ... Co-authored-by: Mattermost Build <build@mattermost.com>	2025-12-17 06:51:20 +00:00
Ibrahim Serdar Acikgoz	084006c0ea	[MM-61758] Burn on read feature (#34703) ... * Add read receipt store for burn on read message types * update mocks * fix invalidation target * have consistent case on index creation * Add temporary posts table * add mock * add transaction support * reflect review comments * wip: Add reveal endpoint * user check error id instead * wip: Add ws events and cleanup for burn on read posts * add burn endpoint for explicitly burning messages * add translations * Added logic to associate files of BoR post with the post * Added test * fixes * disable pinning posts and review comments * MM-66594 - Burn on read UI integration (#34647) * MM-66244 - add BoR visual components to message editor * MM-66246 - BoR visual indicator for sender and receiver * MM-66607 - bor - add timer countdown and autodeletion * add the system console max time to live config * use the max expire at and create global scheduler to register bor messages * use seconds for BoR config values in BE * implement the read by text shown in the tooltip logic * unestack the posts from same receiver and BoR and fix styling * avoid opening reply RHS * remove unused dispatchers * persis the BoR label in the drafts * move expiration value to metadata * adjust unit tests to metadata insted of props * code clean up and some performance improvements; add period grace for deletion too * adjust migration serie number * hide bor messages when config is off * performance improvements on post component and code clean up * keep bor existing post functionality if config is disabled * Add read receipt store for burn on read message types * Add temporary posts table * add transaction support * reflect review comments * wip: Add reveal endpoint * user check error id instead * wip: Add ws events and cleanup for burn on read posts * avoid reacting to unrevealed bor messages * adjust migration number * Add read receipt store for burn on read message types * have consistent case on index creation * Add temporary posts table * add mock * add transaction support * reflect review comments * wip: Add reveal endpoint * user check error id instead * wip: Add ws events and cleanup for burn on read posts * add burn endpoint for explicitly burning messages * adjust post reveal and type with backend changes * use real config values, adjust icon usage and style * adjust the delete from from sender and receiver * improve self deleting logic by placing in badge, use burn endpoint * adjust websocket events handling for the read by sender label information * adjust styling for concealed and error state * update burn-on-read post event handling for improved recipient tracking and multi-device sync * replace burn_on_read with type in database migrations and model * remove burn_on_read metadata from PostMetadata and related structures * Added logic to associate files of BoR post with the post * Added test * adjust migration name and fix linter * Add read receipt store for burn on read message types * update mocks * have consistent case on index creation * Add temporary posts table * add mock * add transaction support * reflect review comments * wip: Add reveal endpoint * user check error id instead * wip: Add ws events and cleanup for burn on read posts * add burn endpoint for explicitly burning messages * Added logic to associate files of BoR post with the post * Added test * disable pinning posts and review comments * show attachment on bor reveal * remove unused translation * Enhance burn-on-read post handling and refine previous post ID retrieval logic * adjust the returning chunk to work with bor messages * read temp post from master db * read from master * show the copy link button to the sender * revert unnecessary check * restore correct json tag * remove unused error handling and clarify burn-on-read comment * improve type safety and use proper selectors * eliminate code duplication in deletion handler * optimize performance and add documentation * delete bor message for sender once all receivers reveal it * add burn on read to scheduled posts * add feature enable check * use master to avoid all read recipients race condition --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> * squash migrations into single file * add configuration for the scheduler * don't run messagehasbeenposted hook * remove parallel tests on burn on read * add clean up for closing opened modals from previous tests * simplify delete menu item rendering * add cleanup step to close open modals after each test to prevent pollution * streamline delete button visibility logic for Burn on Read posts * improve reliability of closing post menu and modals by using body ESC key --------- Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Pablo Vélez <pablovv2012@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2025-12-11 07:59:50 +01:00
Harrison Healey	09fc02f72c	Fix flaky test in accessibility_modals_dialogs_spec.ts (#34689)	2025-12-10 16:14:29 -05:00
Elias Nahum	4589005a54	feat: Add Microsoft Intune MAM authentication support (#34577) ... * Add Entra ID token authentication and Intune MAM config exposure * Add Intune MAM toggle to Mobile Security admin console * Add IntuneSettings with the AuthService to use and its own TenantID andClientID for the Entra App registration Include Admin console changes switch from /oauth/entra to /oauth/intune endpoint * openAPI documentation --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: yasser khan <attitude3cena.yf@gmail.com>	2025-12-10 08:31:53 +02:00
M-ZubairAhmed	4fb41f3ba2	[MM-65186] Keyboard focus is wrong when using Shift-Up to reply in thread (#34627)	2025-12-10 04:53:31 +00:00
Jesse Hallam	1b064a79ca	MM-66470: Remove CRT tutorial screens (#34433) ... * MM-66470: Remove CRT tutorial screens Remove CRT tutorial that was appearing for new users even when tutorials are disabled. The tutorial has served its purpose since CRT was released and is now causing issues for new users. Fixes: https://mattermost.atlassian.net/browse/MM-66470 * Fix E2E test after CRT tutorial removal Remove interaction with #tipNextButton that no longer exists after the CRT tutorial screens were removed. --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-12-10 01:00:41 +00:00
Harrison Healey	5341b91566	MM-66659/MM-66832 Remove caretPosition state from AdvancedTextEditor (#34643) ... * Mock react-virtualized-auto-sizer in all unit tests to ensure contents are mounted Without mocking that, anything inside of an `AutoSizer` wouldn't be rendered at all, leading to weird behaviour like the emoji picker being empty in tests. * Fix EmojiPickerCategoryRow not having a defaultMessage This caused any unit tests involving the emoji picker to error unless you also provided an intlMessages object which is hard to do due to how Jest's `moduleNameMapper` option is configured currently. * Fixed incorrect usage of useCallback in EmojiPickerItem The way this was previously written, we weren't specifying dependencies properly for those callbacks which lead to some actual performance issues because of how heavy the emoji picker is, and it also lead to issues where click handlers would have to be triggered multiple times in unit tests for some reason. * MM-66659 Stop using caretPosition in useEditorEmojiPicker This bug seems to be caused by a race condition between React and Chrome which only occurs on Windows and only now that we've upgraded to React 18. That race condition occurs with how we map the selection range in the post textbox to its `caretPosition` state. That state has always been pretty janky, so I've decided to remove it. This also has some other benefits like improving UX by using `execCommand` which preserves the undo/redo stack when using the emoji picker and simplifying the code because we no longer have to manually mess with the cursor position. Also, while I was in there, I fixed some minor weirdness around how whitespace is handled when adding those emojis. * MM-66659 Stop using caretPosition in useKeyHandler * MM-66659 Stop using caretPosition for prefill message * MM-66659 Remove remaining traces of caretPosition in AdvancedTextEditor * Fix exclusive test * Fix "Fixed incorrect usage of useCallback in EmojiPickerItem" * Fixed incorrect usage of FixedSizeList in emoji picker This is the actual fix to the issue I thought I fixed previously by changing how `useCallback` was called in EmojiPickerItem. It turns out the actual issue is that we were passing a new function as the child of FixedSizeList on every render cycle which caused it to re-render all of the rows which somehow also assigned them new DOM Nodes as well. The EmojiPicker re-renders whenever we mouse over an emoji, so it would re-render the FixedSizeList and all of its children frequently when mousing over things. Apart from causing performance issues, that also seems to cause RTL to fail to click on an emoji the first time you call `userAgent.click` because the first call would move the mouse which would trigger a re-render, and that would seemingly cause RTL to forget what to click on. To fix that, I used a new React context to pass the extra props to the EmojiPickerCategoryOrEmojiRow. I could've also done that by adding them to the FixedSizeList's `itemData` prop, but that already contains a lot of heavy data, and I didn't want to add to that. * Revert changes to postMessageOnKeyPress * Run Prettier in playwright folder * Added docs to new Playwright test * Address feedback	2025-12-09 14:10:06 +00:00
Rohan Sharma	e905a36110	migrate display_test branch (#34516)	2025-11-25 23:02:19 +08:00
Dylan Haussermann	c8c28c1b9a	Add E2E test for unreads filter functionality (#34198) ... * Add E2E test for unreads filter functionality * implemented code review suggestions as folows: * Removed redundant `waitFor` --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-20 14:40:14 -05:00
Rahim Rahman	edb05c7ea5	Magic link (passwordless) authentication for guests (#34264) ... * Add EasyLogin configuration (#34217) * add easy login config * add easy login to the invite modal * add to the query parameters * Add an API to get login method for the login id (#34223) * add an api to get login method for the login id * do not return errors if user is not found * Add support for Easy Login invitation link sending (#34224) This generates Easy Login token types when requested. The server doesn't do anything with these tokens, yet - that will come in a future change. * Add support for logging in with easy login (#34236) * Fix E2E tests (#34240) * Prevent easy login accounts to reset their password (#34262) * Add easy login support to login api and limit token to 5 min (#34259) * webapp easy login ui mods (#34237) * webapp easy login ui mods * easy login i18n * lint issues * getUserLoginType * using the real API * easylogin proper redirect * remove unneeded functions and files * duplicated localization * remove easylogin * using EnableEasyLogin setting * localization fix * fix lint issue * remove excessive setIsWaiting * changed logic to make it more readable * renaming component to make easier editable * password will disappear when username change * login test * text for easy login password * Add app links to emails * Update templates and always land in the landing screen * Update svg image, improve checks on server, fix linking page and show deactivated on login type * Update naming * Fix mocks and imports * Remove all sessions on disable and forbid user promotion * Fix layer and tests * Address feedback * Fix tests * Fix missing string * Fix texts * Fix tests * Fix constant name * Fix tests * Fix test * Address feedback * Fix lint * Fix test * Address feedback * Fix test --------- Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: David Krauser <david@krauser.org> Co-authored-by: Daniel Espino <larkox@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-20 14:06:23 +01:00
Carlos Garcia	4ba7f7e16e	MM-66202: Migrate to aws-sdk-go-v2 (#34496) ... * updated aws-sdk dependency to aws-sdk-go-v2 * simplify error handling in case of timeout errors --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-20 11:26:09 +01:00
yasser khan	b8944f372d	Feat(e2e): Add tests cases for Content Flagging (#34288) ... - E2E tests for Content Flagging - Fixes tests failing on master	2025-11-19 10:16:57 +00:00
yasser khan	59b3b5797d	Fix failing playwright tests (#34535)	2025-11-19 06:06:56 +00:00
Nick Misasi	91dfcbbdd1	Integration permission management changes (#34421) ... * Support for permissions allowing end users to create and manage their own integrations if sysadmin deems necessary * Adjustments based on new understanding * remove extra functions now that we've consolidated * Fix webapp i18n * Update snapshots * Fix test * Fix some tests, refactor some more, and add a few extra * fix linter * Update snapshots * Fix test * Missed some cleanup * Fix e2e * Fi * Fix * Fixes from PR feedback * Update snapshots * Fix tests * Fix slash command list endpoint per PR feedback. Remove changes around OAuth Apps * Further reversions of oauth stuff * Update tests * Small changes to fix when customOnly=false * Remove extra perm from cypress * Fixes from Eva's feedback * Fix i18n * More fixing * More fixing	2025-11-13 11:12:30 +00:00
sabril	c40f6ee749	MM-65043 Add option to run E2E tests with FIPS build (#34318) ... * add option to run fips build * modify gh comments * organize gh and commit status * sanitize inputs, handle group concurrency * indicate fix in status context and fix comparison * handle fips comparison * updated per comments * reverted missed lines * fix failed cypress test by migrating to playwright --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-13 12:20:21 +08:00
Eva Sarafianou	0d181ca215	Push Proxy Authentication (#34211) ... * Initial Implementation of Push Proxy Authentication * Include Config Listener for Leader plus delete startup function as job scheduler runs on initialization * Remove push proxy auth from local imports * Add push proxy auth to external imports * Add push proxy auth error messages * Update error codes * Fix enterprise dep definition * make i18n-extract * Mock System store Get * m * m * m * m * Update serverID header * Add install type env var to docker * Update Push Proxy config with new options Global, US, Germany and Japan. Previous configurations will keep working * use model.SafeDereference * Delete token when new push proxy URL is empty * ServerID header only if auth token is available --------- Co-authored-by: Daniel Schalla <daniel@mattermost.com> Co-authored-by: Nick Misasi <nick.misasi@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-12 20:16:44 +02:00
Jesse Hallam	f2ff5511e8	Fix inconsistent terminology for revoking user sessions (#MM-66613) (#34461) ... Changed "Remove sessions" to "Revoke sessions" in System Console menu to match the terminology used in the confirmation modal and API. Also fixed TypeScript error in dropdown_input_hybrid component.	2025-11-12 13:44:54 -04:00
Jesse Hallam	a349bc7eae	MM-66138: Fix code preview loading spinner stuck indefinitely (#34107)	2025-11-10 16:40:35 -04:00
Rohan Sharma	e544214f65	feat: add accessibility tests for advanced settings panel (#34272) ... * feat: add accessibility tests for advanced settings panel * fix: formatting issues --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-04 14:30:27 +05:30
sabril	5c43b2ceb3	fix for vscode testing (#34285)	2025-10-27 14:08:50 +00:00
Elias Nahum	595e600eea	MM-65755 Admin Console UI for Auto-Translation (#33982) ... * AutoTranslate config settings * comment out Agents provider * Add auto translate timeout config validation * i18n messages for autotranslation config validation * fix test * validate url for libreTranslate * Feedback review * Admin Console UI for Auto-Translation * fix admin console conditional section display * i18n * removed unintentional change Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update admin.general.localization.autoTranslateProviderDescription newline * fix lint * Fix types * UX feedback review * fix typo in i18n * Fix AutoTranslation feature flag * feedback review * Fix test default values * feedback review * re-add isHidden property to feature discovery * fix lint and external url * Add settings to playwright * Add empty as a valid value for the Provider * Add searchable strings * set apikey input type as password --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2025-10-27 11:36:25 +08:00
sabril	b3b5f9d3e3	E2E/Playwright: Upgrade to playwright@1.56 and its dependencies (#34135) ... * upgrade to playwright@1.56 and its dependencies * move audited packages to devdep	2025-10-17 11:41:54 +08:00
sabril	18d2e8da9f	MM-63700 E2E/Playwright: Add accessibility testing guidelines (#33997) ... * add accessibility testing guidelines * use accessibility locators * address comments	2025-10-15 12:00:01 +08:00
Alejandro García Montoro	d3eb6cbf1c	Revert "MM-13657: Set ExperimentalStrictCSRFEnforcement to true by default (#33444)" (#34112) ... * Revert "MM-13657: Set ExperimentalStrictCSRFEnforcement to true by default (#33444)" This reverts commit 257eec43ed. * Fix call to checkCSRFToken * Adapt test that relied on strict CSRF enforcement This test was added after https://github.com/mattermost/mattermost/pull/33444, so it assumed strict CSRF enforcement to be enabled. When reverting that PR, we need to adapt the test to account for both cases. * Fix newer tests to use older setting	2025-10-10 19:15:45 +02:00
Asaad Mahmood	3de7e747ec	MM-62828 - Updating reactions tooltip (#34002) ... * MM-62828 - Updating reactions tooltip * Updating tests * Updating lint * Updating lint * Fixing lint * Updating test * Updating test * Updating test * Updating test * Updating tests * Updating reaction specs * Fixing cypress test * Updating intl * Updating tests --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-10-09 10:20:13 -04:00