mattermost/server/cmd/mmctl/commands/auth_utils_test.go
Ben Schumacher 4006683af0
Some checks are pending
API / build (push) Waiting to run
Server CI / Compute Go Version (push) Waiting to run
Server CI / Check mocks (push) Blocked by required conditions
Server CI / Check go mod tidy (push) Blocked by required conditions
Server CI / check-style (push) Blocked by required conditions
Server CI / Check serialization methods for hot structs (push) Blocked by required conditions
Server CI / Vet API (push) Blocked by required conditions
Server CI / Check migration files (push) Blocked by required conditions
Server CI / Generate email templates (push) Blocked by required conditions
Server CI / Check store layers (push) Blocked by required conditions
Server CI / Check mmctl docs (push) Blocked by required conditions
Server CI / Postgres with binary parameters (push) Blocked by required conditions
Server CI / Postgres (push) Blocked by required conditions
Server CI / Postgres (FIPS) (push) Blocked by required conditions
Server CI / Generate Test Coverage (push) Blocked by required conditions
Server CI / Run mmctl tests (push) Blocked by required conditions
Server CI / Run mmctl tests (FIPS) (push) Blocked by required conditions
Server CI / Build mattermost server app (push) Blocked by required conditions
Web App CI / check-lint (push) Waiting to run
Web App CI / check-i18n (push) Waiting to run
Web App CI / check-types (push) Waiting to run
Web App CI / test (push) Waiting to run
Web App CI / build (push) Waiting to run
Improve mmctl test practices and error handling (#34079)
Co-authored-by: Claude <noreply@anthropic.com>
2025-10-14 12:28:27 +02:00

176 lines
4.6 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package commands
import (
"os"
"os/user"
"path/filepath"
"strings"
"testing"
"github.com/spf13/viper"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestResolveConfigFilePath(t *testing.T) {
originalUser := *currentUser
defer func() {
SetUser(&originalUser)
}()
testUser, err := user.Current()
require.NoError(t, err)
t.Run("should return the default config file location if nothing else is set", func(t *testing.T) {
tmp, err := os.MkdirTemp("", "mmctl-")
require.NoError(t, err)
t.Cleanup(func() {
err = os.RemoveAll(tmp)
require.NoError(t, err)
})
testUser.HomeDir = tmp
SetUser(testUser)
expected := filepath.Join(getDefaultConfigHomePath(), configParent, configFileName)
viper.Set("config", filepath.Join(xdgConfigHomeVar, configParent, configFileName))
p := resolveConfigFilePath()
require.Equal(t, expected, p)
})
t.Run("should return config file location from xdg environment variable", func(t *testing.T) {
tmp, err := os.MkdirTemp("", "mmctl-")
require.NoError(t, err)
t.Cleanup(func() {
err = os.RemoveAll(tmp)
require.NoError(t, err)
})
testUser.HomeDir = tmp
SetUser(testUser)
expected := filepath.Join(testUser.HomeDir, ".config", configParent, configFileName)
t.Setenv("XDG_CONFIG_HOME", filepath.Join(testUser.HomeDir, ".config"))
viper.Set("config", filepath.Join(xdgConfigHomeVar, configParent, configFileName))
p := resolveConfigFilePath()
require.Equal(t, expected, p)
})
t.Run("should return the user-defined config file path if one is set", func(t *testing.T) {
tmp, err := os.MkdirTemp("", "mmctl-")
require.NoError(t, err)
t.Cleanup(func() {
err = os.RemoveAll(tmp)
require.NoError(t, err)
})
testUser.HomeDir = tmp + "/path/should/be/ignored"
SetUser(testUser)
expected := filepath.Join(tmp, configFileName)
t.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
viper.Set("config", expected)
p := resolveConfigFilePath()
require.Equal(t, expected, p)
})
t.Run("should resolve config file path if $HOME variable is used", func(t *testing.T) {
tmp, err := os.MkdirTemp("", "mmctl-")
require.NoError(t, err)
t.Cleanup(func() {
err = os.RemoveAll(tmp)
require.NoError(t, err)
})
testUser.HomeDir = tmp + "/path/should/be/ignored"
SetUser(testUser)
expected := filepath.Join(testUser.HomeDir, "/.config/mmctl/config")
t.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
viper.Set("config", "$HOME/.config/mmctl/config")
p := resolveConfigFilePath()
require.Equal(t, expected, p)
})
t.Run("should create the user-defined config file path if one is set", func(t *testing.T) {
tmp, err := os.MkdirTemp("", "mmctl-")
require.NoError(t, err)
t.Cleanup(func() {
err = os.RemoveAll(tmp)
require.NoError(t, err)
})
testUser.HomeDir = tmp + "path/should/be/ignored"
SetUser(testUser)
extraDir := "extra"
expected := filepath.Join(tmp, extraDir, "config.json")
t.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
viper.Set("config", expected)
err = SaveCredentials(Credentials{})
require.NoError(t, err)
info, err := os.Stat(expected)
require.NoError(t, err)
assert.False(t, info.IsDir())
assert.True(t, info.Name() == "config.json")
})
t.Run("should return error if the config flag is set to a directory", func(t *testing.T) {
tmp, err := os.MkdirTemp("", "mmctl-")
require.NoError(t, err)
t.Cleanup(func() {
err = os.RemoveAll(tmp)
require.NoError(t, err)
})
testUser.HomeDir = tmp + "path/should/be/ignored"
SetUser(testUser)
t.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
viper.Set("config", tmp)
err = SaveCredentials(Credentials{})
require.Error(t, err)
require.True(t, strings.HasSuffix(err.Error(), "is a directory"))
})
}
func TestReadSecretFromFile(t *testing.T) {
f, err := os.CreateTemp(t.TempDir(), "mmctl")
require.NoError(t, err)
_, err = f.WriteString("test-pass")
require.NoError(t, err)
t.Run("password from file", func(t *testing.T) {
var pass string
err := readSecretFromFile(f.Name(), &pass)
require.NoError(t, err)
require.Equal(t, "test-pass", pass)
})
t.Run("no file path is provided", func(t *testing.T) {
pass := "test-pass-2"
err := readSecretFromFile("", &pass)
require.NoError(t, err)
require.Equal(t, "test-pass-2", pass)
})
t.Run("nonexistent file provided", func(t *testing.T) {
var pass string
err := readSecretFromFile(filepath.Join(t.TempDir(), "bla"), &pass)
require.Error(t, err)
require.Empty(t, pass)
})
}