mirror of
https://github.com/mattermost/mattermost.git
synced 2026-02-03 20:40:00 -05:00
a1012d33eb
- We introduce 2 new APIs: 1. Scan: this allows incremental iteration without blocking the Redis server and is the recommended way to iterate over keys. With this, we have entirely removed the need for Keys. 2. RemoveMulti: this allows deletion of multiple keys in a single operation which optimizes network round trips. - While here, we make a small improvement to GetStatusFromCache, where we remove the shallow copy which wasn't necessary because we always serialize the data from the cache. - We do not use Redis for session cache because of frequent requests to iterate the entire cache which leads to a lot of `SCAN` calls. - Avoid broadcasting status update messages for Redis case. - Setting cache expiry for status cache - Removing .Set method altogether to prevent any chances of setting an item with no expiry. https://mattermost.atlassian.net/browse/MM-59932 ```release-note NONE ```
173 lines
4.1 KiB
Go
173 lines
4.1 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package cache
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
)
|
|
|
|
func TestNewCache(t *testing.T) {
|
|
t.Run("with only size option given", func(t *testing.T) {
|
|
p := NewProvider()
|
|
|
|
size := 1
|
|
c, err := p.NewCache(&CacheOptions{
|
|
Size: size,
|
|
DefaultExpiry: 0,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
err = c.SetWithDefaultExpiry("key1", "val1")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key2", "val2")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key3", "val3")
|
|
require.NoError(t, err)
|
|
})
|
|
|
|
t.Run("with only size option given", func(t *testing.T) {
|
|
p := NewProvider()
|
|
|
|
size := 1
|
|
c, err := p.NewCache(&CacheOptions{
|
|
Size: size,
|
|
DefaultExpiry: 0,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
err = c.SetWithDefaultExpiry("key1", "val1")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key2", "val2")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key3", "val3")
|
|
require.NoError(t, err)
|
|
})
|
|
|
|
t.Run("with all options specified", func(t *testing.T) {
|
|
p := NewProvider()
|
|
|
|
size := 1
|
|
expiry := 1 * time.Second
|
|
event := model.ClusterEvent("clusterEvent")
|
|
c, err := p.NewCache(&CacheOptions{
|
|
Size: size,
|
|
Name: "name",
|
|
DefaultExpiry: expiry,
|
|
InvalidateClusterEvent: event,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, event, c.GetInvalidateClusterEvent())
|
|
|
|
err = c.SetWithDefaultExpiry("key1", "val1")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key2", "val2")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key3", "val3")
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(expiry + 1*time.Second)
|
|
|
|
var v string
|
|
err = c.Get("key1", &v)
|
|
require.Equal(t, ErrKeyNotFound, err)
|
|
err = c.Get("key2", &v)
|
|
require.Equal(t, ErrKeyNotFound, err)
|
|
err = c.Get("key3", &v)
|
|
require.Equal(t, ErrKeyNotFound, err)
|
|
})
|
|
}
|
|
|
|
func TestNewCache_Striped(t *testing.T) {
|
|
t.Run("with only size option given", func(t *testing.T) {
|
|
p := NewProvider()
|
|
|
|
size := 1
|
|
c, err := p.NewCache(&CacheOptions{
|
|
Size: size,
|
|
Striped: true,
|
|
StripedBuckets: 1,
|
|
DefaultExpiry: 0,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
err = c.SetWithDefaultExpiry("key1", "val1")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key2", "val2")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key3", "val3")
|
|
require.NoError(t, err)
|
|
})
|
|
|
|
t.Run("with only size option given", func(t *testing.T) {
|
|
p := NewProvider()
|
|
|
|
size := 1
|
|
c, err := p.NewCache(&CacheOptions{
|
|
Size: size,
|
|
Striped: true,
|
|
StripedBuckets: 1,
|
|
DefaultExpiry: 0,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
err = c.SetWithDefaultExpiry("key1", "val1")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key2", "val2")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key3", "val3")
|
|
require.NoError(t, err)
|
|
})
|
|
|
|
t.Run("with all options specified", func(t *testing.T) {
|
|
p := NewProvider()
|
|
|
|
size := 1
|
|
expiry := 1 * time.Second
|
|
event := model.ClusterEvent("clusterEvent")
|
|
c, err := p.NewCache(&CacheOptions{
|
|
Size: size,
|
|
Name: "name",
|
|
DefaultExpiry: expiry,
|
|
InvalidateClusterEvent: event,
|
|
Striped: true,
|
|
StripedBuckets: 1,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, event, c.GetInvalidateClusterEvent())
|
|
|
|
err = c.SetWithDefaultExpiry("key1", "val1")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key2", "val2")
|
|
require.NoError(t, err)
|
|
err = c.SetWithDefaultExpiry("key3", "val3")
|
|
require.NoError(t, err)
|
|
|
|
time.Sleep(expiry + 1*time.Second)
|
|
|
|
var v string
|
|
err = c.Get("key1", &v)
|
|
require.Equal(t, ErrKeyNotFound, err)
|
|
err = c.Get("key2", &v)
|
|
require.Equal(t, ErrKeyNotFound, err)
|
|
err = c.Get("key3", &v)
|
|
require.Equal(t, ErrKeyNotFound, err)
|
|
})
|
|
}
|
|
|
|
func TestConnectClose(t *testing.T) {
|
|
p := NewProvider()
|
|
|
|
_, err := p.Connect()
|
|
require.NoError(t, err)
|
|
|
|
err = p.Close()
|
|
require.NoError(t, err)
|
|
}
|