mirror of
https://github.com/mattermost/mattermost.git
synced 2026-02-03 20:40:00 -05:00
efaa6264cc
It was a good decision in hindsight to keep the public module as 0.x because this would have been a breaking change again. https://mattermost.atlassian.net/browse/MM-53032 ```release-note Changed the Go module path from github.com/mattermost/mattermost-server/server/v8 to github.com/mattermost/mattermost/server/v8. For the public facing module, it's path is also changed from github.com/mattermost/mattermost-server/server/public to github.com/mattermost/mattermost/server/public ```
60 lines
1.7 KiB
Go
60 lines
1.7 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package main
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCheckAPIVersionComments(t *testing.T) {
|
|
testCases := []struct {
|
|
name, pkgPath, err string
|
|
expected result
|
|
}{
|
|
{
|
|
name: "valid comments",
|
|
pkgPath: "github.com/mattermost/mattermost/server/public/plugin/checker/internal/test/valid",
|
|
err: "",
|
|
},
|
|
{
|
|
name: "invalid comments",
|
|
pkgPath: "github.com/mattermost/mattermost/server/public/plugin/checker/internal/test/invalid",
|
|
expected: result{
|
|
Errors: []string{"internal/test/invalid/invalid.go:15:2: missing a minimum server version comment on method InvalidMethod"},
|
|
},
|
|
},
|
|
{
|
|
name: "missing API interface",
|
|
pkgPath: "github.com/mattermost/mattermost/server/public/plugin/checker/internal/test/missing",
|
|
err: "could not find API interface",
|
|
},
|
|
{
|
|
name: "non-existent package path",
|
|
pkgPath: "github.com/mattermost/mattermost/server/public/plugin/checker/internal/test/does_not_exist",
|
|
err: "could not find API interface",
|
|
},
|
|
}
|
|
|
|
// Enable debug flag to have packagesdriver/sizes.go print stderr of `go list` command.
|
|
// We want to surface any error text that may exist in stderr of this command.
|
|
prevEnvValue := os.Getenv("GOPACKAGESPRINTGOLISTERRORS")
|
|
os.Setenv("GOPACKAGESPRINTGOLISTERRORS", "true")
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
res, err := checkAPIVersionComments(tc.pkgPath)
|
|
assert.Equal(t, res, tc.expected)
|
|
|
|
if tc.err != "" {
|
|
assert.EqualError(t, err, tc.err)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
os.Setenv("GOPACKAGESPRINTGOLISTERRORS", prevEnvValue)
|
|
}
|