mirror of
https://github.com/mattermost/mattermost.git
synced 2026-02-03 20:40:00 -05:00
b61580f87f
* fix(pluginapi/store): init master db if no replica GetReplicaDB return nil because masterDB is not initialized. * chore: add test
135 lines
3.8 KiB
Go
135 lines
3.8 KiB
Go
package pluginapi_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/plugin/plugintest"
|
|
"github.com/mattermost/mattermost/server/public/pluginapi"
|
|
)
|
|
|
|
func TestStore(t *testing.T) {
|
|
t.Run("master db singleton", func(t *testing.T) {
|
|
api := &plugintest.API{}
|
|
|
|
driver := &plugintest.Driver{}
|
|
defer driver.AssertExpectations(t)
|
|
driver.On("Conn", true).Return("test", nil)
|
|
driver.On("ConnPing", "test").Return(nil)
|
|
driver.On("ConnClose", "test").Return(nil)
|
|
|
|
store := pluginapi.NewClient(api, driver).Store
|
|
|
|
db1, err := store.GetMasterDB()
|
|
require.NoError(t, err)
|
|
require.NotNil(t, db1)
|
|
|
|
db2, err := store.GetMasterDB()
|
|
require.NoError(t, err)
|
|
require.NotNil(t, db2)
|
|
|
|
require.Same(t, db1, db2)
|
|
require.NoError(t, store.Close())
|
|
})
|
|
|
|
t.Run("master db fallback", func(t *testing.T) {
|
|
config := &model.Config{
|
|
SqlSettings: model.SqlSettings{
|
|
DriverName: model.NewPointer("ramsql"),
|
|
DataSource: model.NewPointer("TestStore-master-db"),
|
|
ConnMaxLifetimeMilliseconds: model.NewPointer(2),
|
|
},
|
|
}
|
|
|
|
driver := &plugintest.Driver{}
|
|
defer driver.AssertExpectations(t)
|
|
driver.On("Conn", true).Return("test", nil)
|
|
driver.On("ConnPing", "test").Return(nil)
|
|
driver.On("ConnClose", "test").Return(nil)
|
|
|
|
api := &plugintest.API{}
|
|
defer api.AssertExpectations(t)
|
|
store := pluginapi.NewClient(api, driver).Store
|
|
|
|
api.On("GetUnsanitizedConfig").Return(config)
|
|
masterDB, err := store.GetMasterDB()
|
|
require.NoError(t, err)
|
|
require.NotNil(t, masterDB)
|
|
|
|
// No replica is set up, should fallback to master
|
|
replicaDB, err := store.GetReplicaDB()
|
|
require.NoError(t, err)
|
|
require.Same(t, replicaDB, masterDB)
|
|
|
|
require.NoError(t, store.Close())
|
|
})
|
|
|
|
t.Run("master db fallback without get master first", func(t *testing.T) {
|
|
config := &model.Config{
|
|
SqlSettings: model.SqlSettings{
|
|
DriverName: model.NewPointer("ramsql"),
|
|
DataSource: model.NewPointer("TestStore-master-db"),
|
|
ConnMaxLifetimeMilliseconds: model.NewPointer(2),
|
|
},
|
|
}
|
|
|
|
driver := &plugintest.Driver{}
|
|
defer driver.AssertExpectations(t)
|
|
driver.On("Conn", true).Return("test", nil)
|
|
driver.On("ConnPing", "test").Return(nil)
|
|
driver.On("ConnClose", "test").Return(nil)
|
|
|
|
api := &plugintest.API{}
|
|
defer api.AssertExpectations(t)
|
|
store := pluginapi.NewClient(api, driver).Store
|
|
|
|
api.On("GetUnsanitizedConfig").Return(config)
|
|
// No replica is set up, should fallback to master
|
|
replicaDB, err := store.GetReplicaDB()
|
|
require.NoError(t, err)
|
|
require.NotNil(t, replicaDB)
|
|
|
|
masterDB, err := store.GetMasterDB()
|
|
require.NoError(t, err)
|
|
require.NotNil(t, masterDB)
|
|
require.Same(t, replicaDB, masterDB)
|
|
|
|
require.NoError(t, store.Close())
|
|
})
|
|
|
|
t.Run("replica db singleton", func(t *testing.T) {
|
|
config := &model.Config{
|
|
SqlSettings: model.SqlSettings{
|
|
DriverName: model.NewPointer("ramsql"),
|
|
DataSource: model.NewPointer("TestStore-master-db"),
|
|
DataSourceReplicas: []string{"TestStore-master-db"},
|
|
ConnMaxLifetimeMilliseconds: model.NewPointer(2),
|
|
},
|
|
}
|
|
|
|
api := &plugintest.API{}
|
|
defer api.AssertExpectations(t)
|
|
api.On("GetUnsanitizedConfig").Return(config)
|
|
|
|
driver := &plugintest.Driver{}
|
|
defer driver.AssertExpectations(t)
|
|
driver.On("Conn", false).Return("test", nil)
|
|
driver.On("ConnPing", "test").Return(nil)
|
|
driver.On("ConnClose", "test").Return(nil)
|
|
|
|
store := pluginapi.NewClient(api, driver).Store
|
|
|
|
db1, err := store.GetReplicaDB()
|
|
require.NoError(t, err)
|
|
require.NotNil(t, db1)
|
|
|
|
db2, err := store.GetReplicaDB()
|
|
require.NoError(t, err)
|
|
require.NotNil(t, db2)
|
|
|
|
require.Same(t, db1, db2)
|
|
require.NoError(t, store.Close())
|
|
})
|
|
}
|