Jacob Hansen
ae2fe683e3
check_curl.t: Adjust test to use -f curl
...
It appears that `-f follow` doesn't work correctly in `check_curl` at
the moment. Test adjusted to use `-f curl` instead.
Issue for the above created: https://github.com/monitoring-plugins/monitoring-plugins/issues/1685
Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-18 15:19:43 +02:00
Aksel Sjögren
5ab03a7095
Fix conditional tests for check_http, check_curl
...
Set correct number of tests in skip- blocks to avoid the error "Bad
plan. You planned 50 tests but ran 55" when run with/without
/usr/bin/faketime and NP_INTERNET_ACCESS=yes/no.
2021-04-30 11:13:59 +02:00
Sven Nierlein
fc71e3f930
migrate travis ci to github actions
2021-04-30 09:56:52 +02:00
Sven Nierlein
444a3579b2
fix fping test
...
in case of dns errors, fping returns an unknown and thats ok.
2021-04-30 09:56:52 +02:00
Barak Shohat
f0ac7fcc7c
check_curl: Fix bug where headers beginning with HTTP_ cause the status line parsing to fail.
2021-04-13 12:06:18 +02:00
Andreas Baumann
cd358cd08a
check_curl: backported --show-body/-B to print body (from check_http)
2021-04-08 20:39:48 +02:00
Andreas Baumann
1debd29b57
check_curl: make -C obvious (from check_http, part 2)
2021-04-08 15:14:53 +02:00
Andreas Baumann
a6acea7941
check_curl: make -C obvious (from check_http)
2021-04-08 14:15:54 +02:00
Andreas Baumann
f90aec83cb
check_curl: Increase regexp limit (to 1024 as in check_http)
2021-04-08 14:07:20 +02:00
Sven Nierlein
f6fd14e886
Merge pull request #1669 from bazzisoft/verify-cert
...
Add an option to check_curl to verify the peer certificate & host using the system CA's
2021-04-07 17:51:38 +02:00
Sven Nierlein
b145ea1998
Merge pull request #1554 from stblassitude/master
...
Docs check_http: make -C obvious
2021-04-07 17:16:12 +02:00
Sven Nierlein
4ad33d9f27
Merge pull request #1566 from hydrapolic/master
...
plugins: check_http: Increase regexp limit
2021-04-07 17:15:20 +02:00
Sven Nierlein
de7effdf06
Merge pull request #1465 from lausser/master
...
check_snmp: put the "c" (to mark a counter) after the perfdata value
2021-04-07 17:12:38 +02:00
waja
7ac706e894
Merge pull request #1663 from waja/debian_982847_2
...
Using snprintf which honors the buffers size and guarantees null temination. (Closes : #1601 )
2021-04-07 16:45:59 +02:00
Barak Shohat
6993c21695
Add an option to check_curl to verify the peer certificate & host using the system CA's
2021-04-07 15:38:47 +03:00
Sven Nierlein
1033724797
Merge pull request #1668 from bazzisoft/master
...
Update check_curl.c to display a specific human-readable error message where possible
2021-04-07 11:49:10 +02:00
Barak Shohat
2482950e26
Updated check_curl.c to display a specific human-readable error message where possible
2021-04-07 12:36:55 +03:00
Sven Nierlein
2e5b38cc83
Merge pull request #1666 from sni/check_curl_fix_header_parser
...
fix check_curl crash if http header contains leading spaces
2021-04-07 10:30:31 +02:00
Sven Nierlein
b820725ee1
Merge pull request #1644 from ghciv6/check_mysql_query_1562
...
- fix for issue #1562
2021-04-07 09:25:15 +02:00
Sven Nierlein
5cfc93d995
fix check_curl crash if http header contains leading spaces
...
check_curl crashes when a (broken) http server returns invalid http header with
leading spaces or double colons. This PR adds a fix and a test case for this.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-03-11 13:33:16 +01:00
Andreas Baumann
0f926a3566
check_curl: added string_statuscode function for printing HTTP/1.1 and HTTP/2 correctly
2021-03-08 19:46:43 +01:00
Florian Lohoff
dae075e65a
Using snprintf which honors the buffers size and guarantees null termination. ( Closes : #1601 )
...
As strcpy may overflow the resulting buffer:
flo@p5:~$ /tmp/f/usr/lib/nagios/plugins/check_pgsql -d "$(seq 1 10000)"
*** buffer overflow detected ***: terminated
Aborted
I would propose to change the code rather like this, using snprintf
which honors the buffers size and guarantees null termination.
2021-02-15 15:34:07 +01:00
Andreas Baumann
a260c798de
Merge branch 'master' into feature_check_curl
2021-02-08 20:13:47 +01:00
Andreas Baumann
d9a5d1faf0
check_curl: fixed a potential buffer overflow in url buffer
2021-01-19 18:35:41 +01:00
Andreas Baumann
ede8defad4
check_curl: fixed help, usage and errors for TLS 1.3
2021-01-19 18:32:27 +01:00
Rolf Eike Beer
ad99755033
check_dns: split multiple IP addresses passed in one -a argument
2020-11-02 20:05:56 +01:00
Sven Nierlein
739a7bbe7c
Merge pull request #1514 from Rasp8e/master
...
Proxy authorization is now kept when using PROXY + CONNECT to HTTPS
2020-09-23 17:19:23 +02:00
ghciv6
b8b87b55d6
- fix for issue #1562
...
1st compare then free up resources
2020-09-15 21:36:27 +02:00
ghciv6
905b09c38b
detect unreachable dns service in nslookup output (from bind-utils-9.8.2)
...
prevent core if error_scan detects an error in a line without ':'
2020-05-20 23:02:42 +02:00
Sven Nierlein
772fb233b9
check_curl: host_name may be null
...
for example when using like: ./check_curl localhost
2020-05-18 14:08:45 +02:00
Sven Nierlein
7d2582deb3
update test parameter according to check_http
2020-05-18 14:08:27 +02:00
Sven Nierlein
84fd9ae893
check_curl: use CURLOPT_RESOLVE to fix connecting to the right ip
...
when using ssl, the composed url contains the hostname instead of the specified
ip. So use CURLOPT_RESOLVE to make curl still connect to the ip.
2020-05-18 13:43:17 +02:00
Sven Nierlein
8a64e47083
check_curl: clean trailing whitespace
2020-05-18 11:30:34 +02:00
Sven Nierlein
d54f14a092
merge test changes from check_http
...
the example certificate has changed since.
2020-05-15 14:24:18 +02:00
Sven Nierlein
072e97d5de
tests: update expired test certificate
...
the certificate used to test expired http checks is to old to be used
with recent ssl libraries and results in:
> SSL routines:SSL_CTX_use_certificate:ee key too small
unfortunatly the error is only visible when setting $IO::Socket::SSL::DEBUG in
the check_http.t file.
2020-05-15 14:24:18 +02:00
Andreas Baumann
adb9588494
Merge branch 'master' into feature_check_curl
2020-01-09 14:54:12 +01:00
Alexander A. Klimov
f53ea7afd8
check_tcp: add --sni
2020-01-07 21:32:15 +01:00
Christian Tacke
9da7cd7681
Fix timeout_interval declarations
...
There are different declarations for timeout_interval:
lib/utils_base.c has the definition:
unsigned int timeout_interval = DEFAULT_SOCKET_TIMEOUT;
lib/utils_base.h has the appropiate declaration:
extern unsigned int timeout_interval;
plugins/popen.h has an extra declaration:
extern unsigned int timeout_interval;
This doesn't hurt, but it's a dupe. The one in utils_base.h
should be enough, so remove this one.
plugins/popen.c has a WRONG one:
extern int timeout_interval;
Remove it!
Use #include "utils.h" to get the right one.
This makes the local defines for max/min unnecassary, so
remove them also.
2020-01-07 10:22:39 +01:00
Andreas Baumann
5e0c236d6a
increased copyright
2019-12-29 10:23:02 +00:00
Andreas Baumann
1b689dab5e
check_curl: NSS, parse more date formats from certificate (in -C cert check)
2019-11-07 15:31:52 +00:00
Andreas Baumann
f7efee5f9c
check_curl: more tolerant CN= parsing when checking certificates (hit on Centos 8)
2019-11-07 08:20:17 +00:00
Andreas Baumann
ede43c848d
setting no_body to TRUE when we have a HEAD request
2019-10-11 17:22:34 +02:00
Andreas Baumann
04c58e0210
some LIBCURL_VERSION checks around HTTP/2 feature
2019-09-07 16:06:17 +02:00
Andreas Baumann
f546041722
added --http-version option to check_curl to choose HTTP version
2019-09-07 15:58:09 +02:00
Andreas Baumann
95ee6ace09
improved curlhelp_parse_statusline to handle both HTTP/1.x and HTTP/2
2019-09-07 15:31:15 +02:00
Andreas Baumann
fe91deb40c
check_curl: updates embedded picohttpparser to newest git version
2019-09-07 14:22:00 +02:00
Andreas Baumann
4d666514f2
setting progname of check_curl plugin to check_curl (at least for now)
2019-09-07 11:20:13 +02:00
Andreas Baumann
34cc70c3c6
Merge branch 'master' into feature_check_curl
2019-07-18 08:40:35 +02:00
Sven Nierlein
e8325b39c4
fix maxfd being zero
...
If _SC_OPEN_MAX is available then maxfd was zero initialized and never set to the value from sysconf.
This leads to segfaults with free(): invalid size introduced by commit 7cafb0e845 .
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2019-05-24 14:51:10 +02:00
Christopher Odenbach
a15d425598
include -P switch in help
2019-04-09 09:49:57 +02:00