Lorenz Kästle
efba4f7654
check_icmp: cleanup some leftover comments
2025-06-23 10:32:24 +02:00
Lorenz Kästle
cd20cc0632
check_icmp: add long options, add output format option
...
This commit switches check_icmp from getopt to getopt_long
to provide long options too and (most importantly) homogenize
option parsing between the different plugins.
2025-06-23 10:17:28 +02:00
Lorenz Kästle
8ae415ee4c
Improve check_icmp help output
2025-06-23 10:16:42 +02:00
Lorenz Kästle
d2735eecd4
Fix number of tests
2025-06-20 10:53:46 +02:00
Lorenz Kästle
6bc2e75199
Fix test with weird arguments
2025-06-20 10:28:45 +02:00
Lorenz Kästle
2bea8e9522
check_icmp: Remove signal handling and timeouts
...
The timeout option was redundant in that the runtime
of check_icmp was always limited by the input parameters
and therefore timeout gets removed with this commit to
avoid that confusion.
The rest of the signal handlings was removed too, since
the added complexity does not provide sufficient returns.
If check_icmp gets a signal, it now dies like most other
programs instead of trying to save some things and return a
(arguably wrong) result.
2025-06-20 10:04:34 +02:00
Lorenz Kästle
20e938bb54
Override state with min_hosts_alive
2025-06-19 01:15:37 +02:00
Lorenz Kästle
ca954e4f76
Reintroduce min_hosts_alive
2025-06-19 00:55:41 +02:00
Lorenz Kästle
43ae5fbe2d
Fix possible multiplication overflow?
2025-06-17 15:44:35 +02:00
Lorenz Kästle
f680cd7b88
Improve error detection for threshold parsers
2025-06-17 15:19:30 +02:00
Lorenz Kästle
0f8690c19b
Remove check_icmp text regex tests
2025-06-09 12:42:17 +02:00
Lorenz Kästle
906e895c72
Format specifier fixes
2025-05-18 19:19:07 +02:00
Lorenz Kästle
738d58714d
some more fixes
2025-05-18 19:11:14 +02:00
Lorenz Kästle
3b76fdc840
Fix typos
2025-05-18 18:48:49 +02:00
Lorenz Kästle
d92bbaef83
Some more fixes
2025-05-18 18:46:30 +02:00
Lorenz Kästle
b5de682309
WIP - check_icmp refactor 8
2025-05-18 18:10:25 +02:00
Lorenz Kästle
8f08e7ab3e
WIP - check_icmp refactor 7
2025-05-18 14:44:31 +02:00
Lorenz Kästle
fbcd11acb7
Clang-format
2025-05-18 00:20:36 +02:00
Lorenz Kästle
a01d522c4c
WIP - check_icmp refactor 6
2025-05-17 11:49:06 +02:00
Lorenz Kästle
322cd6f829
Lib: Add perfdata for char and unsigned char
2025-05-17 11:26:27 +02:00
Lorenz Kästle
6b86583e0d
WIP - check_icmp refactor 5
2025-05-16 12:46:56 +02:00
Lorenz Kästle
9ebde5eb09
WIP - check_icmp refactor 4
2025-05-06 00:01:42 +02:00
Lorenz Kästle
5fd8191a50
WIP - check_icmp refactor 3
2025-05-05 22:52:56 +02:00
Lorenz Kästle
5a6adcb7db
WIP - check_icmp refactor 2
2025-05-04 01:42:52 +02:00
Lorenz Kästle
eafee9c3f9
WIP: check_icmp refactor
2025-04-28 22:01:01 +02:00
Lorenz Kästle
f62f182653
check_icmp: localise variables
2025-04-02 01:04:25 +02:00
Lorenz Kästle
4ab8a54c52
check_icmp: linter fixes
2025-04-02 00:13:20 +02:00
Lorenz Kästle
89f79cf2d2
check_icmp: set rtmin initially
2024-11-28 09:02:29 +01:00
Lorenz Kästle
714fd1aceb
check_icmp: Add some lines to introduce some readability
2024-11-28 09:02:29 +01:00
Lorenz Kästle
eb9f9cf8c4
check_icmp: clang-format
2024-11-28 09:02:29 +01:00
Lorenz Kästle
de6e3c45f3
check_icmp: Apply clang-format again
2024-10-30 17:12:19 +01:00
Lorenz Kästle
3f1db8dc3a
Merge branch 'master' into cleanup/check_icmp
2024-10-30 17:07:04 +01:00
RincewindsHat
aa1f9c5011
check_icmp: clang-format
2024-10-16 00:11:39 +02:00
RincewindsHat
cd4d59fbd4
check_dhcp: Declare internal variables static
2024-10-15 16:09:09 +02:00
RincewindsHat
a0e2266c75
check_dhcp: Update copyright
2024-10-15 16:01:27 +02:00
RincewindsHat
3934457c2a
check_dhcp: clang-format
2024-10-15 16:00:07 +02:00
RincewindsHat
c0694cc6b5
check_icmp: Update copyright
2024-10-15 11:56:41 +02:00
RincewindsHat
780909f980
check_icmp: Properly mark function with void input
2024-10-15 11:55:27 +02:00
RincewindsHat
85f2e32e27
check_icmp: Declare internal variables static
2024-10-15 11:55:08 +02:00
RincewindsHat
0caa47a50b
check_icmp: clang-format
2024-10-15 11:44:28 +02:00
Sven Nierlein
0488426c7e
check_icmp: keep performance data order in case of none-reachable hosts
...
For responding hosts nothing changes:
./check_icmp -H 10.0.0.1
OK - 10.0.0.1 rta 0.336ms lost 0%|rta=0.336ms;200.000;500.000;0; rtmax=0.471ms;;;; rtmin=0.000ms;;;; pl=0%;40;80;0;100
In case the host is down, the performance data now contain 'U' according to:
https://www.monitoring-plugins.org/doc/guidelines.html#AEN201
Old:
./check_icmp -H 10.0.0.99
CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|pl=100%;40;80;0;100
Old:
./check_icmp -H 10.0.0.99
CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|rta=U;;;; rtmax=U;;;; rtmin=U;;;; pl=100%;40;80;0;100
This confuses some performance graphing tools, ex.: pnp.
Signed-off-by: Sven Nierlein <sven@consol.de>
2024-03-01 09:03:17 +01:00
RincewindsHat
8fe3fc7829
check_dhcp: Make implicit conversion explicit to dismiss warning
2023-12-29 00:59:58 +01:00
Eric Knibbe
f25648d6bb
Prevent -lcrypto from showing up in Makefile dependencies
2023-12-06 11:40:18 -05:00
RincewindsHat
79e2f52094
Fix for -Wunused-but-set-variable
2023-10-16 00:59:30 +02:00
Lorenz Kästle
b6d3acf5e3
Merge branch 'master' into check_dhcp_rogue_detection
2023-10-13 19:09:29 +02:00
RincewindsHat
f5074ac7f0
Fix spelling stuff
2023-10-13 01:29:31 +02:00
RincewindsHat
0de0daccec
Add some more comments about the MOS score
2023-10-13 01:25:22 +02:00
RincewindsHat
eb6c83a650
Even more code formatting and cleanup
2023-10-09 14:03:36 +02:00
RincewindsHat
9da06d5625
Do some more formatting
2023-10-09 01:57:37 +02:00
RincewindsHat
c568ad207c
Remove preprocessor macro
2023-10-09 01:31:52 +02:00